From: Thomas Monjalon <thomas@monjalon.net> To: Stephen Hemminger <stephen@networkplumber.org> Cc: maryam.tahhan@intel.com, reshma.pattan@intel.com, hemant.agrawal@nxp.com, dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports Date: Fri, 17 Jul 2020 17:01:00 +0200 Message-ID: <9275553.NR17kIY6SJ@thomas> (raw) In-Reply-To: <20200715212228.28010-7-stephen@networkplumber.org> 15/07/2020 23:22, Stephen Hemminger: > --- a/app/proc-info/Makefile > +++ b/app/proc-info/Makefile > +CFLAGS += -DALLOW_EXPERIMENTAL_API not needed in app/ > +CFLAGS += -O3 > CFLAGS += $(WERROR_FLAGS) > +CFLAGS += -Wno-deprecated-declarations Which deprecated function is used? We must not use deprecated functions. > + /* If no port mask was specified, one will be provided */ Would be nice to help the user by printing a port mask of owned and unowned ports. > + if (enabled_port_mask == 0) { > + RTE_ETH_FOREACH_DEV(i) { > + enabled_port_mask |= 1u << i; > } > } > > + for (port_mask = enabled_port_mask; port_mask != 0; > + port_mask &= ~(1u << i)) { Please would be good to help drunk or sleepy readers with few comments. > + /* ffs() first bit is 1 not 0 */ > + i = ffs(port_mask) - 1; > + > + if (i >= RTE_MAX_ETHPORTS) > + break; This check is already done in rte_eth_dev_is_valid_port(). > + > + if (!rte_eth_dev_is_valid_port(i)) > + continue;
next prev parent reply other threads:[~2020-07-17 15:01 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-06 19:37 [dpdk-dev] [PATCH 0/7] proc-info enhancements Stephen Hemminger 2020-05-06 19:37 ` [dpdk-dev] [PATCH 1/7] app/proc-info: remove unused logtype #define Stephen Hemminger 2020-05-06 19:37 ` [dpdk-dev] [PATCH 2/7] app/proc-info: eliminate useless borders Stephen Hemminger 2020-05-06 19:37 ` [dpdk-dev] [PATCH 3/7] app/proc-info: hide EAL info messages Stephen Hemminger 2020-05-06 19:37 ` [dpdk-dev] [PATCH 4/7] app/proc-info: add more info to show_ports Stephen Hemminger 2020-05-06 19:37 ` [dpdk-dev] [PATCH 5/7] app/proc-info: hide crypto-context display Stephen Hemminger 2020-05-06 19:37 ` [dpdk-dev] [PATCH 6/7] app/proc-info: dump rx and tx descriptor info Stephen Hemminger 2020-05-06 19:37 ` [dpdk-dev] [PATCH 7/7] app/proc-info: provide way to request info on owned ports Stephen Hemminger 2020-05-06 19:57 ` [dpdk-dev] [PATCH v2 0/7] app/proc-info enhancements Stephen Hemminger 2020-05-06 19:57 ` [dpdk-dev] [PATCH v2 1/7] app/proc-info: remove unused logtype #define Stephen Hemminger 2020-05-06 19:57 ` [dpdk-dev] [PATCH v2 2/7] app/proc-info: eliminate useless borders Stephen Hemminger 2020-05-06 19:57 ` [dpdk-dev] [PATCH v2 3/7] app/proc-info: hide EAL info messages Stephen Hemminger 2020-05-06 19:57 ` [dpdk-dev] [PATCH v2 4/7] app/proc-info: add more info to show_ports Stephen Hemminger 2020-07-13 12:09 ` Hemant Agrawal 2020-05-06 19:57 ` [dpdk-dev] [PATCH v2 5/7] app/proc-info: hide crypto-context display Stephen Hemminger 2020-05-06 19:57 ` [dpdk-dev] [PATCH v2 6/7] app/proc-info: dump rx and tx descriptor info Stephen Hemminger 2020-07-13 12:08 ` Hemant Agrawal 2020-05-06 19:57 ` [dpdk-dev] [PATCH v2 7/7] app/proc-info: provide way to request info on owned ports Stephen Hemminger 2020-07-13 12:10 ` [dpdk-dev] [PATCH v2 0/7] app/proc-info enhancements Hemant Agrawal 2020-07-15 21:22 ` [dpdk-dev] [PATCH v3 0/7] app/proc-info enhancments Stephen Hemminger 2020-07-15 21:22 ` [dpdk-dev] [PATCH v3 1/7] app/proc-info: remove unused logtype #define Stephen Hemminger 2020-07-15 21:22 ` [dpdk-dev] [PATCH v3 2/7] app/proc-info: eliminate useless borders Stephen Hemminger 2020-07-17 14:06 ` Thomas Monjalon 2020-08-13 4:10 ` Varghese, Vipin 2020-08-13 16:11 ` Stephen Hemminger 2020-08-14 0:45 ` Varghese, Vipin 2020-08-14 1:14 ` Varghese, Vipin 2020-08-14 3:18 ` Stephen Hemminger 2020-08-14 11:08 ` Varghese, Vipin 2020-08-14 14:56 ` Stephen Hemminger 2020-08-15 2:48 ` Varghese, Vipin 2020-07-15 21:22 ` [dpdk-dev] [PATCH v3 3/7] app/proc-info: hide EAL info messages Stephen Hemminger 2020-07-17 14:04 ` Thomas Monjalon 2020-07-15 21:22 ` [dpdk-dev] [PATCH v3 4/7] app/proc-info: add more info to show_ports Stephen Hemminger 2020-07-15 21:22 ` [dpdk-dev] [PATCH v3 5/7] app/proc-info: dump rx and tx descriptor info Stephen Hemminger 2020-07-15 21:22 ` [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports Stephen Hemminger 2020-07-17 15:01 ` Thomas Monjalon [this message] 2020-07-21 17:05 ` Stephen Hemminger 2020-07-21 17:08 ` Thomas Monjalon 2020-07-21 17:37 ` Stephen Hemminger 2020-07-15 21:22 ` [dpdk-dev] [PATCH v3 7/7] app/proc-info: add crypto security context info Stephen Hemminger 2020-07-21 18:22 ` [dpdk-dev] [PATCH v4 0/8] app/proc-info enhancements Stephen Hemminger 2020-07-21 18:22 ` [dpdk-dev] [PATCH v4 1/8] app/proc-info: remove unused logtype #define Stephen Hemminger 2020-07-21 18:22 ` [dpdk-dev] [PATCH v4 2/8] app/proc-info: eliminate useless borders Stephen Hemminger 2020-07-21 18:22 ` [dpdk-dev] [PATCH v4 3/8] app/proc-info: hide EAL info messages Stephen Hemminger 2020-07-21 18:22 ` [dpdk-dev] [PATCH v4 4/8] app/proc-info: add more info to show_ports Stephen Hemminger 2020-07-28 7:22 ` Hemant Agrawal (OSS) 2020-07-21 18:22 ` [dpdk-dev] [PATCH v4 5/8] app/proc-info: enhance mempool to print ops name Stephen Hemminger 2020-07-21 18:22 ` [dpdk-dev] [PATCH v4 6/8] app/proc-info: dump rx and tx descriptor info Stephen Hemminger 2020-07-21 18:22 ` [dpdk-dev] [PATCH v4 7/8] app/proc-info: add crypto security context info Stephen Hemminger 2020-07-21 18:22 ` [dpdk-dev] [PATCH v4 8/8] app/proc-info: provide way to request info on owned ports Stephen Hemminger 2020-07-28 5:39 ` Hemant Agrawal (OSS) 2020-07-28 5:45 ` Stephen Hemminger 2020-07-28 19:13 ` [dpdk-dev] [PATCH v5 0/8] app/proc-info enhancements Stephen Hemminger 2020-07-28 19:13 ` [dpdk-dev] [PATCH v5 1/8] app/proc-info: remove unused logtype #define Stephen Hemminger 2020-07-28 19:13 ` [dpdk-dev] [PATCH v5 2/8] app/proc-info: eliminate useless borders Stephen Hemminger 2020-07-28 19:13 ` [dpdk-dev] [PATCH v5 3/8] app/proc-info: hide EAL info messages Stephen Hemminger 2020-07-28 19:13 ` [dpdk-dev] [PATCH v5 4/8] app/proc-info: add more info to show_ports Stephen Hemminger 2020-07-28 19:13 ` [dpdk-dev] [PATCH v5 5/8] app/proc-info: enhance mempool to print ops name Stephen Hemminger 2020-07-28 19:13 ` [dpdk-dev] [PATCH v5 6/8] app/proc-info: dump rx and tx descriptor info Stephen Hemminger 2020-07-28 19:13 ` [dpdk-dev] [PATCH v5 7/8] app/proc-info: add crypto security context info Stephen Hemminger 2020-07-28 19:13 ` [dpdk-dev] [PATCH v5 8/8] app/proc-info: provide way to request info on owned ports Stephen Hemminger 2020-09-18 22:12 ` [dpdk-dev] [PATCH v5 0/8] app/proc-info enhancements Stephen Hemminger 2020-09-24 5:34 ` [dpdk-dev] [PATCH v6 0/7] app/proc-info: enhancements Stephen Hemminger 2020-09-24 5:34 ` [dpdk-dev] [PATCH v6 1/7] app/proc-info: remove unused logtype #define Stephen Hemminger 2020-09-24 5:34 ` [dpdk-dev] [PATCH v6 2/7] app/proc-info: eliminate useless borders Stephen Hemminger 2020-09-24 5:34 ` [dpdk-dev] [PATCH v6 3/7] app/proc-info: hide EAL info messages Stephen Hemminger 2020-09-24 5:34 ` [dpdk-dev] [PATCH v6 4/7] app/proc-info: add more info to show_ports Stephen Hemminger 2020-09-24 5:34 ` [dpdk-dev] [PATCH v6 5/7] app/proc-info: dump rx and tx descriptor info Stephen Hemminger 2020-09-24 5:34 ` [dpdk-dev] [PATCH v6 6/7] app/proc-info: add crypto security context info Stephen Hemminger 2020-09-24 5:34 ` [dpdk-dev] [PATCH v6 7/7] app/proc-info: provide way to request info on owned ports Stephen Hemminger 2020-10-19 22:39 ` [dpdk-dev] [PATCH v6 0/7] app/proc-info: enhancements Thomas Monjalon 2020-08-12 0:52 ` [dpdk-dev] [PATCH 0/7] proc-info enhancements Stephen Hemminger 2022-04-24 5:34 [dpdk-dev] [PATCH v3 6/7] app/proc-info: provide way to request info on owned ports Subendu Santra 2022-05-03 5:29 ` Subendu Santra 2022-05-03 8:47 ` Thomas Monjalon 2022-05-04 17:48 ` Stephen Hemminger 2022-05-10 9:09 ` Subendu Santra 2022-05-10 20:02 ` Stephen Hemminger 2022-05-11 7:36 ` Subendu Santra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9275553.NR17kIY6SJ@thomas \ --to=thomas@monjalon.net \ --cc=dev@dpdk.org \ --cc=hemant.agrawal@nxp.com \ --cc=maryam.tahhan@intel.com \ --cc=reshma.pattan@intel.com \ --cc=stephen@networkplumber.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git