From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 6F7E17260 for ; Wed, 17 Jan 2018 17:14:42 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2018 08:14:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,372,1511856000"; d="scan'208";a="20520883" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 17 Jan 2018 08:14:21 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 17 Jan 2018 08:14:21 -0800 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.21]) by FMSMSX153.amr.corp.intel.com ([169.254.9.194]) with mapi id 14.03.0319.002; Wed, 17 Jan 2018 08:14:21 -0800 From: "Wiles, Keith" To: "Yigit, Ferruh" CC: "Varghese, Vipin" , "dev@dpdk.org" , "Patel, Amol" , "Hunt, David" , "Jain, Deepak K" , "Pascal Mazon" Thread-Topic: [dpdk-dev] [PATCH v1] [net/tap] add logic to assign speed from user Thread-Index: AQHTekygZR/7i5MEiUehZjO86ZVWSqNOU3UAgCqYYICAAAIjAA== Date: Wed, 17 Jan 2018 16:14:21 +0000 Message-ID: <92A6F8C2-94CF-404D-9970-5357CEA79277@intel.com> References: <1513875200-5061-1-git-send-email-vipin.varghese@intel.com> <2893AEFC-6FD7-4D05-AB5B-F2AC018D1390@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.44.253] Content-Type: text/plain; charset="us-ascii" Content-ID: <6E3A0432C9756A4899D11EC6EF90FEF1@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] [net/tap] add logic to assign speed from user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 16:14:43 -0000 > On Jan 17, 2018, at 10:06 AM, Yigit, Ferruh wrot= e: >=20 > On 12/21/2017 1:38 PM, Wiles, Keith wrote: >>=20 >>=20 >>> On Dec 21, 2017, at 10:53 AM, Vipin Varghese = wrote: >>>=20 >>> TAP speed is passed as user argument, but never set to interface. >>> New logic brings speed get and set to LOCAL and REMOTE interfaces. >>>=20 >>> Updated the default PMD speeed to 10M as per Linux Kernel default >>> value. >>=20 >> The problem in setting the link speed to 10M is that TAP will not limit = its traffic to 10M. Applications like pktgen and others use the Link speed = to calculate the bit rate, which will be broken now. >>=20 >> I would suggest making the default value 10G or 40G instead as CPU speed= s will continue to increase. Forcing someone to always add the link speed s= eems a bit much when we know the systems can send/receive much higher then = 10M, which is the reason 10G was picked. Please set the default back to 10G= or some much higher number. >=20 > Hi Keith, Vipin, Pascal, >=20 > Since we really can't set the interface for Linux tap interface, what do = you > think removing speed arg completely from tap PMD? I have no problems with it being remove from the PMD. The only problem is t= his being a virtual interface it can be any speed, but 10M is unreasonable = IMO. I would like it to be set to something reasonable as the default (40G = or 10G) or would zero be more reasonable. I know the reported speed does not effect the performance, but tools that l= ook at the speed and attempt to use that speed need a value greater then th= e max bit rate of the interface IMO. If we had a value to indicate a bogus = speed then maybe the tools can adjust in some way. >=20 > Thanks, > ferruh >=20 >>=20 >>>=20 >>> Signed-off-by: Vipin Varghese >>> --- >>> drivers/net/tap/rte_eth_tap.c | 185 +++++++++++++++++++++++++++++++++++= ++++++- >>> 1 file changed, 182 insertions(+), 3 deletions(-) >>>=20 >>> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_ta= p.c >>> index 6b27679..7238504 100644 >>> --- a/drivers/net/tap/rte_eth_tap.c >>> +++ b/drivers/net/tap/rte_eth_tap.c >>> @@ -62,6 +62,8 @@ >>> #include >>> #include >>> #include >>> +#include >>> +#include >>>=20 >>=20 >> Regards, >> Keith Regards, Keith