From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB60B42C96; Mon, 12 Jun 2023 11:48:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB31940689; Mon, 12 Jun 2023 11:48:57 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 5A87C4014F for ; Mon, 12 Jun 2023 11:48:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686563335; x=1718099335; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=nN4SOIl+YJBpdII/UW//ph4griLOa+aOsBspdfhdk3E=; b=XvRyO/eOvMI3OhE+7lmAyj0XzI0RyTL7PsWE8I4seOeSFV6f1bqg1KdF TS6Axhx9ZIog/TFNMVAEdOOX+uxwZqaxQPomuVL6Tdjc04vSC3F8hYetB tWlmF4i789hN+BPkk2v9M8V7N9iBhzSlbiGKdmhfYjPC0nwWGUo3syQr5 lEpnJgApUPlCnEmWZw/Bz+DaN2jcXUjziDZRtZjdp5VlHkbJwKNqvaKph EazN9SrW2xvkdS3GwSwTp9RRgdJk0Pskxou1BHkcH3bPedUSIl8SnLNRz msp/ijEz77UqWCqdg9lS+R96Stxh0jKVZ7pDU3cWQEztLqgCwrES1hGUe w==; X-IronPort-AV: E=McAfee;i="6600,9927,10738"; a="386379727" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="386379727" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 02:48:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10738"; a="711136004" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="711136004" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 12 Jun 2023 02:48:53 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 12 Jun 2023 02:48:53 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 12 Jun 2023 02:48:53 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 12 Jun 2023 02:48:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B1ZOa27j1pZsgXxm5+Imq3+JEPWDNflLpREw6zgPPxGXKddm98baSphftvkNqJHF3KtRiWDyREBjqRI8f6ISJfbyU+P+KdGazfxkjkJHa1XTU6Nz0LvOVU/Uv4cyowphr9OZ5YfeRSLVSixpM24QtR+2CkzTljbJt/7ZL449lLFAK8pOc6R8vfwLRd4uStSdd4mkigJIx4tBnIJrQoMXpiMvDew4mLeifTjpTZTvZyVuzho2sGt/pcow56fRSbblHr70ZPy/GotWBnEpxrQCdfo3m2k8R0pIyoRs3PJWgj7TMbMPFiacnXGJteqePwr6Cvk9jYXKRvfu4YBiEKyBUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dYa6kpps58RjyD3GrhEtNhPsJxzuM15Ti+Hlx8Nym88=; b=ChhOlWtF8Bpv44xfESeVEWv4+nReADth7U79NleEQUDQZSdEZL+kG+FJkMAG3hmPEXsEsD2mwZ4u6dgBCHSW/a/r7Sxv19NxUzlvLThNXD3Ra/51PW2bogvr8+YQ8WjKJhvCbM0rWP1h7zWsfIpPvYestIn9Iqh6efkXfQwKSmZg+szFEqRhMU8RQfW8fZoZLUxuHVhkDspsQGbDkKjhVqMxq0H1gwIswXJMmuULd57hS33WaQOfO2R90nw4khmMAxTyzHnQVZB/0NzNWt36g+Pia2aOyN9KncoVQ9Xnqi0KtOOUcwzonPGbxs48AMR9AnB4I7UCRV7roqIYK75PQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by CYYPR11MB8329.namprd11.prod.outlook.com (2603:10b6:930:c7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.29; Mon, 12 Jun 2023 09:48:46 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718%7]) with mapi id 15.20.6455.030; Mon, 12 Jun 2023 09:48:46 +0000 Message-ID: <92f02161-eedc-9187-3719-420edf074d80@intel.com> Date: Mon, 12 Jun 2023 10:48:40 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.11.1 Subject: Re: [External] Re: [PATCH v4] eal: fix eal init may failed when too much continuous memsegs under legacy mode Content-Language: en-US To: Fengnan Chang , David Marchand CC: Lin Li , References: <20230529112130.11198-1-changfengnan@bytedance.com> From: "Burakov, Anatoly" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0433.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::13) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|CYYPR11MB8329:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e2b0a4e-0b86-4369-f5f8-08db6b2a3733 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GYBw2+OCAShfNUpRTwtN08ZHK96oKbCKnRvTGKgw8gQn+RYwkMcCfqeJS0hPU2Hx6eqpX14FrjHkv/V2P9wAXWpB2ZrIgkdkWdnRmY0VBqGrj97ieQway+fZx+ZqPxmoD1BX/VnISRgYGPwJ9RffwsWT8C9T9BFFOpTo7iSxRiKNhlWsWJKW/vcBILDdu4MUeHl785J4jUcW+jn0J0IzQ6xfbdaiPgu51nGF3XHCZ7vfxF6+Q9mYP4xKEm0/MzGoHvVh5MCkEBoWhHEbQRTTP/y8LMrz2NkuCOobHKK/EJPayTMq838qihdi0/hU6/zp7PnscFAWysRhk+/DmMyezsw6cKXbFvvmfjaI65m/OM84LcYLVL0ArAXjUlwS0118hg7wT7j2Wi4QYKVZ6agFUAR/ibf1sAyQQGVm34DD//k3TZfg1ZETSg6/qto0OmJRd1tRMwcXFjBTXqsM1WWEocug/E3dLq5ewILnFaHYXkU9lUnDTjW0zeWPTGAaelnYEvm5ChhiL3Hd7xeMl7uuqQ5zTRSfaEm8cv+Xng0YIUikz1winBinSTpQiOjah0kmrYc8lSsv5DZUgkUfN1/+TWXJdTwdHWdySlrEe24Mda9s7moYaT6mylldnAqZu50CWL3uvKzZqmmJseiFfb8DlA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(39860400002)(366004)(376002)(396003)(136003)(451199021)(110136005)(86362001)(83380400001)(31696002)(6512007)(6506007)(53546011)(2616005)(26005)(38100700002)(82960400001)(186003)(478600001)(6666004)(36756003)(6486002)(2906002)(41300700001)(316002)(8936002)(8676002)(66946007)(31686004)(5660300002)(4326008)(66476007)(66556008)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGxFZENSd2lkMEF0VEVoS2hrcmlnTzhrUGp5cVoyemtCUGNiUHk3THpnc0F6?= =?utf-8?B?QkJnYmk0anFJUVhHMWRMWXA0WS9kRmhka1IyeUJndU9FdTY5WGFMYTRhMC9r?= =?utf-8?B?OXR4UEdQTE12eWFnaUd3OUxzOUhIMFB6aVlVbVJpOUlxaEVLWEZYTFZ6SWsr?= =?utf-8?B?ZlJzbGhWZGhudmpvN1B3dm4yNGdPcGdkcEdiWVh6TE5iUURkNExUUUhKS2Fk?= =?utf-8?B?QWFBcjM4NFY3L011RzVQOTF2Uzh0L1lNTjhBSHI0TDZabzVQb3oveTdPT2VN?= =?utf-8?B?cDJteHhSNVVlNDNxb0xIbW12TlBLTkI5RHRTUzdCUmFuOCt3RGdWYjR1VE5I?= =?utf-8?B?TXgwR2Rmc3JWODVKWFBJSDNaeUhMb0hxOTI0VmpwZ0JhaTR4aGN1dlFCMFVm?= =?utf-8?B?ZXc4QkI0aTEzYnBobStMVnBHbjVaZXg3L3hYMjcrY2M0VVhhekowc280SVNS?= =?utf-8?B?WjZMZTN3aWM4K3RjeUs2VWxhdWkzb0U5dXk1Q2N2VlNPM0dsM01NcUEwQkQ5?= =?utf-8?B?dGJYL2hmY1hIV0VubUhyMVY4Q042V2xBcGh0bFJmMmRzaXpLeGxCNDNqeS84?= =?utf-8?B?RDFwalBXdXZuVVRqWkswQVpWQ0tYNU9TKzhYRW1nNHAxOFdaTUg2ajFQc3FM?= =?utf-8?B?OEVlSGlXT0pza0dhRG9naDhSSjdZdlVoQXU4QmdyUzI4VmU1NjJVamNza0pW?= =?utf-8?B?d2xwNGpUckVLL1J6Nk4xVnRlc3JPelNENERqcjFvcXZjSkNGbHZvUEJBNEhu?= =?utf-8?B?dzhMNG9aZjR6SHdKTUIwQVJGaVJhV2R1WXFuaExvczFsUlJ2c3h6UUN1VERy?= =?utf-8?B?WnNPODRYMDRwNUhkeUtjV1RxaWVWeExDWXhRV2pBa1FBbWZYNUI3Z0lyTWoy?= =?utf-8?B?MzRCdytWNnlmZTVoOWhOclR4UEd0UlduUUVjMnRXM0FoSDVhZkNFVmI0UFZ1?= =?utf-8?B?ckJyYlhHdEJBelJ6bmlhY0RLdCtiRXh1cGZFWThaZ1VLSmVTYU5CREkzU0hx?= =?utf-8?B?WU5JUGQ5Q0tBQ3BkemhiWkRkc0VDZHUxOEM5VWJSNDY1MW9pZ1kvL05yd0dy?= =?utf-8?B?SitkRExoOVltNS9yd3pEZVJkaFFnN1gzMkovZzUyV3YwRDNITEJsWjhCVks0?= =?utf-8?B?QmJqcTlmMDBUNUtrblFLNTJFNGdzSEdQU3Aybk9ZOVZNZk9kUlBwLzJ3VzN4?= =?utf-8?B?V2ZyMEdFZGk1NUFzTnZlRTVvMGxhVVlJZDkranZMUVpNaTdONkhzMDFYTVhp?= =?utf-8?B?T3lyWjB2UFlCOGVKbGQxSVpuN1dMWEpaT3JjMmVhRHVzbHF2K2crakc4M2Zx?= =?utf-8?B?U2FoZWl6OUxzMHVjTkYzVGV5Z2F2VmxIQVc4UzBUakRmbnNwZ3Q3cWdQZGNu?= =?utf-8?B?cDExWTJKZUYvSTNaOTYyQnBKYnN0UG1Ea3luSUVzMCtqRHZhbUxOeGJ6WWpG?= =?utf-8?B?cC92LzNDWUNWRUJ5Vkpobk9Va0s2OHUwdkVWdFl2VmgrRGRka2EvRUgyWGJa?= =?utf-8?B?TGdaWUxaVnpNQkZXYkEvQklRTGo2NCtYYVpSNTVlcXRnMWd0c21xcCtrZWFp?= =?utf-8?B?MVFtUmdhckJ4YTFTcFBoQitrWCtsOUpBcFNiaUNyQTVLNmY0Y29Yd21Dd2Zk?= =?utf-8?B?K1BSVStxZWgrcHp1U2haUWdWWVZNZmhIWWpVaXB0SFkyMHB1U2pyWEwxNVpk?= =?utf-8?B?T3NsY0ZpVUNjMTliUFdNREl0c1BZS3FxbXRyTTIxanc5STMydWZFdDFMdnhD?= =?utf-8?B?elhNQi9tbVZlSUVZUGppaTJNTytqWC9ES3ptTTA2NmtMbXlPUkx0M2E4a0l0?= =?utf-8?B?aXJpVlk3RGEwZ3Jpd0xvWTlCb3hUUXMwUVB1ME52NlljTFp1TlAzVWI4Vlo4?= =?utf-8?B?WFNFcXlZdldSREhRMjdzbzVHcitrc0ZWcFF0ZFhoazY0bkNCRkpaVkdRNWNw?= =?utf-8?B?NUdjbGh5NC9PbzRzMGlGVDFxMG1acmRKUy9pVlJTMVUzdDR2ZXgyTzU5cUJ6?= =?utf-8?B?WlhSd2xFbFZRL3doQkkxZmxtR2EwMVMzV0hmUm52b3VyWkdmZEM5K1BnWFhi?= =?utf-8?B?cVI4L1d2SGg1YVAyMFpnNVRPditaTDc4dXhIY3pIMzNyYTFrVTRyNjJzaGdI?= =?utf-8?B?UVAyd1hyL2JuQUZsU1U0eFZpRFk0RG8xdGg1Tmt5R3JGb2s5OGJXazNvckdS?= =?utf-8?B?cHc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3e2b0a4e-0b86-4369-f5f8-08db6b2a3733 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2023 09:48:46.4289 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sMGGoi+8elVfh/KDDK2UCmJ1IgsBFcVhQVjxGCrzmjnAIEDffFHsbly5JALuSHyFph9aV36eYz3PW8qC5r5t/Nq/ftCSSH3HIrGZZV47scA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR11MB8329 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/9/2023 9:35 AM, Fengnan Chang wrote: > David Marchand 于2023年6月8日周四 04:33写道： >> >> On Mon, May 29, 2023 at 1:23 PM Fengnan Chang >> wrote: >>> >>> Under legacy mode, if the number of continuous memsegs greater >>> than RTE_MAX_MEMSEG_PER_LIST, eal init will failed even though >>> another memseg list is empty, because only one memseg list used >>> to check in remap_needed_hugepages. >>> Fix this by make remap_segment return how many segments mapped, >>> remap_segment try to map most contiguous segments it can, if >>> exceed it's capbility, remap_needed_hugepages will continue to >>> map other left pages. >>> >>> For example: >>> hugepage configure: >>> cat /sys/devices/system/node/node*/hugepages/hugepages-2048kB/nr_hugepages >>> 10241 >>> 10239 >>> >>> startup log: >>> EAL: Detected memory type: socket_id:0 hugepage_sz:2097152 >>> EAL: Detected memory type: socket_id:1 hugepage_sz:2097152 >>> EAL: Creating 4 segment lists: n_segs:8192 socket_id:0 hugepage_sz:2097152 >>> EAL: Creating 4 segment lists: n_segs:8192 socket_id:1 hugepage_sz:2097152 >>> EAL: Requesting 13370 pages of size 2MB from socket 0 >>> EAL: Requesting 7110 pages of size 2MB from socket 1 >>> EAL: Attempting to map 14220M on socket 1 >>> EAL: Allocated 14220M on socket 1 >>> EAL: Attempting to map 26740M on socket 0 >>> EAL: Could not find space for memseg. Please increase 32768 and/or 65536 in >>> configuration. >>> EAL: Couldn't remap hugepage files into memseg lists >>> EAL: FATAL: Cannot init memory >>> EAL: Cannot init memory >> >> We are missing a Fixes: tag and this is backport material, right? > Yes, this patch need cc stable@dpdk.org >> >> >>> >>> Signed-off-by: Fengnan Chang >>> Signed-off-by: Lin Li >> >> Can I update Lin Li existing entry in .mailmap? Or is this a different person? > Please help update in .mailmap, same person, thanks. >> >> >>> Signed-off-by: Burakov Anatoly >> Anatoly Burakov* >> >>> Reviewed-by: Anatoly Burakov >> >> Strange to have both SoB and Review tag from Anatoly. > Maybe just leave SoB ? cc @ Anatoly The signoff is there because I suggested an alternative implementation in comments. I'm OK with just leaving Review :) >> >> >>> --- >>> lib/eal/linux/eal_memory.c | 51 +++++++++++++++++++++++++++----------- >> >> Is this issue affecting only Linux? > Yes，Windows and FreeBSD is fine. >> >> >> >> -- >> David Marchand >> -- Thanks, Anatoly