From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B471543699; Thu, 7 Dec 2023 13:48:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6816A40295; Thu, 7 Dec 2023 13:48:10 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2065.outbound.protection.outlook.com [40.107.244.65]) by mails.dpdk.org (Postfix) with ESMTP id F22AC4025C for ; Thu, 7 Dec 2023 13:48:08 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jnjUjPIUxoPqZ9DjV+nqDVqFXImOxZp6JzB43r0BiOP4Fr7hfr/8f3+CDy7N4U29IYV31NINX9v7isDPs9clZ6jlehSg8hh3y3Tf32TpnYd049+SQrSZJSGUvaOZ70uQSfmcMOE6Q9Dl6u/7MQXdGJjc5YmzSJN36/vwTMkuuwY/5xlPBTQEtVUB8qbZXA1hERquTqSH9Ex9DdZynsACGNAI65x2szB/k92rVUDtz/TIBNDqzU6Ct8t81JkKymk8A2BllXOnH0JHtUQSJUzWeEvZgvjNzlJnwQrJOT9PMxWRTptQjYkZOqTgkRY+jFll7rt8g/+3v6d2vn4ZjucTTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MoJYMKRci+8x1IIhYvOH8GNQHKxw0Jdx+d5tH6j3feM=; b=Rop6fQ6wRilm4tycU6ZlYcK7eNYDfNimZdjwwD64xW81MyTsmVrK1nd0KlFCYIW9yfbO5c/pROnKfCE+lJeRI5rkkIqD8o2vFSd7IWuwvmhUjQ4gj+h9WjwTSLCB1f1Gep49DXRvYJ3PkdL/jSkRel6QHCBKr4Uj0mGLcFOZsztP4pDg2yIUtdH4NoRszisWFDP9NOYayOYmF8/3vWF1HeCwOhBnkd/79Idu2WTVZNF0bGVlp/RMdm2eZJcUBWt4L3qb8mzyz+ggmPZcuCIOTWwtqbfT09J1cg1yqW1FF1WKtmLJQzejhz56hvI6ceLDyTnl97A4Q7lBSAI75KFMgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MoJYMKRci+8x1IIhYvOH8GNQHKxw0Jdx+d5tH6j3feM=; b=mAEnR2Hf3LjzGJBnDyt5o2rmblRvr9YoWVYGjF7TaoFbZWc0um9X03HbpahHSYVs2QZGh+Uy0odOlZyjPVn+8L7DHL9DPrw8JWs/kKa0QgTeWgZtPDLBnjd5RePZfyx92JY02a2ZBy0cknwWCQm+jN1W2ezLy4sB7Fk0qZt1SzQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB5485.namprd12.prod.outlook.com (2603:10b6:a03:305::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.25; Thu, 7 Dec 2023 12:48:05 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7068.025; Thu, 7 Dec 2023 12:48:05 +0000 Message-ID: <92f8434c-bc12-4d51-9675-d1e7a4a025a8@amd.com> Date: Thu, 7 Dec 2023 12:47:59 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] net/hns3: refactor VF mailbox message struct Content-Language: en-US To: Jie Hai , dev@dpdk.org, Yisen Zhuang , "Min Hu (Connor)" , Huisong Li , "Wei Hu (Xavier)" , Hao Chen , Tyler Retzlaff Cc: fengchengwen@huawei.com, liudongdong3@huawei.com, David Marchand , Thomas Monjalon References: <20231108034434.559030-1-haijie1@huawei.com> <20231207013732.3987482-1-haijie1@huawei.com> <20231207013732.3987482-2-haijie1@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231207013732.3987482-2-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR1P264CA0031.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:19f::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB5485:EE_ X-MS-Office365-Filtering-Correlation-Id: 37b4d36c-89a7-46f1-baa0-08dbf722c112 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HEY+7X12BszB23ehK9Kcbvu+9KD+mMxxY4VIsEyjxqQwxNMaNf9JOL0S+9XffAkcrkhWRUDpPgcK0/pehqIdvm+WzTZJqypqHz06Nzs+BNKE0COlAi/rgpNUnwHbl5Xl1oRdZQ/UHlpz87GYFghk0HRMr0VSxCsB6lpV6ZSCsZODACBdtxy8+TY03g7lOuSjmkRhaHijbrnwNLqtKkm04HW1TbZVmtAtY8K89gF7szxLYXOgBmFzGBILcRES6CcAg9ffky61/ypeB0APAT2Dze2UbJPXr1sW77M64vfpessAv0eGd8wYeGcUToXLtTVzhi4YCpnupDpfDeK9z8OA0CE8XB1idm0qiTmWhSSQZZMLvyANMye0uAttICUkWNK9m/PubHyfjhDe1dubX+iX8RZL6y/vuJxsmoMreYcUDiB7EPTZaN2yoQUf6f88AtH2E8rdPpzxP/G8TXqbs09M7ELzwp01UmWysDGkMQGurtQKolyjy34L22CCD47NJm8OwHwVqknr79nLBQwAjXfzOjxc66TV32mtelC2YfrUxYzA0hN+46EZq3tIXTQgrlPXfm6+JN2FgE2a8mfWUuitzKgFN2hbovywSun4Xnedb8HOi8JbaEWEcM8Ljjg+G2XJOlpmUbCwoBsTJlEJ0nnXyA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(366004)(39860400002)(346002)(136003)(396003)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(41300700001)(83380400001)(2616005)(5660300002)(86362001)(7416002)(15650500001)(2906002)(6506007)(31696002)(26005)(44832011)(31686004)(6512007)(8676002)(4326008)(8936002)(53546011)(6666004)(66556008)(38100700002)(66476007)(478600001)(110136005)(316002)(36756003)(54906003)(66946007)(6486002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VTNTSkFnRmFsd3VXQ21XdjZIejlQMmY4RC9ieDJYUlFHRU9kSGRIcjFHdEJH?= =?utf-8?B?eW1TcjFTbUcrWU1RdWpjY0dCS3JoTk05dEpqS0w1RWpLSDlpZ0U3dllSWnJG?= =?utf-8?B?bzFXNDBJN2ExSTVyL0svU29LckpsSHZIUDhtbzRuaFZxZSsrUmNqYWszZnln?= =?utf-8?B?RjZueFFMQW50NmowZlhHZVo4U1VTMG9DNDRxUDZmeGdGckVOaTVELzVUNmtI?= =?utf-8?B?VTk1aExZNXlZbHhTWWZlMjR4UHFIMGNsRVBkd0Z5NS80SlFHUTBkYkQ2cnpD?= =?utf-8?B?d0xsdjEvc2c3eHdGeXhSZUxLY0JUOTBLbEt4SVBuVk5pekQvdm1hTy9FdFNI?= =?utf-8?B?a2V2OHJLMUNMajVScTJXcFlFT3pqSitQNkMrL2FRV2xOTkMvbFpiWkRrNGUw?= =?utf-8?B?Sk0vUUtnWkwvREUwT2xtVUk1R2dEWG9xalRiZUtCdm1GNVprQ1dEUWt1ek9j?= =?utf-8?B?c1dOL1ZPVStsZWd2eXNpd1JiRU1rekw5cVYxazA0cjFsbXlZaWJINjZkWGFh?= =?utf-8?B?YkZ3NXhXQjAxQUhJWDM0eUFDMmlwRGNCYk1QdmRDUXU2cENnc0IzakFGV3pD?= =?utf-8?B?d254R1RvOVdlVkM1dFQvZ3VjN2hrNXdNSVNORjZqZG5OTlkxdjdUYm4xZjIx?= =?utf-8?B?Y3lGdUdMb1RJd1h3by9HNVpGSkphenNOUkpHZU9WdE95a0Y1cmlGdENDbFdv?= =?utf-8?B?aWJJZnFwdGorT095eG1mR21qVVczMW1YWHJvWlFiMDFoMmYxZXVTSHlWNlBi?= =?utf-8?B?NmFsUTllWHZ6eEZCcm5XTHAzNHdEOGxQRnpveVZ1NVFoM1M1dWdXalpQcksz?= =?utf-8?B?MEJCSkhnNkNKZ0VtSmt5Z08zUng5b3NNUkdyYVhkYkZBaWRrMjZ1SUQ3czh3?= =?utf-8?B?T1hxYW1aU0VmTTNCL0dGRy9FbEhjTXNGRTNBSC94VWRVZmI4MEZVbmgrV0Va?= =?utf-8?B?QnVDbHhlaEFabks0SlFoOUVpMWovUDg1bXphR3FSdHdvdXJpK2RSbEFVdlYx?= =?utf-8?B?WHFrTndwWW5paDZTUkY4TjQ2elpyellvajFOTDBRTlNGcFVaWVlualgvUmd4?= =?utf-8?B?bzJlNzZjTlFUZEQ5TnVjN3NUQ1p3SWV4cXRWMm9jbFgvcXYySDlOODYxUmJX?= =?utf-8?B?TU5HZ2JnUjFPYitPdXBJbjJXUGx5WG9xTy9zRTQxM0NyUGYzTFBlc0FCbmVs?= =?utf-8?B?Umd3V2lMbjV0K2NmTURhSnFJWFJZNkhDL20xVmJDcVRuaC9ZT1JrZ0NoYnJM?= =?utf-8?B?NFNhay9iVExyN1FBcEhtOUFiaXhZQzB0c3NLMXU4eUYxd3JFcVdDVWVRcXdC?= =?utf-8?B?N25LUDBJQjRlcXAwK0MwYW8rTEtRVUhYQnpnNzhPRXk5TTRaNWRiRG1wWUFq?= =?utf-8?B?NFhtbnBWU3dHbjBDKzV2UzJpL3NoOEYzOEFyeWljc2FWTDJ6RUQ0ZDQ4RkVv?= =?utf-8?B?a0VoTHhESWJaYk5xU05uVkpScWgrWWZvNTZyMGk4aERxT2QyS29JTTd2NGZk?= =?utf-8?B?bVJtQ01uZ01iSURsUStHVDYrUkFIbURqV3lZNG9ReThOWWRoRkV3STV0TVRn?= =?utf-8?B?T083VTFOV09MSm5nOXNaR2tNUUxmWDFZU0lFU3pybVJibGd5OFduZEdjR29C?= =?utf-8?B?TVFRQks4NGRodGtueGRVT2ZUYlMrRi9wOWFGMWR1Mm1yaC9ocXV6TjRkOEpp?= =?utf-8?B?T1hZOHhqeXZGVEtFbDFhcHN5V0JLU1RtMnVSZnVIbHVITnk5WkZwRjZaU2xS?= =?utf-8?B?NEgzR2JGRi8zV1Q2d0Z5aHhwbmZBYlRCS1FLREU3eUwzdVQwUWJydTRJNlFI?= =?utf-8?B?UEx2aDZKR2JpOTJROW9QOEJpbW5sYTNvQmdCY3F2SEhNQW5HVDMrNCt5bzVC?= =?utf-8?B?ZTlTWnB2NDgxdUhpQ3h4Q2JvMU9jTS8rZ2w4eVhTeTR0dGp6cWxlcisrazRz?= =?utf-8?B?R21IRnZzdUFqM3lxZU50SjRERHZUTEZ1L3Y0YW1rMGYzNHF3U2VOQTBUTW8x?= =?utf-8?B?MzlxL3orQkRRRk45U3p5bi91MlNTcHNJZ3JyZ09vQXkrU1lPc296UE5BY2l0?= =?utf-8?B?bmtsc1hUSk5zbkhtWVlQeVNWY3NETEVPRFJxVFhrM3ZkTDJ0K2d1UHNTV2hK?= =?utf-8?Q?5uPHr7YSO/rmHvKu2b0gn+wlK?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37b4d36c-89a7-46f1-baa0-08dbf722c112 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 12:48:05.1183 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JC3kBgYd10D5rSMPgMwKOPvSgEQszEVn54BFLhLxhchz1Q7auLjmE3S0waavX7Se X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5485 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/7/2023 1:37 AM, Jie Hai wrote: > From: Dengdui Huang > > The data region in VF to PF mbx message command is > used to communicate with PF driver. And this data > region exists as an array. As a result, some complicated > feature commands, like setting promisc mode, map/unmap > ring vector and setting VLAN id, have to use magic number > to set them. This isn't good for maintenance of driver. > So this patch refactors these messages by extracting an > hns3_vf_to_pf_msg structure. > > In addition, the PF link change event message is reported > by the firmware and is reported in hns3_mbx_vf_to_pf_cmd > format, it also needs to be modified. > > Fixes: 463e748964f5 ("net/hns3: support mailbox") > Cc: stable@dpdk.org > > Signed-off-by: Dengdui Huang > Signed-off-by: Jie Hai <...> > @@ -107,6 +106,48 @@ struct hns3_mbx_resp_status { > uint8_t additional_info[HNS3_MBX_MAX_RESP_DATA_SIZE]; > }; > > +struct hns3_ring_chain_param { > + uint8_t ring_type; > + uint8_t tqp_index; > + uint8_t int_gl_index; > +}; > + > +#pragma pack(1) > +struct hns3_mbx_vlan_filter { > + uint8_t is_kill; > + uint16_t vlan_id; > + uint16_t proto; > +}; > +#pragma pack() > + > Please prefer '__rte_packed' instead of "#pragma pack()", as it is more consisted way for same purpose. But I see multiple instances of "#pragma pack()" already exists. @Tyler, as for as I understand '__attribute__((__packed__))' (__rte_packed) is GCC way and "#pragma pack()" is Windows way. Is __rte_packed causing problem with latest windows compilers? And should we have an abstract __rte_packed that works for both windows compiler and gcc?