From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 040CA1B82F for ; Thu, 10 Jan 2019 18:48:28 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 46A46C0587F9; Thu, 10 Jan 2019 17:48:28 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-163.ams2.redhat.com [10.36.117.163]) by smtp.corp.redhat.com (Postfix) with ESMTP id 678E14148; Thu, 10 Jan 2019 17:48:26 +0000 (UTC) To: Haiyue Wang , dev@dpdk.org, qi.z.zhang@intel.com References: <1547122051-26931-1-git-send-email-haiyue.wang@intel.com> From: Kevin Traynor Organization: Red Hat Message-ID: <92f8ceb0-171d-f122-ad16-35eba3e9f979@redhat.com> Date: Thu, 10 Jan 2019 17:48:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <1547122051-26931-1-git-send-email-haiyue.wang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 10 Jan 2019 17:48:28 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v1] net/i40e: perform basic validation on the VF messages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 17:48:29 -0000 On 01/10/2019 12:07 PM, Haiyue Wang wrote: > Do the VF message basic validation such as OPCODE message length check, > some special OPCODE message format check, to protect the i40e PMD from > malicious VF message attack. > > Fixes: 4861cde46116 ("i40e: new poll mode driver") > Missing Cc: stable@dpdk.org ? or there is some reason not to backport? > Signed-off-by: Haiyue Wang > --- > drivers/net/i40e/i40e_pf.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c > index 092e0d3..d6e83e3 100644 > --- a/drivers/net/i40e/i40e_pf.c > +++ b/drivers/net/i40e/i40e_pf.c > @@ -1295,6 +1295,7 @@ > uint16_t vf_id = abs_vf_id - hw->func_caps.vf_base_id; > struct rte_pmd_i40e_mb_event_param ret_param; > bool b_op = TRUE; > + int ret; > > if (vf_id > pf->vf_num - 1 || !pf->vfs) { > PMD_DRV_LOG(ERR, "invalid argument"); > @@ -1309,6 +1310,30 @@ > return; > } > > + /* perform basic checks on the msg */ > + ret = virtchnl_vc_validate_vf_msg(&vf->version, opcode, msg, msglen); > + > + /* perform additional checks specific to this driver */ > + if (opcode == VIRTCHNL_OP_CONFIG_RSS_KEY) { > + struct virtchnl_rss_key *vrk = (struct virtchnl_rss_key *)msg; > + > + if (vrk->key_len != ((I40E_PFQF_HKEY_MAX_INDEX + 1) * 4)) > + ret = VIRTCHNL_ERR_PARAM; > + } else if (opcode == VIRTCHNL_OP_CONFIG_RSS_LUT) { > + struct virtchnl_rss_lut *vrl = (struct virtchnl_rss_lut *)msg; > + > + if (vrl->lut_entries != ((I40E_VFQF_HLUT1_MAX_INDEX + 1) * 4)) > + ret = VIRTCHNL_ERR_PARAM; > + } > + > + if (ret) { > + PMD_DRV_LOG(ERR, "Invalid message from VF %u, opcode %u, len %u", > + vf_id, opcode, msglen); > + i40e_pf_host_send_msg_to_vf(vf, opcode, > + I40E_ERR_PARAM, NULL, 0); > + return; > + } > + > /** > * initialise structure to send to user application > * will return response from user in retval field >