From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id CE3677CD2 for ; Mon, 4 Sep 2017 11:47:14 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2017 02:47:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,474,1498546800"; d="scan'208";a="125364169" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by orsmga004.jf.intel.com with ESMTP; 04 Sep 2017 02:47:12 -0700 To: Stephen Hemminger , Nirmoy Das Cc: dev@dpdk.org References: <20170829150613.10597-1-ndas@suse.de> <20170829081252.562f9313@xeon-e3> From: Ferruh Yigit Message-ID: <92fdedff-cded-1ca9-0ea7-c2e8ae7a3752@intel.com> Date: Mon, 4 Sep 2017 10:47:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170829081252.562f9313@xeon-e3> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] kni: fix build on SLE12 SP3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 09:47:15 -0000 On 8/29/2017 4:12 PM, Stephen Hemminger wrote: > On Tue, 29 Aug 2017 17:06:13 +0200 > Nirmoy Das wrote: > >> compilation error: >> build/lib/librte_eal/linuxapp/kni/kni_net.c:215:5: error: >> ‘struct net_device’ has no member named ‘trans_start’ >> dev->trans_start = jiffies; >> >> Signed-off-by: Nirmoy Das <...> > Sigh. KNI needs to get upstream, or we need to leave RHEL and SLES > version magic to the distros to manage as their own patches. > > This kind of spaghetti of ifdef's is unmanageable, untestable, and > just plain ugly. I agree with above comment, meanwhile I believe we need to support this as long as maintained in DPDK.