From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 8F2E5A0562;
	Mon,  3 May 2021 16:28:06 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1721C40150;
	Mon,  3 May 2021 16:28:06 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mails.dpdk.org (Postfix) with ESMTP id CF0AD4014E
 for <dev@dpdk.org>; Mon,  3 May 2021 16:28:04 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1620052084;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=wyBCsPQQyazgFcaEjJ6bWN8eGl780lB6ckaEddZrj88=;
 b=hM4f7OqYTTcqnoL9x8or6qyLrkkXpngztphSmlZGUwITvomlXV7AbdzaOpYEusTES37XSl
 rMiD3iyyJFZUPdtaAK2eEJijUBvpfLQGJ4aH8nXsAAM3wweTghVQPBIXacw21pYb2lXY8R
 hoymfNF2DFvxITnM7fXyi9w4xqs5CE0=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-38-OT-Sq-wqPdavTwX7D8f3RA-1; Mon, 03 May 2021 10:28:02 -0400
X-MC-Unique: OT-Sq-wqPdavTwX7D8f3RA-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1D8BC801106;
 Mon,  3 May 2021 14:28:01 +0000 (UTC)
Received: from [10.36.110.22] (unknown [10.36.110.22])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id AC9F66061F;
 Mon,  3 May 2021 14:27:59 +0000 (UTC)
To: Matan Azrad <matan@nvidia.com>, dev@dpdk.org
Cc: thomas@monjalon.net, chenbo.xia@intel.com, Xueming Li <xuemingl@nvidia.com>
References: <1616058798-303292-1-git-send-email-matan@nvidia.com>
 <20210502104510.3102095-1-matan@nvidia.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <933598d5-3933-6491-e763-0632f6a45a8e@redhat.com>
Date: Mon, 3 May 2021 16:27:58 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210502104510.3102095-1-matan@nvidia.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
Authentication-Results: relay.mimecast.com;
 auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] vdpa/mlx5: improve interrupt management
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 5/2/21 12:45 PM, Matan Azrad wrote:
> The driver should notify the guest for each traffic burst detected by CQ
> polling.
> 
> The CQ polling trigger is defined by `event_mode` device argument,
> either by busy polling on all the CQs or by blocked call to HW
> completion event using DevX channel.
> 
> Also, the polling event modes can move to blocked call when the
> traffic rate is low.
> 
> The current blocked call uses the EAL interrupt API suffering a lot
> of overhead in the API management and serve all the drivers and
> libraries using only single thread.
> 
> Use blocking FD of the DevX channel in order to do blocked call
> directly by the DevX channel FD mechanism.
> 
> Signed-off-by: Matan Azrad <matan@nvidia.com>
> Acked-by: Xueming Li <xuemingl@nvidia.com>
> ---
>  doc/guides/vdpadevs/mlx5.rst        |   8 +-
>  drivers/vdpa/mlx5/mlx5_vdpa.c       |   8 +-
>  drivers/vdpa/mlx5/mlx5_vdpa.h       |   8 +-
>  drivers/vdpa/mlx5/mlx5_vdpa_event.c | 304 +++++++++++-----------------
>  4 files changed, 130 insertions(+), 198 deletions(-)
> 
> v2:
> Rebased on top of latest updates by Thomas.
> 
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime