From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39F754237C; Thu, 12 Jan 2023 00:20:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 23DCB40E25; Thu, 12 Jan 2023 00:20:37 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 7E71940A7D for ; Thu, 12 Jan 2023 00:20:34 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id F3CD05C0132; Wed, 11 Jan 2023 18:20:32 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 11 Jan 2023 18:20:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1673479232; x= 1673565632; bh=nzZcW134hN3NHWRGpP4Gf9d8Ph6NBNdFdSe7ODKqS9M=; b=P oWdA+FoRfdYCqf327bcYx9ATWMaBukj8W6mL5icmWqKbfkR0YuuhaIdr1MUsUygp dbLbBf3Mb0QpzILgBbQ6wnGeTuYmpAsLm6OjGMHD4Sj+ggBYxAyBxDkExK3I1M69 RO4MDQe16id5deai1ffh6lRAHgXKppxODt7W8NLTyNt2GMa4wtiNY9NGdV43AacF Myf+/aTlBNbxUzDN9TeO41OUQ3gLmExjGTr7Ig7R8x5esUk0UDSK+LqnCW4P2f5w LVs9MT03hJNDFSfT5T9jcQAYbQv2HxurDgd4qldtLGz8c/VFlAtmnK25NNCegkQB PyD0F8Wt3MNQqeP04gTCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1673479232; x= 1673565632; bh=nzZcW134hN3NHWRGpP4Gf9d8Ph6NBNdFdSe7ODKqS9M=; b=e GC26m+yCzs4C5nR76ZI/afdxO9LTYmyo9ktPgjy3AwNPhRWbhyRobWHoGd+SPr1l /VeLMMzyHhBPXpp8sMg9wffF/EL8KFSArG3vfdzXgUWhxHOUe4f1Icp/983kxpr2 FpMUiLdOKT1S4m1Vis/+s9/PRjI348QcWvXK/3yKkxe9KZdFkVwTYyMTWvQEjd3l Nukt8jl6K+/28KaQcoEY2mjnjWWoMCxQTwXrHoWs4mKYEJqpRPyoglZEDqYESF3n OiksJonNnamOoAlUrlFZpzpKb0KI2PWBDlyiLI9oyjMYdnpHdyKXEAJw4EAm9U2c MTLsm3j1+2zNmvBDhMQ+A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrleehgddutdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 11 Jan 2023 18:20:31 -0500 (EST) From: Thomas Monjalon To: Kai Ji , "pablo.de.lara.guarch@intel.com" , Akhil Goyal Cc: dev@dpdk.org, Tyler Retzlaff , dev@dpdk.org, David Marchand , Brian Dooley , Ciara Power , John McNamara Subject: Re: [PATCH] crypto/qat: fix build Date: Thu, 12 Jan 2023 00:20:30 +0100 Message-ID: <9337009.CDJkKcVGEf@thomas> In-Reply-To: <13467772.uLZWGnKmhe@thomas> References: <20221230210728.86920-1-thomas@monjalon.net> <13467772.uLZWGnKmhe@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Waiting for an answer here. The commit log is not supposed to stay like this with questions. 11/01/2023 10:03, Thomas Monjalon: > 04/01/2023 12:56, Akhil Goyal: > > > On Fri, Dec 30, 2022 at 10:07:28PM +0100, Thomas Monjalon wrote: > > > > When trying to compile on a fresh system, I hit this error: > > > > > > > > intel-ipsec-mb.h:333: error: "AES_BLOCK_SIZE" redefined > > > > 333 | #define AES_BLOCK_SIZE IMB_AES_BLOCK_SIZE > > > > In file included from drivers/crypto/qat/qat_sym_session.c:8: > > > > /usr/include/openssl/aes.h:26: previous definition > > > > 26 | # define AES_BLOCK_SIZE 16 > > > > > > > > I don't know why it was not seen before. > > > > Is it because of a change in intel-ipsec-mb.h or in OpenSSL? > > > > > > > > Signed-off-by: Thomas Monjalon > > > > --- > > > > > > owners of intel-ipsec-mb.h should guard against the namespace > > > conflict... > > > > > > Acked-by: Tyler Retzlaff > > > > Applied to dpdk-next-crypto If there is no better fix, we should at least add Cc: stable@dpdk.org assuming it could be reproduced with an older DPDK. > > > > Thanks. > > I'm concerned to have no answer from Pablo and Kai. > It is real design problem. Is there any plan to have a protected namespace?