DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 5/8] sample/vhost:remove ip_hdr structure defination
Date: Wed, 11 Nov 2015 11:05:01 +0100	[thread overview]
Message-ID: <9350583.vPnT7bVTb2@xps13> (raw)
In-Reply-To: <20151111083400.GB2326@yliu-dev.sh.intel.com>

2015-11-11 16:34, Yuanhan Liu:
> On Wed, Nov 11, 2015 at 02:40:43PM +0800, Jijiang Liu wrote:
> > Remove the ip_hdr structure defination.
> 
> Even for such simple patch, you need state why. Stating that
> "remove ip_hdr structure defination because we already have
> that in rte_ip.h" will definitely let others to accept your
> patch eaiser.

Yes, thanks Yuanhan.

  reply	other threads:[~2015-11-11 10:06 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11  6:40 [dpdk-dev] [PATCH v4 0/8] add virtio offload support in us-vhost Jijiang Liu
2015-11-11  6:40 ` [dpdk-dev] [PATCH v4 1/8] driver/virtio:add virtual address for virtio net header Jijiang Liu
2015-11-11  6:40 ` [dpdk-dev] [PATCH v4 2/8] driver/virtio:record virtual address of " Jijiang Liu
2015-11-11  6:40 ` [dpdk-dev] [PATCH v4 3/8] virtio/lib:add vhost TX checksum support capabilities Jijiang Liu
2015-11-11  8:26   ` Yuanhan Liu
2015-11-11 17:31     ` Stephen Hemminger
2015-11-12  1:41       ` Yuanhan Liu
2015-11-11  6:40 ` [dpdk-dev] [PATCH v4 4/8] virtio/lib:dequeue vhost TX offload Jijiang Liu
2015-11-11  6:40 ` [dpdk-dev] [PATCH v4 5/8] sample/vhost:remove ip_hdr structure defination Jijiang Liu
2015-11-11  8:34   ` Yuanhan Liu
2015-11-11 10:05     ` Thomas Monjalon [this message]
2015-11-11  6:40 ` [dpdk-dev] [PATCH v4 6/8] examples/vhost:support TX offload in vhost sample Jijiang Liu
2015-11-11  6:40 ` [dpdk-dev] [PATCH v4 7/8] virtio/lib:add virtio guest offload capabilities Jijiang Liu
2015-11-11  8:31   ` Yuanhan Liu
2015-11-11  8:38     ` Liu, Jijiang
2015-11-11  8:44       ` Yuanhan Liu
2015-11-11  8:53         ` Liu, Jijiang
2015-11-11  8:57           ` Xu, Qian Q
2015-11-11 11:10             ` Liu, Jijiang
2015-11-11 10:08           ` Thomas Monjalon
2015-11-11 12:53           ` Yuanhan Liu
2015-11-11  6:40 ` [dpdk-dev] [PATCH v4 8/8] virtio/lib:add guest offload handle Jijiang Liu
2015-11-11  8:23   ` Yuanhan Liu
2015-11-11 10:19     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9350583.vPnT7bVTb2@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).