From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 41B5C8D85 for <dev@dpdk.org>; Wed, 11 Nov 2015 11:06:13 +0100 (CET) Received: by wmec201 with SMTP id c201so39597199wme.1 for <dev@dpdk.org>; Wed, 11 Nov 2015 02:06:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=/Yh4jTdwb/eRPVerLN+BugbpgoagtX3kmwizFzJWNbs=; b=dQbbwpG0jqR7oXn9MjqWJOYwEtQprxPBfmZgCqZ/YXUOZn0ClK51B1cE1A4t4jQzQQ 7+h3F9aDduiS9iJE9zWXqIdQPpIIXM423f3xvBrhYeUtmGQ7VTLGrEWxvgRn2aeHr5+V 6xF+R1uObeVDF5yCjrB5Y1dMgFAev+7nQj8FMS9WWJxgBwCOso1i7KR1P6S91or7v4gj NxNiFXBOM+PpaXEkz/JcEKs4W8p/F4xXD9p3b4J+Tmo/hVR3MokQS/8xvX8N5BrKZvx1 pfin1JsU+qcJSQofHSQvbl+V7eKCqHd0HIn7YcBH/rdvXmfjDrY9aJRfRCGtHLfSk+Jm hfdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=/Yh4jTdwb/eRPVerLN+BugbpgoagtX3kmwizFzJWNbs=; b=KnEwpfKVhAULOTgBC4skgfKnZgTP6Qv0Iu4esT6zCCw3RvBNne0CWbzrrurwS44DIe 5IuhxN31nTc0zm+9ScKjF4k9LcVynvaMG/38jexOxCmZ0Fv49cC/HEGinHfi5CqkKLci 6Nq5nVkX+Eh89PVVOul1jK69CA6TU6sP99SWZ7Jpo/prZtwyoex14oO9LbQsjssaWd6n zh9hXaZ/lBSZCd7rCvQtgVRSZ1c6kNPhnbNfOUu8BYqpD5AYnguBFJaoQSiq6B9EKKdn vKgygMm75FaCDL3MvPSOOm+zoJV16oToCbjmU+2a7FHyGDOhE83mjOIBPBEAIKaXe1Y4 K2ZQ== X-Gm-Message-State: ALoCoQnk2sLDAyUCzYrsH1gq2x6aA6NB01Ei24M4rjYTtLAIeC63X12LP6zj83LZomOVA7M9znpX X-Received: by 10.28.61.213 with SMTP id k204mr21413277wma.5.1447236373066; Wed, 11 Nov 2015 02:06:13 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id y77sm24442146wme.15.2015.11.11.02.06.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Nov 2015 02:06:12 -0800 (PST) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Yuanhan Liu <yuanhan.liu@linux.intel.com> Date: Wed, 11 Nov 2015 11:05:01 +0100 Message-ID: <9350583.vPnT7bVTb2@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151111083400.GB2326@yliu-dev.sh.intel.com> References: <1447224046-1169-1-git-send-email-jijiang.liu@intel.com> <1447224046-1169-6-git-send-email-jijiang.liu@intel.com> <20151111083400.GB2326@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 5/8] sample/vhost:remove ip_hdr structure defination X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 11 Nov 2015 10:06:13 -0000 2015-11-11 16:34, Yuanhan Liu: > On Wed, Nov 11, 2015 at 02:40:43PM +0800, Jijiang Liu wrote: > > Remove the ip_hdr structure defination. > > Even for such simple patch, you need state why. Stating that > "remove ip_hdr structure defination because we already have > that in rte_ip.h" will definitely let others to accept your > patch eaiser. Yes, thanks Yuanhan.