From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5BCAA0C3F; Thu, 15 Apr 2021 14:36:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B2EF161EE4; Thu, 15 Apr 2021 14:36:41 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id B97C6161EAB for ; Thu, 15 Apr 2021 14:36:39 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5D6D25C00A1; Thu, 15 Apr 2021 08:36:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 15 Apr 2021 08:36:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= pOzvM7g8L+t7iMyqsv3b8tugSDjytzX/uzhZbUNpy2A=; b=PGl1x8EJnzg8H1BA SA6ktMK4Mm7VQKfTubB2XGijvynB20QSDwmpNzIzz59lacYbavVV8F0EUVTH6fvc nhyEpgHNAPNWLDU9O6yE7HP2hmX3EbaMqnXjK3oy4jvYtRXzrBCddLXjakpq6iuU pRx6g/H0fjfCxoYHitoJlZpxmLM9KDt0nZb7CXglVNJvBVqy418Tmo29Vs35Np3R f0oOrFMuiYCY3gV21zradRju4QymXfZq29EjNtm3xSESjm66vakDjRD8ffoCtsFC vQ4+9nhV2d22qkf/c0Ti3JXlGiCi7Hn1SKUwuBmmCLMY5s1qtltNoeMDGwGiXy75 tdZaPA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=pOzvM7g8L+t7iMyqsv3b8tugSDjytzX/uzhZbUNpy 2A=; b=tj7aRBEOfC9XSYExJIMMerjnroReIlWlklmGzIf944ra3Rwl/UEqJ9U5t 616psFXYROHa28R9npriTzO288ZfXphbcgdald0ICmSax1NLDi/Oc4Vc2tZS67gK H7AJObLkiiSNeU58wUYuqgPxQhmSXjxtWdP0616l3OIb70GiWblQ8oSV0I9Hr4rx 4wruzv6QC/002UNQAiuUjibmLt2ctGnV+UQh0kshY7Si6el/EctNnrQ3PW6w9B8I c/VzBtSFV9/7nZD71jIaBLGAga0l/wO6uXzBN7CKHvfII9HzrUf/ThAgauDukRz1 hYjKu7L689SNPzlPwMzq2JiHlcsOQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudelfedgheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 79685240057; Thu, 15 Apr 2021 08:36:37 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Lijun Ou , Ray Kinsella , David Marchand , dev@dpdk.org, linuxarm@openeuler.org, Andrew Rybchenko Date: Thu, 15 Apr 2021 14:36:36 +0200 Message-ID: <9356626.RYGqZy0Vls@thomas> In-Reply-To: <41261214-284c-3f66-a5c7-14bbe0df65b0@intel.com> References: <1616670560-62333-1-git-send-email-oulijun@huawei.com> <1618454426-21457-1-git-send-email-oulijun@huawei.com> <41261214-284c-3f66-a5c7-14bbe0df65b0@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH V3] ethdev: add queue state when retrieve queue information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/04/2021 14:33, Ferruh Yigit: > On 4/15/2021 3:40 AM, Lijun Ou wrote: > > Currently, upper-layer application could get queue state only > > through pointers such as dev->data->tx_queue_state[queue_id], > > this is not the recommended way to access it. So this patch > > add get queue state when call rte_eth_rx_queue_info_get and > > rte_eth_tx_queue_info_get API. > > > > Note: After add queue_state field, the 'struct rte_eth_rxq_info' size > > remains 128B, and the 'struct rte_eth_txq_info' size remains 64B, so > > it could be ABI compatible. > > > > Signed-off-by: Chengwen Feng > > Signed-off-by: Lijun Ou > > Looks good to me, but it is causing an ABI error as we already discussed before > as that is false positive. > > > Ray, David, > > Should we add any exception to libabigail.abignore for this? We do not tolerate any ABI warning. If we are sure the ABI change is false positive, it must be suppressed in libabigail.abignore in the same patch.