From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id EA3D31E2B for ; Thu, 7 Dec 2017 01:38:35 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Dec 2017 16:38:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,370,1508828400"; d="scan'208";a="9751976" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.226.140]) ([10.241.226.140]) by FMSMGA003.fm.intel.com with ESMTP; 06 Dec 2017 16:38:34 -0800 To: Rasesh Mody , dev@dpdk.org Cc: Shahed Shaikh , Dept-EngDPDKDev@cavium.com References: <1511555745-13793-1-git-send-email-rasesh.mody@cavium.com> <1511555745-13793-5-git-send-email-rasesh.mody@cavium.com> From: Ferruh Yigit Message-ID: <937c1c7a-b8ff-a9ea-2cfe-34b63127b8a3@intel.com> Date: Wed, 6 Dec 2017 16:38:34 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1511555745-13793-5-git-send-email-rasesh.mody@cavium.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 4/5] app/testpmd: add configuration for udp port tunnel type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 00:38:36 -0000 On 11/24/2017 12:35 PM, Rasesh Mody wrote: > From: Shahed Shaikh > > Replace rx_vxlan_port command with rx_tunnel_udp_port to support both VXLAN > and GENEVE udp ports. Also updates tunnel_filter command to accept "geneve" argument, can you please separate to another patch. And to prevent these patches hold PMD patches, you can send a new version of the patchset splitting qede PMD patches into their own patchset. > > Signed-off-by: Shahed Shaikh > --- > app/test-pmd/cmdline.c | 28 +++++++++++++++++++--------- > 1 file changed, 19 insertions(+), 9 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index f71d963..4b5a8cd 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -402,11 +402,11 @@ static void cmd_help_long_parsed(void *parsed_result, > "imac-tenid|imac|omac-imac-tenid|oip|iip) (tenant_id) (queue_id)\n" > " remove a tunnel filter of a port.\n\n" > > - "rx_vxlan_port add (udp_port) (port_id)\n" > - " Add an UDP port for VXLAN packet filter on a port\n\n" > + "rx_tunnel_udp_port add vxlan|geneve (udp_port) (port_id)\n" Not sure about "rx_tunnel_udp_port" command. What do you think something like: "port config (port_id) udp_tunnel_port add|rm vxlan|geneve (udp_port)" to expand ""port config (port_id) ..." command instead of introducing a new one? <...>