From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9FF15A0548; Fri, 2 Apr 2021 01:18:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1816C40F35; Fri, 2 Apr 2021 01:18:08 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 97B4940150 for ; Fri, 2 Apr 2021 01:18:06 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id C9C465C00A5; Thu, 1 Apr 2021 19:18:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 01 Apr 2021 19:18:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= am1WG1DAelkLxYVtnSBHCEatf8qthDxHJyWjRX4uUzw=; b=3VvJ7JULu1on/AFP gLLpY6d0iHJi6WS/dy6BUCltHneOBHnqCinWUSvNHIJe3fJpIZgez9jprjHzpmnd DUKWj+wjH1tNjoye86/TZ4uSQLQrSu9KoPxVXVuTfuRYO7xgcHtyGDfUp3TDVM6+ +i+aClCeLrQwkeufhHk14acAqpPB5fR3aebVjau1xTlTv+Yp98370FZ+y2ToUxR/ UXdVVQuE/MxJkVVlHRxSNnVSkKSy9sSOhLkReVINzxnWrtX9utfscmjnqVYgZog5 rGnckDxLN8Dregy1Xu6IpmSMhoGDxYkn4/lI8tGniz7Hw6uJare+J8ZBROLzVQCS D3ocUA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=am1WG1DAelkLxYVtnSBHCEatf8qthDxHJyWjRX4uU zw=; b=E/XqcE+G0MyA+UVrhXuL0yXnx3EwL471tI1/jXCHc1+YbR+bpTcQTmYL9 maxjJEz5TuSxWxeiyK7DEHOdCLe0LjRrmZTVfdqw65UQ9sTdB5aoSHRmZaXCWucP LmWpFoyuD3NpgXkikndxrEO4rqVVLUSE9OEJW68EjOFj2M6wsU4uGCZmdqd2IJAK I/hR0WZeykqmOBiRkOh1cirIN0leEilTEQlTmEV9UwTD46122sH6+DNc+48GNaeh W+LdgBhEQKei4gOk5McGO/Gsf7FE8MSoHpvbbSCA1mbXIghe1ywEhwO0krco7v+9 fKBCq4xG7jIQFcproVLjhNn5kBUSg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeihedgvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu tdejveehveetnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5C02D1080064; Thu, 1 Apr 2021 19:18:02 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: Nick Connolly , Bruce Richardson , Dmitry Malloy , Jie Zhou , Narcisa Ana Maria Vasile , Olivier Matz , Pallavi Kadam , Tyler Retzlaff , dev@dpdk.org Date: Fri, 02 Apr 2021 01:18:00 +0200 Message-ID: <9391928.9Z6O8BZ7lz@thomas> In-Reply-To: <20210402021021.5cfaf1c6@sovereign> References: <20210320112733.13160-1-dmitry.kozliuk@gmail.com> <5131236.apLr1G0U0s@thomas> <20210402021021.5cfaf1c6@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6 3/5] eal: make OS shims internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/04/2021 01:10, Dmitry Kozlyuk: > 2021-03-31 23:55 (UTC+0200), Thomas Monjalon: > > 31/03/2021 23:45, Nick Connolly: > > > > > > > > I don't understand your point. > > > > I am just proposing to allow some apps to explicitly include the sh= im > > > > for their convenience in case they are fully based on DPDK and > > > > understand the risk of conflict with some other code. =20 > > >=20 > > >=20 > > > Agreed - there=E2=80=99s no harm in doing so. > > >=20 > > > My point was simply that for a non-trivial application I suspect it w= ill > > > have limited value due to the sorts of conflicts that are likely to a= rise. =20 > >=20 > > OK yes. > > If we expose this header, we should bring it with a disclaimer. >=20 > Let's now avoid "internal" (rte_os_shim?), but expose it later, if ever: >=20 > 1. The concept of "not so public" API is new, probably a techboard subjec= t. > 2. We may want devtools checks against including it from public headers. Yes it should be well discussed and checked with scripts. =46or now, let's not expose such shim, but as you said, adopt a more descriptive name avoiding "internal" qualifier.