From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8EC0A0C4C; Tue, 5 Oct 2021 16:41:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9593A4133E; Tue, 5 Oct 2021 16:41:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DC524412D2 for ; Tue, 5 Oct 2021 16:41:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633444882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SOatp4IkPiuBiLY4/7zphG0BxiQP1+Z4ec/zQMNqlaw=; b=ckNB0nPCrUDj9X4mz7kvJ72tYiBQnF5SP19CmSse76H/CXZFybtSCOyQ5KDeh/ix+vjleR oHct097MCmJLVzd89UEdNgna1OFOSnyPWVJH1OJzIjGB4nSMyOUxP/HCuVx6THI9XltHD2 LS05GZcZgsSMkgWzRnvLrjTRsqRK4oU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-246-1AE0mqARNaSRFc9yNAuZbw-1; Tue, 05 Oct 2021 10:41:21 -0400 X-MC-Unique: 1AE0mqARNaSRFc9yNAuZbw-1 Received: by mail-wm1-f71.google.com with SMTP id n5-20020a05600c3b8500b0030d78b00850so860285wms.0 for ; Tue, 05 Oct 2021 07:41:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=SOatp4IkPiuBiLY4/7zphG0BxiQP1+Z4ec/zQMNqlaw=; b=cOfazt0KxqVXCvUrfMWB6xL59U9KpYXZXHZkMTOsyGspaFesioUY6IW0no5rN3AJdL tEUY2lB433GDlJ2xvRbhcqGeoRVMHYjO5cVuqtW8mtIAAZQUQHyHuTlACzP7qhU2jwRu 2SIn9vYGSLJeBxZbN6+o20E6qXRwFgNGAPCJJJcxmWXHXvGsC3QTdzWwv0Yx+t8GP6d/ 58aRB8PwberNFGTzgGp3YXihM84bnPYIdkGgzVd5yjeVzFuVCW4uG/WtWAPVKZVY7Yry cCXe+KY2busAAudSRS55ZUfvyjZFA6p1cLlAzftVbYWUXLIeNU0h0wz7hJkjzeWarDYf Ot9g== X-Gm-Message-State: AOAM533q4xDqxxd26sJ/ofWn9lQBPpk1HBgIY7X8uGXqvSuMyoVsSJss cN4DyXAbcSd6lleVVzFfznl0IHfwSN2alifj1G7tkRdL1DlpdRrwF3IzYGIPswhwIcP225/MzxK MDeA= X-Received: by 2002:adf:bc12:: with SMTP id s18mr21167193wrg.328.1633444879460; Tue, 05 Oct 2021 07:41:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJznQUA+p0Gl+8pLFCVrjIylNv9R8g3eUkseCj4AWQviT2SQmifDjESK8mDhaj7jEZFigNPw7Q== X-Received: by 2002:adf:bc12:: with SMTP id s18mr21167156wrg.328.1633444879208; Tue, 05 Oct 2021 07:41:19 -0700 (PDT) Received: from [192.168.0.36] ([78.19.105.235]) by smtp.gmail.com with ESMTPSA id y5sm2487526wma.5.2021.10.05.07.41.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Oct 2021 07:41:18 -0700 (PDT) Message-ID: <93a5ae93-7acf-658a-4413-0e879c65e14d@redhat.com> Date: Tue, 5 Oct 2021 15:41:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 To: Bruce Richardson , dev@dpdk.org Cc: Ciara Power , David Marchand , Anatoly Burakov References: <20210915141030.23514-1-bruce.richardson@intel.com> <20211005135909.726091-1-bruce.richardson@intel.com> <20211005135909.726091-4-bruce.richardson@intel.com> From: Kevin Traynor In-Reply-To: <20211005135909.726091-4-bruce.richardson@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 3/5] telemetry: use unique socket paths for in-memory mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bruce, I started reviewing v5 before v6 was pushed, so these are just comments from v5, On 05/10/2021 14:59, Bruce Richardson wrote: > When DPDK is run using "in-memory" flag, multiple processes can be run > using the same file-prefix and hence the same runtime directory. To > avoid problems with conflicting telemetry unix socket paths, we can > put the pid of the process into the socket name. As with the existing > telemetry socket files, these sockets are removed on normal program > exit. > > Signed-off-by: Bruce Richardson > --- > doc/guides/howto/telemetry.rst | 17 ++++++++++++++++- > lib/eal/freebsd/eal.c | 1 + > lib/eal/linux/eal.c | 1 + > lib/telemetry/telemetry.c | 15 ++++++++++++--- > lib/telemetry/telemetry_internal.h | 3 ++- > 5 files changed, 32 insertions(+), 5 deletions(-) > > diff --git a/doc/guides/howto/telemetry.rst b/doc/guides/howto/telemetry.rst > index 8f4fa1a510..8a61302459 100644 > --- a/doc/guides/howto/telemetry.rst > +++ b/doc/guides/howto/telemetry.rst > @@ -13,12 +13,27 @@ ethdev port list, and eal parameters. > Telemetry Interface > ------------------- > > -The :doc:`../prog_guide/telemetry_lib` opens a socket with path > +For applications run normally, i.e. without the `--in-memory` EAL flag, > +the :doc:`../prog_guide/telemetry_lib` opens a socket with path > */dpdk_telemetry.*. The version represents the > telemetry version, the latest is v2. For example, a client would connect to a > socket with path */var/run/dpdk/\*/dpdk_telemetry.v2* (when the primary process > is run by a root user). > > +For applications run with the `--in-memory` EAL flag, > +the socket file is created with an additional suffix of the process PID. > +This is because multiple independent DPDK processes can be run simultaneously > +using the same runtime directory when *in-memory* mode is used. > +For example, when a user with UID 1000 runs processes with in-memory mode, > +we would find sockets available such as:: > + > + /run/user/1000/dpdk/rte/dpdk_telemetry.v2.1982 > + /run/user/1000/dpdk/rte/dpdk_telemetry.v2.1935 > + It seems an unnecessary step unless there is multiple process. As a suggestion, how about "simplifying" by always adding a check for an active socket with the default name. If it is not found, create it with the default (pre patches) name. If it is found and active, create a new one with process id appended. e.g. First: /run/user/1000/dpdk/rte/dpdk_telemetry.v2 Next: /run/user/1000/dpdk/rte/dpdk_telemetry.v2.1982 /run/user/1000/dpdk/rte/dpdk_telemetry.v2.1935 It means that existing socket can still be used by anything using telemetry. I think it is a nice default to keep as it doesn't require any changes for anything that will connect (e.g. collectd?) The downside is that one will have a different name but it seems an acceptable trade-off to keep compatibility for single process case. WDYT? > +Where `/run/user/` is the runtime directory for the user given by the > +`$XDG_RUNTIME_DIR` environment variable, > +and `rte` is the default DPDK file prefix used for a runtime directory. > + > > Telemetry Initialization > ------------------------ > diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c > index b06a2c1662..ed39d10b4e 100644 > --- a/lib/eal/freebsd/eal.c > +++ b/lib/eal/freebsd/eal.c > @@ -952,6 +952,7 @@ rte_eal_init(int argc, char **argv) > if (tlog < 0) > tlog = RTE_LOGTYPE_EAL; > if (rte_telemetry_init(rte_eal_get_runtime_dir(), > + internal_conf->in_memory | internal_conf->no_shconf, > rte_version(), > &internal_conf->ctrl_cpuset, rte_log, tlog) != 0) > return -1; > diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c > index 0d0fc66668..9db4eb7913 100644 > --- a/lib/eal/linux/eal.c > +++ b/lib/eal/linux/eal.c > @@ -1326,6 +1326,7 @@ rte_eal_init(int argc, char **argv) > if (tlog < 0) > tlog = RTE_LOGTYPE_EAL; > if (rte_telemetry_init(rte_eal_get_runtime_dir(), > + internal_conf->in_memory | internal_conf->no_shconf, should be logical OR > rte_version(), > &internal_conf->ctrl_cpuset, rte_log, tlog) != 0) > return -1; > diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c > index bd804a25a9..24441d100b 100644 > --- a/lib/telemetry/telemetry.c > +++ b/lib/telemetry/telemetry.c > @@ -51,6 +51,7 @@ static struct socket v1_socket; /* socket for v1 telemetry */ > > static const char *telemetry_version; /* save rte_version */ > static const char *socket_dir; /* runtime directory */ > +static bool socket_uses_pid; /* for in-memory mode, we need different socket paths */ > static rte_cpuset_t *thread_cpuset; > static rte_log_fn rte_log_ptr; > static uint32_t logtype; > @@ -432,8 +433,14 @@ static inline char * > get_socket_path(const char *runtime_dir, const int version) > { > static char path[PATH_MAX]; > - snprintf(path, sizeof(path), "%s/dpdk_telemetry.v%d", > - strlen(runtime_dir) ? runtime_dir : "/tmp", version); > + if (!socket_uses_pid) > + snprintf(path, sizeof(path), "%s/dpdk_telemetry.v%d", > + strlen(runtime_dir) ? runtime_dir : "/tmp", version); > + else > + snprintf(path, sizeof(path), "%s/dpdk_telemetry.v%d.%u", > + strlen(runtime_dir) ? runtime_dir : "/tmp", > + version, > + (unsigned int)getpid()); > return path; > } > > @@ -591,11 +598,13 @@ telemetry_v2_init(void) > #endif /* !RTE_EXEC_ENV_WINDOWS */ > > int32_t > -rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset, > +rte_telemetry_init(const char *runtime_dir, bool in_memory, > + const char *rte_version, rte_cpuset_t *cpuset, > rte_log_fn log_fn, uint32_t registered_logtype) > { > telemetry_version = rte_version; > socket_dir = runtime_dir; > + socket_uses_pid = in_memory; /* for in-memory mode use pid in sock path for uniqueness */ > thread_cpuset = cpuset; > rte_log_ptr = log_fn; > logtype = registered_logtype; > diff --git a/lib/telemetry/telemetry_internal.h b/lib/telemetry/telemetry_internal.h > index d085c492dc..d8fb37a633 100644 > --- a/lib/telemetry/telemetry_internal.h > +++ b/lib/telemetry/telemetry_internal.h > @@ -109,7 +109,8 @@ typedef int (*rte_log_fn)(uint32_t level, uint32_t logtype, const char *format, > */ > __rte_internal > int > -rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset, > +rte_telemetry_init(const char *runtime_dir, bool in_memory, > + const char *rte_version, rte_cpuset_t *cpuset, > rte_log_fn log_fn, uint32_t registered_logtype); > > #endif >