From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <anatoly.burakov@intel.com> Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E787B8D28 for <dev@dpdk.org>; Thu, 19 Apr 2018 16:57:46 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2018 07:57:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,469,1517904000"; d="scan'208";a="52044645" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.128]) ([10.237.220.128]) by orsmga002.jf.intel.com with ESMTP; 19 Apr 2018 07:57:44 -0700 To: Arnon Warshavsky <arnon@qwilt.com> Cc: Thomas Monjalon <thomas@monjalon.net>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Doherty, Declan" <declan.doherty@intel.com>, jerin.jacob@caviumnetworks.com, Bruce Richardson <bruce.richardson@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, dev@dpdk.org References: <1524117669-25729-1-git-send-email-arnon@qwilt.com> <1524117669-25729-11-git-send-email-arnon@qwilt.com> <d162912b-d8b8-8f6e-ab92-27d205f51baa@intel.com> <CAKy9EB3Zzp0wogQpESYC3xnzcSf7PNpyR-Fvr9vSACeAs0DTtA@mail.gmail.com> From: "Burakov, Anatoly" <anatoly.burakov@intel.com> Message-ID: <93afdd1b-b108-9986-5fbe-7d3aacc92ca3@intel.com> Date: Thu, 19 Apr 2018 15:57:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <CAKy9EB3Zzp0wogQpESYC3xnzcSf7PNpyR-Fvr9vSACeAs0DTtA@mail.gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 10/11] eal: replace rte_panic instances in init sequence X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 19 Apr 2018 14:57:47 -0000 On 19-Apr-18 3:48 PM, Arnon Warshavsky wrote: > Copy on the commit message and volatile. > > Regarding the new function defunct_and_remain_in_endless_loop () > I don't think I can put that in a separate patch without breaking the > current patch independence. How so? Just leave some panic instances in there for thread-related stuff and fix them up in the next patch. Also, i'm not sure sending threads into an infinite loop on panic is such a good idea. You might want to look at Olivier's approach [1] to creating threads, using pthread_barriers and pthread_kill/cancel. This does warrant a separate patch now :) -- Thanks, Anatoly