From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 5C724A04B4;
Wed, 26 Aug 2020 14:09:32 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id C83FB58C4;
Wed, 26 Aug 2020 14:09:31 +0200 (CEST)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com
(mail-eopbgr60076.outbound.protection.outlook.com [40.107.6.76])
by dpdk.org (Postfix) with ESMTP id 095432AB;
Wed, 26 Aug 2020 14:09:31 +0200 (CEST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=C3D8Ywo4LyPKDYq7SEUZ/cZTYs2TXc/qXNqRYbflOcdpU1yFWLsj1LahNdQZgDqEBFfU3OOxZUwvmNXHz2ieoxQh2o7iXleNnZcSJMMQQXuOGRCJBPMyUBL+99dFjkwCv1vg/qEaJkNBO3jdkzPLc3N1cOTaThuxJEUD1tUz1xH1M3suIwbCmiHe7hRMWs3fk2ltkzUvyi3Wc0F8LpbdBd43vsGi5EWDep25HOc1EjpwX8OvqVI0teGdhEs7TcYK4pvIk6CvMgxi/lMXWlXefQ6XHd/lPtaJF4BnAwYC3ahapMFRCrI+anFqvfJLNLM0q85yE8uEBpuk5BeY302vXw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=5seg+omSRlQ9pjQeruUcp01W7Si/g1Yu/FRunHpAURU=;
b=FD+sJFiYLV7HP4X6IVritMcu5xPrsywgBT/P5KsEOM/7XpxKj0az8Nh9nbUwGgbRh2jmf8YocFLad3OlyPf1Mmm4iP/B+Go+BGyKhg6WOKRJUSIRarxINF6oHzSkwowW5IODiw4itbr9T2kN4j+tVHTYj89fOX9KRAwd15ufTsauwYkx3cSj1NEDo+0o0vFR+aBXvvRstyLd3bvC1hfzopAdN+p8IM8s14zD+ORWQh9ePmxKPfX7YBHB+NTjafyKiBE22Eja9jv17ZlFyF4axcc4j5V68EaZQKZGtKfN97P/EVKys36axpFZRB5HeY5eD0fRQVad6mGREJYah6+Wrg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;
dkim=pass header.d=oss.nxp.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;
s=selector2-NXP1-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=5seg+omSRlQ9pjQeruUcp01W7Si/g1Yu/FRunHpAURU=;
b=FKrY+QmILt8OqjQS87uvv1pfZoJ2tfkCPzD1a2ppaCD0YR+bbM3FSLMwCC5xYrVvYRhWxmc6ZglCZRjU7phRyjBwZVtiXOIRxBSFy1iL00xOVYngUA3EvtSQkwzJqqUM51QESg8YtNtjgbLAQiCNyB89R7AByUR6tIBdJxHS/cE=
Authentication-Results: dpdk.org; dkim=none (message not signed)
header.d=none;dpdk.org; dmarc=none action=none header.from=oss.nxp.com;
Received: from VI1PR04MB5837.eurprd04.prod.outlook.com (2603:10a6:803:ec::28)
by VI1PR0402MB2719.eurprd04.prod.outlook.com (2603:10a6:800:b0::21)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.26; Wed, 26 Aug
2020 12:09:29 +0000
Received: from VI1PR04MB5837.eurprd04.prod.outlook.com
([fe80::c506:dc43:37b2:7d52]) by VI1PR04MB5837.eurprd04.prod.outlook.com
([fe80::c506:dc43:37b2:7d52%6]) with mapi id 15.20.3305.031; Wed, 26 Aug 2020
12:09:29 +0000
To: wangyunjian <wangyunjian@huawei.com>, dev@dpdk.org,
hemant.agrawal@nxp.com, sachin.saxena@nxp.com
Cc: jerry.lilijun@huawei.com, xudingke@huawei.com, stable@dpdk.org
References: <a592a45a42ab9aac815652cc2ec909c1ac1ea9a0.1598420841.git.wangyunjian@huawei.com>
From: "Sachin Saxena (OSS)" <sachin.saxena@oss.nxp.com>
Message-ID: <93b330ef-5649-0583-5cd2-cd9ab2c9dcae@oss.nxp.com>
Date: Wed, 26 Aug 2020 17:38:53 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
Thunderbird/68.11.0
In-Reply-To: <a592a45a42ab9aac815652cc2ec909c1ac1ea9a0.1598420841.git.wangyunjian@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-ClientProxiedBy: SG2PR03CA0133.apcprd03.prod.outlook.com (2603:1096:4:c8::6)
To VI1PR04MB5837.eurprd04.prod.outlook.com
(2603:10a6:803:ec::28)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.1.10] (106.215.58.204) by
SG2PR03CA0133.apcprd03.prod.outlook.com (2603:1096:4:c8::6) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.3348.5 via Frontend Transport; Wed, 26 Aug 2020 12:09:26 +0000
X-Originating-IP: [106.215.58.204]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 9dcf8f12-2796-4a21-60b9-08d849b8e1e8
X-MS-TrafficTypeDiagnostic: VI1PR0402MB2719:
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR0402MB27198242D52DFE4DDD2BBB14A2540@VI1PR0402MB2719.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: kzK7hvNOxA0lut8AOO0oHXlFGKCJ9jm8OzhBfOS/mCO1mjfXtqtvZFEEdmSqYqiaYGsww/G5bSNVqTEBlcybGXR6Aa0DRe4HW6/Ka+7OuGBiO0iwtL3nxS1Olb2L5AmhUaabJzfTZzXenuxPqrXwYu2o5J3Qzx43dlBRZ6vbjxK9PryOhNpq7H0orfL42mmZv0wnq1tewqWKC+MdzLZU9kmQ0B3noSkj2nAVX17Bm6xoebtYzPxsRtSVs11Qd719l1jYQnhPy5rQ542DeUp1nSnb3SnoETM2SDacP01P7lCGW6OBcG+MxAmeyi2fmYIOElLalDO6moCxVyzY2xeDdNyQPKVSGe+unMmL1E9NomrMXpvmVli6E3IF2o9YV1ZG
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:VI1PR04MB5837.eurprd04.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(136003)(376002)(346002)(39860400002)(366004)(396003)(83380400001)(66946007)(6486002)(478600001)(5660300002)(31686004)(4326008)(1006002)(6666004)(66556008)(66476007)(8936002)(2906002)(16526019)(53546011)(316002)(26005)(86362001)(16576012)(8676002)(52116002)(186003)(2616005)(956004)(31696002)(43740500002);
DIR:OUT; SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: LtWt9NTLMyTgQPtm4+M4fcE3MGHFOFy1+hFzBAEQq0TV1k1gMpOgu9UEfRkyioEzrUIYYLHVb/r9ddKYaFn53ZykwQCGI4+icEXin58zZMye6V8AvrUcFYZgkCzV8SoZ1CLUKVu9f7O0zvwdIMZcaVCqdvO7hiyRac2sBP7KTwvDkfTu7ECJCtGUQOvlhWQ5VHyXNfORZBsYnVgZjuQSDOpgluV7J+L+IpmoUvwVGckAKZErPuHGvW5juqBmRRDAlxvwjnj/zFyVR1H4kHMIcb51rKyceX/QBCpaeJ0/aeTUHY8ytQYpCS8HgvrkL5aYZOqjv8P6SKXp8I/goKc1+MHAakSBqE0GGxYQ6+ZKaVjq3h5BoaZ28UlDl4NPJYINZNXFXoWt3FGJqpUvxksfQHoyF7C5GjDIfkutXH+Ruj4FQpLXTeXbG/9zYxIJadWePEyk49haMp20BNlJ5RlCzSlOK7Lk+AIKwT48mh0e+R9BJl81anjG3EwIiN0GxlksoIBvsOKNeUffYSClxOZRp7YJjkgyKzW2/rymgnDFK8QB5qWnDggFqKQIObtnVsdUGl225slpOpXP7gU6r+iHnnLBu9k3tWBrsSmVQyBdZ0ojhUq7dnB3FApW8N9zoPmjDcO+MGbynhPu0L/ptkTOhA==
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9dcf8f12-2796-4a21-60b9-08d849b8e1e8
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5837.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2020 12:09:28.9455 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4SGZLrrd0/OjskAyoGxqp2m21pE7hWO+D+9Xa8bxSxWKlIx/78tJcYeSJLt8xb1DtALFffRJd7ZYvuNgtsQNsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2719
Subject: Re: [dpdk-dev] [PATCH] bus/dpaa: fix fd check before close
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Thanks Yunjian for the fix.
Acked-by: Sachin Saxena<sachin.saxena@oss.nxp.com>
On 26-Aug-20 5:24 PM, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> The fd is possibly a negative value while it is passed as an
> argument to function "close". Fix the check to the fd.
>
> Fixes: b9c94167904f ("bus/dpaa: decouple FQ portal alloc and init")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> drivers/bus/dpaa/base/qbman/qman_driver.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/dpaa/base/qbman/qman_driver.c b/drivers/bus/dpaa/base/qbman/qman_driver.c
> index 1166d68e2..1bff0bc2f 100644
> --- a/drivers/bus/dpaa/base/qbman/qman_driver.c
> +++ b/drivers/bus/dpaa/base/qbman/qman_driver.c
> @@ -142,7 +142,7 @@ struct qman_portal *fsl_qman_fq_portal_create(int *fd)
> struct qm_portal_config *q_pcfg;
> struct dpaa_ioctl_irq_map irq_map;
> struct dpaa_ioctl_portal_map q_map = {0};
> - int q_fd = 0, ret;
> + int q_fd = -1, ret;
>
> q_pcfg = kzalloc((sizeof(struct qm_portal_config)), 0);
> if (!q_pcfg) {
> @@ -191,7 +191,7 @@ struct qman_portal *fsl_qman_fq_portal_create(int *fd)
> err:
> if (portal)
> qman_free_global_portal(portal);
> - if (q_fd)
> + if (q_fd != -1)
> close(q_fd);
> process_portal_unmap(&q_map.addr);
> kfree(q_pcfg);