From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 70CCC1E2F
 for <dev@dpdk.org>; Mon,  9 Jan 2017 12:10:07 +0100 (CET)
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by orsmga104.jf.intel.com with ESMTP; 09 Jan 2017 03:10:06 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="51091343"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38])
 ([10.237.220.38])
 by fmsmga005.fm.intel.com with ESMTP; 09 Jan 2017 03:10:05 -0800
To: John Daley <johndale@cisco.com>, bruce.richardson@intel.com
References: <20170107044507.2407-1-johndale@cisco.com>
Cc: dev@dpdk.org
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <93fdc344-8c32-aaad-817a-c33c89aa821c@intel.com>
Date: Mon, 9 Jan 2017 11:10:04 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <20170107044507.2407-1-johndale@cisco.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] net/enic: add support for TSO
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jan 2017 11:10:07 -0000

Hi John,

On 1/7/2017 4:45 AM, John Daley wrote:
> The enic TSO implementation requires that the length of the Eth/IP/TCP
> headers be passed to the NIC. Other than that, it's just a matter of
> setting the mss and offload mode on a per packet basis.
> 
> In TSO mode, IP and TCP checksums are offloaded even if not requested
> with mb->ol_flags.
> 
> Signed-off-by: John Daley <johndale@cisco.com>

Can you please update doc/guides/nics/features/enic.ini to document the
TSO feature in this patch?

Thanks,
ferruh

> ---
<...>