From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5C4045A7A; Tue, 1 Oct 2024 14:11:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 935CA4027E; Tue, 1 Oct 2024 14:11:03 +0200 (CEST) Received: from flow-a3-smtp.messagingengine.com (flow-a3-smtp.messagingengine.com [103.168.172.138]) by mails.dpdk.org (Postfix) with ESMTP id AC8B14027C for ; Tue, 1 Oct 2024 14:11:02 +0200 (CEST) Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailflow.phl.internal (Postfix) with ESMTP id 1D6762005CC; Tue, 1 Oct 2024 08:11:02 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-10.internal (MEProxy); Tue, 01 Oct 2024 08:11:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1727784662; x=1727791862; bh=Y5pw/HGZXC7l95vMUjZ+2d3Kuc0Y4cJB5icJiy9H4pY=; b= B4FmCVhnNkMdxgxirQIBbJ5Ut1PG08KqJ6ognz/mNfijH4xZLM1sSuf5leZHC6xq FmjCGCCrlX0vaqizZXdYJ3hipVI1uj0yIMD+WXvejOidGw8Fc+FjfdI8yJBb1w5B CG0KU4bIfjPp17ZFnp08ssSB5uf93mCCF7hkpjlYNN17CapfEZx90pLmNsb7WKhh N7Yhundfxv8DBhfLs8RNyTrcBYymHpEJWXuW4OsRZn6AtUgRilVproiHHdaSrSI3 H+Hn7dOhL/zOsxuDQ0pi3AqnTJp7n3KAWnNmMAIuWkr0cbVlev82fMuIOTVMRyfl CNnXyZH+iaOXNpe3DcwA4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1727784662; x= 1727791862; bh=Y5pw/HGZXC7l95vMUjZ+2d3Kuc0Y4cJB5icJiy9H4pY=; b=F ApyWuVncBVglxNS/ztU/mciCRS30UmVM+cBcQIZ1YEnbXL378OEnvUFVPJltBRE3 WlGN9wsGlJGSWg2H79jy3v+NfMW3qXWNZc2CbbnNN9m1Aj6SSOySdy7lyJSMg9JA hHEVbtW4fsdmE/JQ4IgGjBhZrNkOSxVmllpRifBquNW2QhTyLrOX43jHXtZwfcWX 1NtUeWoEnpmZpog9YAGIc4gj40lD+j8QJ4oC0BQTNPb0qZO0muAOXUpueX41uonk r9s7KxxeyQssDDDC3N8GLn5hjptEmpQkO6cnqcIHqOTFFR/XUB0nRI7qECZn1BN4 J6Fa96iIX4vn5VzXuFFSg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddujedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeek ueevjeffjeegtdeggeekgfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn sggprhgtphhtthhopeelledpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepuggrvh hiugdrmhgrrhgthhgrnhgusehrvgguhhgrthdrtghomhdprhgtphhtthhopeguvghvsegu phgukhdrohhrghdprhgtphhtthhopehfvghnghgthhgvnhhgfigvnheshhhurgifvghird gtohhmpdhrtghpthhtoheprghnughrvgifrdhrhigstghhvghnkhhosehokhhtvghtlhgr sghsrdhruhdprhgtphhtthhopehnihgtohhlrghsrdgthhgruhhtrhhusehinhhtvghlrd gtohhmpdhrtghpthhtohepghdrshhinhhghhesnhigphdrtghomhdprhgtphhtthhopehh vghmrghnthdrrghgrhgrfigrlhesnhigphdrtghomhdprhgtphhtthhopehprghrrghvse hnvhhiughirgdrtghomhdprhgtphhtthhopeiguhgvmhhinhhglhesnhhvihguihgrrdgt ohhm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 1 Oct 2024 08:10:48 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, Chengwen Feng , Andrew Rybchenko , Nicolas Chautru , Gagandeep Singh , Hemant Agrawal , Parav Pandit , Xueming Li , Nipun Gupta , Nikhil Agarwal , Sachin Saxena , Rosen Xu , Tomasz Duszynski , Long Li , Wei Hu , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Harman Kalra , Anoob Joseph , Jingjing Wu , Chaoyong He , Nagadheeraj Rottela , Srikanth Jampala , Kai Ji , Lee Daly , Pablo de Lara , Fan Zhang , Ashish Gupta , Zhangfei Gao , Sunila Sahu , Jack Bond-Preston , Ajit Khaparde , Raveendra Padasalagi , Vikas Gupta , Sunil Uttarwar , Michael Shamis , Liron Himi , Jay Zhou , Bruce Richardson , Kevin Laatz , Conor Walsh , Gowrishankar Muthukrishnan , Vidya Sagar Velumuri , Abdullah Sevincer , Mattias =?UTF-8?B?UsO2bm5ibG9t?= , Jerin Jacob , Pavan Nikhilesh , Liang Ma , Peter Mccarthy , Harry van Haaren , Elena Agostini , "John W. Linville" , Ciara Loftus , Maryam Tahhan , Igor Russkikh , Steven Webster , Matt Peters , Selwin Sebastian , Julien Aube , Somnath Kotur , Wathsala Vithanage , Konstantin Ananyev , Chas Williams , "Min Hu (Connor)" , Shai Brandes , Evgeny Schemeilin , Ron Beider , Amit Bernstein , Wajeeh Atrash , Apeksha Gupta , John Daley , Hyong Youb Kim , Gaetan Rivet , Jeroen de Borst , Rushil Gupta , Joshua Washington , Ziyang Xuan , Xiaoyun Wang , Jie Hai , Yisen Zhuang , Jakub Grajciar , Matan Azrad , Viacheslav Ovsiienko , Zyta Szpak , Martin Spinler , Jiawen Wu , Tetsuya Mukawa , Vamsi Attunuru , Cristian Dumitrescu , Stephen Hemminger , Maciej Czekaj , Jian Wang , Maxime Coquelin , Chenbo Xia , Jochen Behrens , Jakub Palider Subject: Re: [PATCH v2 14/14] drivers: use per line logging in helpers Date: Tue, 01 Oct 2024 14:10:47 +0200 Message-ID: <9408451.CDJkKcVGEf@thomas> In-Reply-To: <20240912082643.1532679-15-david.marchand@redhat.com> References: <20240907145433.1479091-1-david.marchand@redhat.com> <20240912082643.1532679-1-david.marchand@redhat.com> <20240912082643.1532679-15-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/09/2024 10:26, David Marchand: > Use RTE_LOG(_DP)?_LINE(_PREFIX)? in existing macros that append a \n. > > Signed-off-by: David Marchand > Acked-by: Chengwen Feng > Acked-by: Andrew Rybchenko [...] > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -53,7 +53,7 @@ print_usage () { > check_forbidden_additions() { # > res=0 > > - # refrain from new calls to RTE_LOG > + # refrain from new calls to RTE_LOG in libraries > awk -v FOLDERS="lib" \ > -v EXPRESSIONS="RTE_LOG\\\(" \ > -v RET_ON_FAIL=1 \ > @@ -61,6 +61,15 @@ check_forbidden_additions() { # > -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ > "$1" || res=1 > > + # refrain from new calls to RTE_LOG in drivers (but leave some leeway for base drivers) > + awk -v FOLDERS="drivers" \ > + -v SKIP_FILES='osdep.h$' \ > + -v EXPRESSIONS="RTE_LOG\\\( RTE_LOG_DP\\\( rte_log\\\(" \ > + -v RET_ON_FAIL=1 \ > + -v MESSAGE='Prefer RTE_LOG_LINE/RTE_LOG_DP_LINE' \ > + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ > + "$1" || res=1 It should be easier to maintain, thanks for the cleanup. Acked-by: Thomas Monjalon