From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f181.google.com (mail-we0-f181.google.com [74.125.82.181]) by dpdk.org (Postfix) with ESMTP id DCADC5A70 for ; Tue, 20 Jan 2015 09:01:09 +0100 (CET) Received: by mail-we0-f181.google.com with SMTP id q58so35536710wes.12 for ; Tue, 20 Jan 2015 00:01:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=3aqfGbcOmVuC+nAv9bkjYEmt+TLCHosbU2kNnzPoYR0=; b=CywPCBp2G3upvWe8N6Y6rC/PsTGdunx1ME/IRlNFMgb0A5naTs5OWfveIFoNmHYzdO jfPkywJ/F06OWkSr7M102ZubMO/bcS2Lz2WRofp+G+Ktok/9z5tfY68WtVtbKBBf/owN 3KAewdckrBvHMhFupxKQef63iTT1+0i//SlD0eRMDSvFH+grYGyE1CHrk9UAK20SJXh+ KlslApcWkg3c+wguH1KxJoESnq/Y8wA7O1S6ndCPju7IAbnfSm59DZU4F8ZQMshwkgy5 l4S3iOcxLjjFmMfWH7qa6QI6Iz68wai+siMRrk6RvIHdrL1QCsPhuPiyC/FB2C1XIXFs Bpmg== X-Gm-Message-State: ALoCoQkBQEqGwpTOjMbQK/6tDdr0EpyMfhCNo/8DI6DKV9/2qWeUp/P785hieELXJj16/nLfq8+8 X-Received: by 10.180.77.39 with SMTP id p7mr17200966wiw.8.1421740869610; Tue, 20 Jan 2015 00:01:09 -0800 (PST) Received: from xps13.localnet (111.26.90.92.rev.sfr.net. [92.90.26.111]) by mx.google.com with ESMTPSA id eu8sm1921487wib.21.2015.01.20.00.01.06 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Jan 2015 00:01:08 -0800 (PST) From: Thomas Monjalon To: Reshma Pattan Date: Tue, 20 Jan 2015 09:00:38 +0100 Message-ID: <9416100.1lhCgRCuAQ@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1420648753-17136-1-git-send-email-reshma.pattan@intel.com> References: <1420648753-17136-1-git-send-email-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/3] librte_reorder: New reorder library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2015 08:01:10 -0000 Hi, 2015-01-07 16:39, Reshma Pattan: > 1)New library to provide reordering of out of ordered > mbufs based on sequence number of mbuf. Library uses reorder buffer structure > which in tern uses two circular buffers called ready and order buffers. > *rte_reorder_create API creates instance of reorder buffer. > *rte_reorder_init API initializes given reorder buffer instance. > *rte_reorder_reset API resets given reorder buffer instance. > *rte_reorder_insert API inserts the mbuf into order circular buffer. > *rte_reorder_fill_overflow moves mbufs from order buffer to ready buffer > to accomodate early packets in order buffer. > *rte_reorder_drain API provides draining facility to fetch out > reordered mbufs from order and ready buffers. > > Signed-off-by: Reshma Pattan > Signed-off-by: Richardson Bruce I think 2 things are missing in this patchset: 1) Could you show some performance numbers to compare a simple forwarding with and without this library, in the commit log? 2) Could you add some documentation in doc/ directory for programmer's guide? Thank you -- Thomas