From: Ferruh Yigit <ferruh.yigit@xilinx.com>
To: "Guo, Junfeng" <junfeng.guo@intel.com>,
"Singh, Aman Deep" <aman.deep.singh@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Wang, Xiao W" <xiao.w.wang@intel.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Subject: Re: [PATCH v2] app/testpmd: add throughput stats for forward streams
Date: Tue, 16 Aug 2022 10:32:36 +0100 [thread overview]
Message-ID: <94318c7e-40fb-0623-d1d8-7f33788bc557@xilinx.com> (raw)
In-Reply-To: <DM6PR11MB3723010B19362E9ECC583BB0E7649@DM6PR11MB3723.namprd11.prod.outlook.com>
On 8/11/2022 7:57 AM, Guo, Junfeng wrote:
>
>
>> -----Original Message-----
>> From: Singh, Aman Deep <aman.deep.singh@intel.com>
>> Sent: Friday, June 17, 2022 00:40
>> To: Guo, Junfeng <junfeng.guo@intel.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing,
>> Beilei <beilei.xing@intel.com>
>> Cc: dev@dpdk.org; Wang, Xiao W <xiao.w.wang@intel.com>
>> Subject: Re: [PATCH v2] app/testpmd: add throughput stats for
>> forward streams
>>
>> Hi Junfeng,
>>
>> Thanks for the patch.
>>
>>
>> On 6/6/2022 3:09 PM, Junfeng Guo wrote:
>>> 1. add throughput statistics (in pps) for forward streams.
>>> 2. display the forward statistics for every forward stream.
>>>
>>> v2:
>>> add parameter descriptions and fix commit title.
>>>
>>> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
>>> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com>
>>> ---
>>>
>> We do have per port Rx/Tx pps in display stats.
>> For per forward stream we can enable "--record-burst-stats".
>> With it we can get per fwd stream Rx/Tx pps.
>>
>> Please check if this patch is adding any additional functionality.
>
> Sorry for the late reply.
> Seems that "--record-burst-stats" could only show the stats of Rx/Tx bursts.
>
Hi Junfeng,
What is the impact of this change to the performance?
And what do you think enabling it with an command,
like existing "set record-*" ones?
> Actually this patch can enable the throughput stats, which has not been supported in current testpmd.
> So we hope this functionality could be added.
> Thanks!
>
>>
>> <snip>
>
next prev parent reply other threads:[~2022-08-16 9:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 8:27 [PATCH] testpmd: optimize forward stream statistics Junfeng Guo
2022-05-31 15:27 ` Andrew Rybchenko
2022-06-06 9:02 ` Guo, Junfeng
2022-06-01 8:46 ` Singh, Aman Deep
2022-06-06 9:00 ` Guo, Junfeng
2022-06-06 9:39 ` [PATCH v2] app/testpmd: add throughput stats for forward streams Junfeng Guo
2022-06-16 16:39 ` Singh, Aman Deep
2022-08-11 6:57 ` Guo, Junfeng
2022-08-16 9:32 ` Ferruh Yigit [this message]
2022-08-18 6:57 ` Guo, Junfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94318c7e-40fb-0623-d1d8-7f33788bc557@xilinx.com \
--to=ferruh.yigit@xilinx.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=aman.deep.singh@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=junfeng.guo@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).