From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 709B81E2F for ; Tue, 16 Oct 2018 19:07:53 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CD42D30C9EFD; Tue, 16 Oct 2018 17:07:52 +0000 (UTC) Received: from [10.36.112.24] (ovpn-112-24.ams2.redhat.com [10.36.112.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B966E62943; Tue, 16 Oct 2018 17:07:48 +0000 (UTC) To: Timothy Redaelli , Tiwei Bie , Zhihong Wang Cc: Fan Zhang , dev@dpdk.org References: From: Maxime Coquelin Message-ID: <9433dc9a-51e9-704f-b426-a8c04de82b17@redhat.com> Date: Tue, 16 Oct 2018 19:07:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Tue, 16 Oct 2018 17:07:52 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost/crypto: fix build without cryptodev (shared lib) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 17:07:53 -0000 On 10/16/2018 06:54 PM, Timothy Redaelli wrote: > Currently it's not possible to build DPDK as shared library with > cryptodev disabled since vhost is trying to link with rte_crypto, > but rte_crypto and rte_hash are only needed when you build vhost_crypto > and so only when cryptodev is enabled. > > This patch fix this by linking rte_vhost with rte_crypto and rte_hash only > when cryptodev is enabled. > > Fixes: b4ca81298613 ("vhost/crypto: fix build without cryptodev") > Fixes: d090c7f86a76 ("vhost/crypto: update makefile") The above commit does not exist (check-git-log.sh reports an error). I think this is the commit that should be mentioned: Fixes: 939066d96563 ("vhost/crypto: add public function implementation") Also, we need to cc stable@dpdk.org so that it gets backported to v18.08. Wit that fixed, please add my: Reviewed-by: Maxime Coquelin Thanks, Maxime > > Signed-off-by: Timothy Redaelli > --- > lib/librte_vhost/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_vhost/Makefile b/lib/librte_vhost/Makefile > index 531cf4832..5dd318987 100644 > --- a/lib/librte_vhost/Makefile > +++ b/lib/librte_vhost/Makefile > @@ -19,8 +19,7 @@ LDLIBS += -lpthread > ifeq ($(CONFIG_RTE_LIBRTE_VHOST_NUMA),y) > LDLIBS += -lnuma > endif > -LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev -lrte_net \ > - -lrte_cryptodev -lrte_hash > +LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev -lrte_net > > # all source are stored in SRCS-y > SRCS-$(CONFIG_RTE_LIBRTE_VHOST) := fd_man.c iotlb.c socket.c vhost.c \ > @@ -31,6 +30,7 @@ SYMLINK-$(CONFIG_RTE_LIBRTE_VHOST)-include += rte_vhost.h rte_vdpa.h > > # only compile vhost crypto when cryptodev is enabled > ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y) > +LDLIBS += -lrte_cryptodev -lrte_hash > SRCS-$(CONFIG_RTE_LIBRTE_VHOST) += vhost_crypto.c > SYMLINK-$(CONFIG_RTE_LIBRTE_VHOST)-include += rte_vhost_crypto.h > endif >