From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E2DECA0503;
	Thu, 19 May 2022 10:14:54 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D342D40223;
	Thu, 19 May 2022 10:14:54 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 2A5A740150
 for <dev@dpdk.org>; Thu, 19 May 2022 10:14:53 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B22038A;
 Thu, 19 May 2022 11:14:52 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B22038A
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1652948092;
 bh=oAKqeNbkkv1sxmZ8E0wf1TNGY/jcoXkJ2zHxV37MYlw=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=pj7+Saj5nv90Y6kZhFb9UK5tBrIyCaEYu+0dvcFFjYDxdKC61ODkSwsR3bo7q3pR2
 sW4FzG5MuRIM7+7aqjHCvG63B9T8paXbnzYJD20hH2q0NrmX4leql/AwfVfIAE8whP
 ZXfzVvdUwvOBHfAj9k0SI5DDJINf7zyIL+gXtUiY=
Message-ID: <94385442-95fb-6df8-2207-afb8d39889f6@oktetlabs.ru>
Date: Thu, 19 May 2022 11:14:52 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v3] app/testpmd: support ddp dump command for ice
Content-Language: en-US
To: Stephen Hemminger <stephen@networkplumber.org>,
 Steve Yang <stevex.yang@intel.com>
Cc: dev@dpdk.org, yuying.zhang@intel.com, qi.z.zhang@intel.com
References: <20220512020618.474816-1-stevex.yang@intel.com>
 <20220518065806.1005694-1-stevex.yang@intel.com>
 <20220518082432.4072557b@hermes.local>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20220518082432.4072557b@hermes.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 5/18/22 18:24, Stephen Hemminger wrote:
> On Wed, 18 May 2022 06:58:06 +0000
> Steve Yang <stevex.yang@intel.com> wrote:
> 
>> +#define ICE_BUFF_SIZE	0x000c9000
> Having magic size hard coded in testpmd is bad idea.
> If there is driver specific size it should be exposed by API
> 
>> +	size = ICE_BUFF_SIZE;
>> +	buff = (uint8_t *)malloc(ICE_BUFF_SIZE);
> 
> Cast of void * is not necessary in C (only C++)

Also the patch breaks build as reported by CI [1]:

[1] 
https://patches.dpdk.org/project/dpdk/patch/20220518065806.1005694-1-stevex.yang@intel.com/