From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40AE2A0562; Tue, 31 Mar 2020 11:11:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5FE6E1C025; Tue, 31 Mar 2020 11:11:19 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 712481BFD4 for ; Tue, 31 Mar 2020 11:11:17 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id B720C5C0528; Tue, 31 Mar 2020 05:11:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 31 Mar 2020 05:11:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=9k5dZInYcl9gC1VejD6PLtdRi2rKq19c51poaXMAxPQ=; b=hWWKsytReW8T LjkXmKOSdCkGFzQCrhBkVX8IbJ3qRryfLq/EnU9Hq+YgNiHQ5/EJFeh4Ua22NFaG BgYEdZ42eVotekrIyUcVsnq7ZclbhoXcEzFGs54VCuB+d9/28v8uyANwYhDx4fz/ onp8I2DupIvbPhc2haTBO5rDe/NTpqc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=9k5dZInYcl9gC1VejD6PLtdRi2rKq19c51poaXMAx PQ=; b=vND49d0BCLeKvW2ObBVMmrNYkfCxOXMxs4mqcifL8+aF94IHwqjWSfYYI F65Mr4blMzhrxgCcIF6STnQjVRAFwTUrJfqeLbf8+71mtfOH0Np6qx3lC9xPmek7 sbv1U9Tqhziu5gZOcdxh2xee4W1XkavAKF9PM43pcZBFxqcYJlxVcWq1Su52wT3Y zPKdgVwI34CfxmGwlJupg1QsJG/VNynpBmzpc/M3frAoz6cxHkOpUVl/0Rd1vHxg NCSJpjZTCB3jhec7c/Zrclw/pLb9mEvxQZ9Ey1Lywsv8SnvDgWkET1yUqgFRu3Ly E9cVJ9kQHzQFh9pxXUluu9MwegLrw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudeijedguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D57B7306CB23; Tue, 31 Mar 2020 05:11:15 -0400 (EDT) From: Thomas Monjalon To: vijay mohan Cc: dev@dpdk.org, "Trahe, Fiona" , Ferruh Yigit Date: Tue, 31 Mar 2020 11:11:13 +0200 Message-ID: <9440390.nnTZe4vzsl@xps> In-Reply-To: References: <1583452940-346826-1-git-send-email-vijay1054@gmail.com> <2216574.9XhxPE3A7Q@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] bus/pci: pcidev access from secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 31/03/2020 04:12, vijay mohan: > On Mon, 30 Mar 2020 at 18:54, Thomas Monjalon wrote: > > 06/03/2020 13:28, Ferruh Yigit: > > > On 3/6/2020 12:02 AM, Vijaya Mohan Guvva wrote: > > > > For pci devices presented through igb_uio, pcidev->mem_resource[] is > > > > not populated when the device is initialized for secondary process. > > > > > > > > Initialize pcidev->mem_resource[] with pci-bar mapped addresses. > > > > > > > > Signed-off-by: Vijaya Mohan Guvva > > > > > > Reviewed-by: Ferruh Yigit > > > > Do you mean secondary process never worked with igb_uio? > > Or is there a specific case? > > As long as pmd or application doesn't access > dev->mem_resource[i].addr, secondary process works with igb_uio. > But for pci devices like crypto_qat, pmd checks for > dev->mem_resource[i].addr and bails out if the address is null. > > > What is the root cause? > > Root cause is, not initializing the mapped address in rte_pcidev when > device is exposed through igb_uio. So the issue has always been there? In this case, you should specify the origin commit in "Fixes:" line. > > Should it be backported to stable? I think it needs to be backported. So please add Cc: stable@dpdk.org in the commit log.