From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 09EDEFA78 for ; Mon, 27 Mar 2017 12:34:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490610841; x=1522146841; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=oSCHLevPkugfCCe9bLz3ASsIBV2DTGUwRCh6/R0wiUw=; b=B8d/QEM1cC05r2wq1wVOoYUgTXMF/cyE/bzdG9A/1FES/BEYihHiwgcg AUy5UT329JpBJQJbhzQqYE+qgBwMvg==; Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2017 03:33:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,231,1486454400"; d="scan'208";a="240682208" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 27 Mar 2017 03:33:59 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 27 Mar 2017 03:33:59 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 27 Mar 2017 03:33:59 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.224]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.253]) with mapi id 14.03.0248.002; Mon, 27 Mar 2017 18:33:57 +0800 From: "Xing, Beilei" To: "Wu, Jingjing" CC: "Zhang, Helin" , "dev@dpdk.org" , "Iremonger, Bernard" Thread-Topic: [PATCH v2 1/4] net/i40e: rework tunnel filter functions Thread-Index: AQHSpt8XlT2lBaxf+EiTwYSx9WHO9aGofJuQ Date: Mon, 27 Mar 2017 10:33:56 +0000 Message-ID: <94479800C636CB44BD422CB454846E01315C1419@SHSMSX101.ccr.corp.intel.com> References: <1488533497-27682-1-git-send-email-beilei.xing@intel.com> <1490265990-121019-1-git-send-email-beilei.xing@intel.com> <1490265990-121019-2-git-send-email-beilei.xing@intel.com> <9BB6961774997848B5B42BEC655768F810D14A33@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810D14A33@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/4] net/i40e: rework tunnel filter functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2017 10:34:01 -0000 > -----Original Message----- > From: Wu, Jingjing > Sent: Monday, March 27, 2017 5:47 PM > To: Xing, Beilei > Cc: Zhang, Helin ; dev@dpdk.org; Iremonger, > Bernard > Subject: RE: [PATCH v2 1/4] net/i40e: rework tunnel filter functions >=20 >=20 >=20 > > -----Original Message----- > > From: Xing, Beilei > > Sent: Thursday, March 23, 2017 6:46 PM > > To: Wu, Jingjing > > Cc: Zhang, Helin ; dev@dpdk.org > > Subject: [PATCH v2 1/4] net/i40e: rework tunnel filter functions > > > > Rework tunnel filter functions to align with the new command buffer > > for add/remove cloud filter. > > > > Signed-off-by: Beilei Xing > > --- > > drivers/net/i40e/i40e_ethdev.c | 100 > > +++++++++++++++++++++++++++---------- > > ---- > > drivers/net/i40e/i40e_ethdev.h | 1 + > > drivers/net/i40e/i40e_flow.c | 28 +++++++----- > > 3 files changed, 86 insertions(+), 43 deletions(-) > > >=20 >=20 > > @@ -10289,13 +10307,29 @@ i40e_tunnel_filter_restore(struct i40e_pf *pf= ) > > struct i40e_tunnel_filter_list > > *tunnel_list =3D &pf->tunnel.tunnel_list; > > struct i40e_tunnel_filter *f; > > - struct i40e_aqc_add_remove_cloud_filters_element_data cld_filter; > > + struct i40e_aqc_add_rm_cloud_filt_elem_ext cld_filter; > > + bool big_buffer =3D 0; > > > > TAILQ_FOREACH(f, tunnel_list, rules) { > > memset(&cld_filter, 0, sizeof(cld_filter)); > > - rte_memcpy(&cld_filter, &f->input, sizeof(f->input)); > > - cld_filter.queue_number =3D f->queue; > > - i40e_aq_add_cloud_filters(hw, vsi->seid, &cld_filter, 1); > > + ether_addr_copy((struct ether_addr *)&f->input.outer_mac, > > + (struct ether_addr *)&cld_filter.element.outer_mac); > > + ether_addr_copy((struct ether_addr *)&f->input.inner_mac, > > + (struct ether_addr *)&cld_filter.element.inner_mac); > > + cld_filter.element.inner_vlan =3D f->input.inner_vlan; > > + cld_filter.element.flags =3D f->input.flags; > > + cld_filter.element.tenant_id =3D f->input.tenant_id; > > + cld_filter.element.queue_number =3D f->queue; > > + rte_memcpy(cld_filter.general_fields, > > + f->input.general_fields, > > + sizeof(f->input.general_fields)); > > + > > + if (big_buffer) > > + i40e_aq_add_cloud_filters_big_buffer(hw, vsi->seid, > > + &cld_filter, 1); > > + else > > + i40e_aq_add_cloud_filters(hw, vsi->seid, > > + &cld_filter.element, 1); > > } >=20 > Big_buffer is always 0, why we need to check it? Big_buffer will be 1 if the filter_type is MPLSoGRE/MPLSoUDP. But MPLS enab= ling in the next patchset. Will update in next version.