From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 4FF8B4CE4 for ; Thu, 1 Jun 2017 04:21:33 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 May 2017 19:21:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,277,1493708400"; d="scan'208";a="109449590" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 31 May 2017 19:21:31 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 31 May 2017 19:21:31 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 31 May 2017 19:21:31 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.197]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.56]) with mapi id 14.03.0319.002; Thu, 1 Jun 2017 10:21:28 +0800 From: "Xing, Beilei" To: "Chilikin, Andrey" , "dev@dpdk.org" CC: "Wu, Jingjing" Thread-Topic: [PATCH] net/i40e: get information about ddp profile Thread-Index: AQHS1h2UOmpJRFg7YUeqeNLcoUmp1KIPPakg Date: Thu, 1 Jun 2017 02:21:26 +0000 Message-ID: <94479800C636CB44BD422CB454846E0131FBEF2C@SHSMSX101.ccr.corp.intel.com> References: <1495802517-11573-1-git-send-email-andrey.chilikin@intel.com> In-Reply-To: <1495802517-11573-1-git-send-email-andrey.chilikin@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: get information about ddp profile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 02:21:35 -0000 Hi Andrey, > -----Original Message----- > From: Chilikin, Andrey > Sent: Friday, May 26, 2017 8:42 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Wu, Jingjing > ; Chilikin, Andrey > Subject: [PATCH] net/i40e: get information about ddp profile >=20 > This patch adds ability to request information about dynamic device > personalization profile >=20 > Signed-off-by: Andrey Chilikin > --- > drivers/net/i40e/rte_pmd_i40e.c | 163 > ++++++++++++++++++++++++++++++++++++++- > drivers/net/i40e/rte_pmd_i40e.h | 45 +++++++++++ > 2 files changed, 204 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/i40e/rte_pmd_i40e.c > b/drivers/net/i40e/rte_pmd_i40e.c index f7ce62b..72e1564 100644 > --- a/drivers/net/i40e/rte_pmd_i40e.c > +++ b/drivers/net/i40e/rte_pmd_i40e.c > @@ -1468,7 +1468,7 @@ int rte_pmd_i40e_set_vf_vlan_filter(uint8_t port, > uint16_t vlan_id, > return ret; > } >=20 > -#define I40E_PROFILE_INFO_SIZE 48 > +#define I40E_PROFILE_INFO_SIZE sizeof(struct rte_pmd_i40e_profile_info) > #define I40E_MAX_PROFILE_NUM 16 >=20 > static void > @@ -1520,9 +1520,6 @@ int rte_pmd_i40e_set_vf_vlan_filter(uint8_t port, > uint16_t vlan_id, > return status; > } >=20 > -#define I40E_PROFILE_INFO_SIZE 48 > -#define I40E_MAX_PROFILE_NUM 16 > - > /* Check if the profile info exists */ > static int > i40e_check_profile_info(uint8_t port, uint8_t *profile_info_sec) @@ - > 1682,6 +1679,164 @@ int rte_pmd_i40e_set_vf_vlan_filter(uint8_t port, > uint16_t vlan_id, > return status; > } >=20 > +int rte_pmd_i40e_get_ddp_info(uint8_t *pkg_buff, uint32_t pkg_size, > + uint8_t *info_buff, uint32_t info_size, > + enum rte_pmd_i40e_package_info type) > +{ > + uint32_t ret_size; > + struct i40e_package_header *pkg_hdr; > + struct i40e_generic_seg_header *i40e_seg_hdr; > + struct i40e_generic_seg_header *note_seg_hdr; > + struct i40e_generic_seg_header *metadata_seg_hdr; > + > + if (!info_buff) { > + PMD_DRV_LOG(ERR, "Output info buff is invalid."); > + return -EINVAL; > + } > + > + if (!pkg_buff || pkg_size < (sizeof(struct i40e_package_header) + > + sizeof(struct i40e_metadata_segment) + > + sizeof(uint32_t) * 2)) { > + PMD_DRV_LOG(ERR, "Package buff is invalid."); > + return -EINVAL; > + } > + > + pkg_hdr =3D (struct i40e_package_header *)pkg_buff; > + if (pkg_hdr->segment_count < 2) { > + PMD_DRV_LOG(ERR, "Segment_count should be 2 at least."); > + return -EINVAL; > + } > + > + /* Find metadata segment */ > + metadata_seg_hdr =3D > i40e_find_segment_in_package(SEGMENT_TYPE_METADATA, > + pkg_hdr); > + > + /* Find global notes segment */ > + note_seg_hdr =3D > i40e_find_segment_in_package(SEGMENT_TYPE_NOTES, > + pkg_hdr); > + > + /* Find i40e profile segment */ > + i40e_seg_hdr =3D > i40e_find_segment_in_package(SEGMENT_TYPE_I40E, > +pkg_hdr); > + > + /* get global header info */ > + if (type =3D=3D RTE_PMD_I40E_PKG_INFO_GLOBAL_HEADER) { > + struct rte_pmd_i40e_profile_info *info =3D > + (struct rte_pmd_i40e_profile_info *)info_buff; > + > + if (info_size < sizeof(struct rte_pmd_i40e_profile_info)) { > + PMD_DRV_LOG(ERR, "Output info buff size is > invalid."); > + return -EINVAL; > + } > + > + if (!metadata_seg_hdr) { > + PMD_DRV_LOG(ERR, "Failed to find metadata > segment header"); > + return -EINVAL; > + } > + > + memset(info, 0, sizeof(struct rte_pmd_i40e_profile_info)); > + info->owner =3D RTE_PMD_I40E_DDP_OWNER_UNKNOWN; > + info->track_id =3D > + ((struct i40e_metadata_segment > *)metadata_seg_hdr)->track_id; > + > + memcpy(info->name, > + ((struct i40e_metadata_segment > *)metadata_seg_hdr)->name, > + I40E_DDP_NAME_SIZE); > + memcpy(&info->version, > + &((struct i40e_metadata_segment > *)metadata_seg_hdr)->version, > + sizeof(struct i40e_ddp_version)); > + return I40E_SUCCESS; > + } > + > + /* get global note size */ > + if (type =3D=3D RTE_PMD_I40E_PKG_INFO_GLOBAL_NOTES_SIZE) { > + if (info_size < sizeof(uint32_t)) { > + PMD_DRV_LOG(ERR, "Invalid information buffer > size"); > + return -EINVAL; > + } > + if (note_seg_hdr =3D=3D NULL) > + ret_size =3D 0; > + else > + ret_size =3D note_seg_hdr->size; > + *(uint32_t *)info_buff =3D ret_size; > + return I40E_SUCCESS; > + } > + > + /* get global note */ > + if (type =3D=3D RTE_PMD_I40E_PKG_INFO_GLOBAL_NOTES) { > + if (note_seg_hdr =3D=3D NULL) > + return -ENOTSUP; > + if (info_size < note_seg_hdr->size) { > + PMD_DRV_LOG(ERR, "Information buffer size is too > small"); > + return -EINVAL; > + } > + memcpy(info_buff, ¬e_seg_hdr[1], note_seg_hdr->size); > + return I40E_SUCCESS; > + } > + > + /* get i40e segment header info */ > + if (type =3D=3D RTE_PMD_I40E_PKG_INFO_HEADER) { > + struct rte_pmd_i40e_profile_info *info =3D > + (struct rte_pmd_i40e_profile_info *)info_buff; > + > + if (info_size < sizeof(struct rte_pmd_i40e_profile_info)) { > + PMD_DRV_LOG(ERR, "Output info buff size is > invalid."); > + return -EINVAL; > + } > + > + if (!metadata_seg_hdr) { > + PMD_DRV_LOG(ERR, "Failed to find metadata > segment header"); > + return -EINVAL; > + } > + > + if (!i40e_seg_hdr) { > + PMD_DRV_LOG(ERR, "Failed to find i40e segment > header"); > + return -EINVAL; > + } > + > + memset(info, 0, sizeof(struct rte_pmd_i40e_profile_info)); > + info->owner =3D RTE_PMD_I40E_DDP_OWNER_UNKNOWN; > + info->track_id =3D > + ((struct i40e_metadata_segment > *)metadata_seg_hdr)->track_id; > + > + memcpy(info->name, > + ((struct i40e_profile_segment *)i40e_seg_hdr)- > >name, > + I40E_DDP_NAME_SIZE); > + memcpy(&info->version, > + &((struct i40e_profile_segment *)i40e_seg_hdr)- > >version, > + sizeof(struct i40e_ddp_version)); > + return I40E_SUCCESS; > + } > + > + /* get number of devices */ > + if (type =3D=3D RTE_PMD_I40E_PKG_INFO_DEVID_NUM) { > + if (info_size < sizeof(uint32_t)) { > + PMD_DRV_LOG(ERR, "Invalid information buffer > size"); > + return -EINVAL; > + } > + *(uint32_t *)info_buff =3D > + ((struct i40e_profile_segment *)i40e_seg_hdr)- > >device_table_count; > + return I40E_SUCCESS; > + } > + > + /* get list of devices */ > + if (type =3D=3D RTE_PMD_I40E_PKG_INFO_DEVID_LIST) { > + uint32_t dev_num; > + dev_num =3D > + ((struct i40e_profile_segment *)i40e_seg_hdr)- > >device_table_count; > + if (info_size < sizeof(struct > rte_pmd_i40e_ddp_device_id)*dev_num) { > + PMD_DRV_LOG(ERR, "Invalid information buffer > size"); > + return -EINVAL; > + } > + memcpy(info_buff, > + ((struct i40e_profile_segment *)i40e_seg_hdr)- > >device_table, > + sizeof(struct > rte_pmd_i40e_ddp_device_id)*dev_num); > + return I40E_SUCCESS; > + } > + > + PMD_DRV_LOG(ERR, "Info type %u is invalid.", type); > + return -EINVAL; > +} How about using switch case to replace above if statements? > + > int > rte_pmd_i40e_get_ddp_list(uint8_t port, uint8_t *buff, uint32_t size) {= diff > --git a/drivers/net/i40e/rte_pmd_i40e.h b/drivers/net/i40e/rte_pmd_i40e.h > index 1efb2c4..0f376e2 100644 > --- a/drivers/net/i40e/rte_pmd_i40e.h > +++ b/drivers/net/i40e/rte_pmd_i40e.h > @@ -74,6 +74,21 @@ enum rte_pmd_i40e_package_op { > RTE_PMD_I40E_PKG_OP_MAX =3D 32 > }; >=20 > +/** > +* Types of package information. > +*/ > +enum rte_pmd_i40e_package_info { > + RTE_PMD_I40E_PKG_INFO_UNDEFINED =3D 0, > + RTE_PMD_I40E_PKG_INFO_GLOBAL_HEADER, > + RTE_PMD_I40E_PKG_INFO_GLOBAL_NOTES_SIZE, > + RTE_PMD_I40E_PKG_INFO_GLOBAL_NOTES, > + RTE_PMD_I40E_PKG_INFO_GLOBAL_MAX =3D 1024, > + RTE_PMD_I40E_PKG_INFO_HEADER, > + RTE_PMD_I40E_PKG_INFO_DEVID_NUM, > + RTE_PMD_I40E_PKG_INFO_DEVID_LIST, > + RTE_PMD_I40E_PKG_INFO_MAX =3D 0xFFFFFFFF }; > + > #define RTE_PMD_I40E_DDP_NAME_SIZE 32 >=20 > /** > @@ -88,6 +103,14 @@ struct rte_pmd_i40e_ddp_version { }; >=20 > /** > +* Device ID for dynamic device personalization. > +*/ > +struct rte_pmd_i40e_ddp_device_id { > + uint32_t vendor_dev_id; > + uint32_t sub_vendor_dev_id; > +}; > + > +/** > * Profile information in profile info list. > */ > struct rte_pmd_i40e_profile_info { > @@ -98,6 +121,8 @@ struct rte_pmd_i40e_profile_info { > uint8_t name[RTE_PMD_I40E_DDP_NAME_SIZE]; }; >=20 > +#define RTE_PMD_I40E_DDP_OWNER_UNKNOWN 0xFF > + > /** > * Profile information list returned from HW. > */ > @@ -499,6 +524,26 @@ int rte_pmd_i40e_process_ddp_package(uint8_t > port, uint8_t *buff, > enum rte_pmd_i40e_package_op op); >=20 > /** > +* rte_pmd_i40e_get_ddp_info - Get profile's info > +* @param pkg > +* buffer of package. > +* @param pkg_size > +* package buffer size > +* @param info > +* buffer for response > +* @param size > +* response buffer size > +* @param type > +* type of information requested > +* @return > +* - (0) if successful. > +* - (-EINVAL) if bad parameter. > +*/ > +int rte_pmd_i40e_get_ddp_info(uint8_t *pkg, uint32_t pkg_size, > + uint8_t *info, uint32_t size, > + enum rte_pmd_i40e_package_info type); > + > +/** > * rte_pmd_i40e_get_ddp_list - Get loaded profile list > * @param port > * port id > -- > 1.7.0.7 Will you add testpmd CLI to support getting DDP info? Besides, API info in rte_pmd_i40e_version.map should be updated.