From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <beilei.xing@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id B36EE7D3B
 for <dev@dpdk.org>; Fri, 18 Aug 2017 18:18:07 +0200 (CEST)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by orsmga104.jf.intel.com with ESMTP; 18 Aug 2017 09:18:06 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.41,393,1498546800"; d="scan'208";a="139181410"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
 by orsmga005.jf.intel.com with ESMTP; 18 Aug 2017 09:18:06 -0700
Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Fri, 18 Aug 2017 09:18:06 -0700
Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by
 FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Fri, 18 Aug 2017 09:18:06 -0700
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.128]) by
 SHSMSX152.ccr.corp.intel.com ([169.254.6.135]) with mapi id 14.03.0319.002;
 Sat, 19 Aug 2017 00:18:04 +0800
From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Mrzyglod, DanielX T" <danielx.t.mrzyglod@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Mrzyglod, DanielX T"
 <danielx.t.mrzyglod@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: wrong usage of fseek & ftell
 to	determine filesize
Thread-Index: AQHTGC0h+jEveyZxhE+jTZBf8TmXVaKKSmAQ
Date: Fri, 18 Aug 2017 16:18:03 +0000
Message-ID: <94479800C636CB44BD422CB454846E01320071EC@SHSMSX101.ccr.corp.intel.com>
References: <20170818141736.4769-1-danielx.t.mrzyglod@intel.com>
In-Reply-To: <20170818141736.4769-1-danielx.t.mrzyglod@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWFhNTI4YjItODI1NC00Yzk2LWJmNDYtYmE1ZTNjNWM2OGIyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjQzbkQ3ajArSmF0dE4yVXoyRldDMWtKOU5XN1RzdXMxSmFSa2JrbDVcLzl3PSJ9
x-ctpclassification: CTP_IC
dlp-product: dlpe-windows
dlp-version: 10.0.102.7
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: wrong usage of fseek & ftell
	to	determine filesize
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Aug 2017 16:18:08 -0000


> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Daniel Mrzyglod
> Sent: Friday, August 18, 2017 10:18 PM
> To: Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com>
> Subject: [dpdk-dev] [PATCH] app/testpmd: wrong usage of fseek & ftell to
> determine filesize
>=20
> This issue was about passing unsigned argument where should be signed
> number.
> In reality this is about wrong usage of fseek and ftell to determine file=
size.
> This patch is compliant to suggestions from FIO19-C:
> "Do not use fseek() and ftell() to compute the size of a regular file"
>=20
> Coverity issue: 143454
> Fixes: a92a5a2cbbff ("app/testpmd: add command for loading DDP")
>=20
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>

Reviewed-by: Beilei Xing <beilei.xing@intel.com>