From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E287E7D30 for ; Tue, 22 Aug 2017 04:03:49 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Aug 2017 19:03:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,410,1498546800"; d="scan'208";a="1164904875" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 21 Aug 2017 19:03:48 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 21 Aug 2017 19:03:46 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 21 Aug 2017 19:03:46 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.128]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.236]) with mapi id 14.03.0319.002; Tue, 22 Aug 2017 10:03:44 +0800 From: "Xing, Beilei" To: "Mrzyglod, DanielX T" CC: "dev@dpdk.org" , "Mrzyglod, DanielX T" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: wrong usage of fseek & ftell to determine filesize Thread-Index: AQHTGC0h+jEveyZxhE+jTZBf8TmXVaKPpVZQ Date: Tue, 22 Aug 2017 02:03:43 +0000 Message-ID: <94479800C636CB44BD422CB454846E013200861D@SHSMSX101.ccr.corp.intel.com> References: <20170818141736.4769-1-danielx.t.mrzyglod@intel.com> In-Reply-To: <20170818141736.4769-1-danielx.t.mrzyglod@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: wrong usage of fseek & ftell to determine filesize X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Aug 2017 02:03:50 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Daniel Mrzyglod > Sent: Friday, August 18, 2017 10:18 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Mrzyglod, DanielX T > Subject: [dpdk-dev] [PATCH] app/testpmd: wrong usage of fseek & ftell to > determine filesize >=20 > This issue was about passing unsigned argument where should be signed > number. > In reality this is about wrong usage of fseek and ftell to determine file= size. > This patch is compliant to suggestions from FIO19-C: > "Do not use fseek() and ftell() to compute the size of a regular file" >=20 > Coverity issue: 143454 > Fixes: a92a5a2cbbff ("app/testpmd: add command for loading DDP") >=20 > Signed-off-by: Daniel Mrzyglod Acked-by: Beilei Xing