From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 043B32C01; Mon, 11 Sep 2017 04:45:37 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Sep 2017 19:45:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,375,1500966000"; d="scan'208";a="898973117" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 10 Sep 2017 19:45:36 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 10 Sep 2017 19:45:36 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 10 Sep 2017 19:45:36 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.168]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Mon, 11 Sep 2017 10:45:33 +0800 From: "Xing, Beilei" To: "Dai, Wei" , "Wu, Jingjing" CC: "dev@dpdk.org" , "Dai, Wei" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/i40e: fix mirror rule reset when port is stopped Thread-Index: AQHTKqUhIML9eohUV0SBVrKIlQXVDqKu+W7g Date: Mon, 11 Sep 2017 02:45:33 +0000 Message-ID: <94479800C636CB44BD422CB454846E013201ACB7@SHSMSX101.ccr.corp.intel.com> References: <1504709549-50804-1-git-send-email-wei.dai@intel.com> <1505095919-4682-1-git-send-email-wei.dai@intel.com> In-Reply-To: <1505095919-4682-1-git-send-email-wei.dai@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2QyOWU1YWMtNmQ0My00MWExLThhMmMtZDlmM2I1ZWExNmY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlpheGlNXC9hTHBtRUFtV0FJMGY0SDFPYWh0QnNIXC9DeFFGcnJ4bkZiZ1Q1WT0ifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix mirror rule reset when port is stopped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 02:45:38 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Dai > Sent: Monday, September 11, 2017 10:12 AM > To: Wu, Jingjing ; Xing, Beilei > > Cc: dev@dpdk.org; Dai, Wei ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix mirror rule reset when port = is > stopped >=20 > When an i40e PF port is stopped, all mirror rules should be removed. > All rule related software and hardware resources should also be removed. >=20 > Fixes: a4def5edf0fc ("i40e: enable port mirroring") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wei Dai > Tested-by: Lijuan Tu > --- > drivers/net/i40e/i40e_ethdev.c | 18 +++++++++++++++--- > 1 file changed, 15 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 5f26e24..a278748 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -2094,10 +2094,22 @@ i40e_dev_stop(struct rte_eth_dev *dev) >=20 > /* Remove all mirror rules */ > while ((p_mirror =3D TAILQ_FIRST(&pf->mirror_list))) { > - TAILQ_REMOVE(&pf->mirror_list, p_mirror, rules); > - rte_free(p_mirror); > + int ret; > + ret =3D i40e_aq_del_mirror_rule(hw, pf->main_vsi->veb->seid, > + p_mirror->rule_type, > + p_mirror->entries, > + p_mirror->num_entries, > + p_mirror->id); > + if (ret < 0) { > + PMD_DRV_LOG(ERR, "failed to remove mirror rule: " > + "status =3D %d, aq_err =3D %d.", ret, > + hw->aq.asq_last_status); > + } else { > + TAILQ_REMOVE(&pf->mirror_list, p_mirror, rules); > + rte_free(p_mirror); > + pf->nb_mirror_rule--; > + } little comment: else statement can be omitted here. > } > - pf->nb_mirror_rule =3D 0; >=20 > if (!rte_intr_allow_others(intr_handle)) > /* resume to the default handler */ > -- > 2.7.5