From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id D11271041 for ; Tue, 12 Sep 2017 05:00:15 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP; 11 Sep 2017 20:00:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,381,1500966000"; d="scan'208";a="150173813" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 11 Sep 2017 20:00:14 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 11 Sep 2017 20:00:13 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 11 Sep 2017 20:00:13 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.168]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.98]) with mapi id 14.03.0319.002; Tue, 12 Sep 2017 11:00:11 +0800 From: "Xing, Beilei" To: "David Harton (dharton)" , "Wu, Jingjing" CC: "dev@dpdk.org" Thread-Topic: [PATCH] i40e: fix i40e_validate_mac_addr to permit multicast addresses Thread-Index: AQHTG5UUv8AEvhUNYUe7J14Ww0kCqqKvQ3fQgABEWgCAASTcYA== Date: Tue, 12 Sep 2017 03:00:11 +0000 Message-ID: <94479800C636CB44BD422CB454846E013201B65E@SHSMSX101.ccr.corp.intel.com> References: <20170822222146.36912-1-dharton@cisco.com> <94479800C636CB44BD422CB454846E013201ADD6@SHSMSX101.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] i40e: fix i40e_validate_mac_addr to permit multicast addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2017 03:00:16 -0000 > -----Original Message----- > From: David Harton (dharton) [mailto:dharton@cisco.com] > Sent: Tuesday, September 12, 2017 1:23 AM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org > Subject: RE: [PATCH] i40e: fix i40e_validate_mac_addr to permit multicast > addresses >=20 > Hi Beilei, >=20 > > -----Original Message----- > > From: Xing, Beilei [mailto:beilei.xing@intel.com] > > > > Hi, > > > > > -----Original Message----- > > > From: David Harton [mailto:dharton@cisco.com] > > > > > > The i40e maintains a single MAC filter table for both unicast and > > > multicast addresses. The i40e_validate_mac_addr function was > > > preventing multicast addresses from being added to the table via > > > i40evf_add_mac_addr. Fixed the issue by removing the multicast > > > address check in i40e_validate_mac_addr. > > > > > > > Maybe fix line is needed here. >=20 > Please elaborate. If feel this is a regression and you want me to add a = fixline > can you offer the offending commit? I think these two commit are related: commit 4861cde4611601ccc9d467675f9d7a10c3095b54 commit 97ac72aa71a93d5c9bc5dc3ef1d1a324f38e61c8 >=20 > > > > > Signed-off-by: David Harton > > > --- > > > drivers/net/i40e/base/i40e_common.c | 12 +++++------- > > > drivers/net/i40e/i40e_ethdev.c | 3 ++- > > > 2 files changed, 7 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/net/i40e/base/i40e_common.c > > > b/drivers/net/i40e/base/i40e_common.c > > > index 900d379..9779854 100644 > > > --- a/drivers/net/i40e/base/i40e_common.c > > > +++ b/drivers/net/i40e/base/i40e_common.c > > > @@ -969,10 +969,10 @@ struct i40e_rx_ptype_decoded > > > i40e_ptype_lookup[] =3D { > > > > > > > > > /** > > > - * i40e_validate_mac_addr - Validate unicast MAC address > > > + * i40e_validate_mac_addr - Validate MAC address > > > * @mac_addr: pointer to MAC address > > > * > > > - * Tests a MAC address to ensure it is a valid Individual Address > > > + * Tests a MAC address to ensure it is a valid Address > > > **/ > > > enum i40e_status_code i40e_validate_mac_addr(u8 *mac_addr) { @@ - > > > 980,13 +980,11 @@ enum i40e_status_code i40e_validate_mac_addr(u8 > > > *mac_addr) > > > > > > DEBUGFUNC("i40e_validate_mac_addr"); > > > > > > - /* Broadcast addresses ARE multicast addresses > > > - * Make sure it is not a multicast address > > > + /* > > > * Reject the zero address > > > */ > > > - if (I40E_IS_MULTICAST(mac_addr) || > > > - (mac_addr[0] =3D=3D 0 && mac_addr[1] =3D=3D 0 && mac_addr[2] = =3D=3D 0 && > > > - mac_addr[3] =3D=3D 0 && mac_addr[4] =3D=3D 0 && mac_addr[5] = =3D=3D 0)) > > > + if (mac_addr[0] =3D=3D 0 && mac_addr[1] =3D=3D 0 && mac_addr[2] =3D= =3D 0 && > > > + mac_addr[3] =3D=3D 0 && mac_addr[4] =3D=3D 0 && mac_addr[5] =3D= =3D 0) > > > status =3D I40E_ERR_INVALID_MAC_ADDR; > > > > > > > We'd better not to change the base code which is from kernel driver. > > How about changing the i40evf_add_mac_addr function as following: > > - if (i40e_validate_mac_addr(addr->addr_bytes) !=3D I40E_SUCCESS) { > > + if (is_zero_ether_addr (addr->addr_bytes) !=3D I40E_SUCCESS) { > > > > Then following modification in eth_i40e_dev_init function can be remove= d. > > But we should also pay attention to other functions which call > > i40evf_add_mac_addr. >=20 > Sure. I'll post a new patch as suggested once the fixline question is an= swered. >=20 > I was trying to fix the issue the way I did in case i40e passthru wanted = to > benefit. Your suggestion will work for the VF as the only other caller f= or > i40evf_add_mac_addr() performs its own macaddr validation. >=20 > Thanks, > Dave >=20 > > > > Beilei > > > > > return status; > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > > b/drivers/net/i40e/i40e_ethdev.c index 5f26e24..00b6082 100644 > > > --- a/drivers/net/i40e/i40e_ethdev.c > > > +++ b/drivers/net/i40e/i40e_ethdev.c > > > @@ -1199,7 +1199,8 @@ eth_i40e_dev_init(struct rte_eth_dev *dev) > > > > > > /* Get and check the mac address */ > > > i40e_get_mac_addr(hw, hw->mac.addr); > > > - if (i40e_validate_mac_addr(hw->mac.addr) !=3D I40E_SUCCESS) { > > > + if (i40e_validate_mac_addr(hw->mac.addr) !=3D I40E_SUCCESS || > > > + I40E_IS_MULTICAST(hw->mac.addr)) { > > > PMD_INIT_LOG(ERR, "mac address is not valid"); > > > ret =3D -EIO; > > > goto err_get_mac_addr; > > > -- > > > 2.10.3.dirty