From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9B4D356A1 for ; Tue, 12 Sep 2017 08:44:10 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2017 23:44:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,382,1500966000"; d="scan'208";a="127862616" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 11 Sep 2017 23:44:07 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 11 Sep 2017 23:43:39 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 11 Sep 2017 23:43:34 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.168]) by shsmsx102.ccr.corp.intel.com ([169.254.2.39]) with mapi id 14.03.0319.002; Tue, 12 Sep 2017 14:40:50 +0800 From: "Xing, Beilei" To: Adrien Mazarguil CC: "Wu, Jingjing" , "Chilikin, Andrey" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 2/6] ethdev: add GTPC and GTPU items Thread-Index: AQHTJ8t6n9TTI9lzaEainQ5QUoWG4qKo0X+AgAf746A= Date: Tue, 12 Sep 2017 06:40:50 +0000 Message-ID: <94479800C636CB44BD422CB454846E013201B7A3@SHSMSX101.ccr.corp.intel.com> References: <1503647430-93905-2-git-send-email-beilei.xing@intel.com> <1504783263-20575-1-git-send-email-beilei.xing@intel.com> <1504783263-20575-3-git-send-email-beilei.xing@intel.com> <20170907121949.GI4301@6wind.com> In-Reply-To: <20170907121949.GI4301@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add GTPC and GTPU items X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2017 06:44:11 -0000 Hi Adrien, > -----Original Message----- > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] > Sent: Thursday, September 7, 2017 8:20 PM > To: Xing, Beilei > Cc: Wu, Jingjing ; Chilikin, Andrey > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add GTPC and GTPU items >=20 > Hi Beilei, >=20 > I assume this patch supersedes [1]? >=20 > [1] http://dpdk.org/ml/archives/dev/2017-August/073501.html >=20 > Thanks for merging testpmd and the API change as a single patch, I still = have > a few comments, see below. >=20 > (please add "flow API" somewhere in the title by the way) Thanks for all your comments. Yes, http://dpdk.org/ml/archives/dev/2017-August/073501.html is superseded = and did merging testpmd and API change. I will update title in next version. >=20 > On Thu, Sep 07, 2017 at 07:20:59PM +0800, Beilei Xing wrote: > > This patch adds GTPC and GTPU items to generic rte flow, and also > > exposes the following item fields through the flow command: > > > > - GTPC TEID > > - GTPU TEID > > > > Signed-off-by: Beilei Xing >=20 > Won't there be a need to match nonspecific GTP traffic as well (both GTP-= C > and GTP-U a once), since they use the same structure? >=20 > I'm not familiar with the protocol at all so I wonder if you should maybe= leave > the GTP item in addition to those two. >=20 Agree, I will leave the GTP item in next version. GTP-C and GTP-U use the same structure, the difference between them is UDP = port, 2123 is for GTP-C, and 2152 is for GTP-U. Add GTP-C and GTP -U item since I want to design a user-friendly CLI. For example, if user wants to add such flow: assign GTP-U packets with TEID= 0x123456 to queue 14.=20 Then use can use following CLI: flow create 0 ingress pattern eth / ipv4 / udp / gtpu teid is 0x123456 / en= d actions queue index 14 / end instead of below CLI to distinguish GTP-C and GTP-U with UDP port: flow create 0 ingress pattern eth / ipv4 / udp dst spec 2125 dst mask 0 / g= tp teid is 0x123456 / end actions queue index 14 / end And all your other comments will be addressed in next version, thanks. Beilei