From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id AB9DF1041 for ; Wed, 13 Sep 2017 04:43:25 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2017 19:43:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,385,1500966000"; d="scan'208";a="1171695863" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 12 Sep 2017 19:43:24 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 12 Sep 2017 19:43:24 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 12 Sep 2017 19:43:24 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.168]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.98]) with mapi id 14.03.0319.002; Wed, 13 Sep 2017 10:43:22 +0800 From: "Xing, Beilei" To: "David Harton (dharton)" , David Harton , "Wu, Jingjing" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2] i40e: fix i40evf_add_mac_addr to permit multicast addresses Thread-Index: AQHTK8dlHP9STQS7aUq2YCwwejJ4faKyFNZA//+AKQCAAIdXEA== Date: Wed, 13 Sep 2017 02:43:22 +0000 Message-ID: <94479800C636CB44BD422CB454846E013201C042@SHSMSX101.ccr.corp.intel.com> References: <20170822222146.36912-1-dharton@cisco.com> <20170912130210.18288-1-dharton@cpp-rtpbld-31.cpprtplab> <94479800C636CB44BD422CB454846E013201BD5A@SHSMSX101.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] i40e: fix i40evf_add_mac_addr to permit multicast addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Sep 2017 02:43:26 -0000 > -----Original Message----- > From: David Harton (dharton) [mailto:dharton@cisco.com] > Sent: Wednesday, September 13, 2017 10:38 AM > To: Xing, Beilei ; David Harton 31.cpprtplab>; Wu, Jingjing > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] i40e: fix i40evf_add_mac_addr to permit multicast > addresses >=20 > Hi Beilei, >=20 > > -----Original Message----- > > From: Xing, Beilei [mailto:beilei.xing@intel.com] > > > > Hi Harton, > > > > > -----Original Message----- > > > From: David Harton [mailto:dharton@cpp-rtpbld-31.cpprtplab] > > > > > > From: David Harton > > > > > > The i40e maintains a single MAC filter table for both unicast and > > > multicast addresses. The i40e_validate_mac_addr function was > > > preventing multicast addresses from being added to the table via > > > i40evf_add_mac_addr. Fixed the issue by adjusting the check in > > i40evf_add_mac_addr. > > > > > > Fixes: 4861cde46116 ("i40e: new poll mode driver") > > > Fixes: 97ac72aa71a9 ("i40e: support setting VF MAC address") > > > > > > Signed-off-by: David Harton > > > --- > > > > > > v2 > > > * Removed multicast check in i40evf_add_mac_addr. > > > > > > v1 > > > * Removed multicast check in i40e_validate_mac_addr. > > > > > > drivers/net/i40e/i40e_ethdev_vf.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > > > b/drivers/net/i40e/i40e_ethdev_vf.c > > > index f6d8293..5916d11 100644 > > > --- a/drivers/net/i40e/i40e_ethdev_vf.c > > > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > > > @@ -888,7 +888,7 @@ i40evf_add_mac_addr(struct rte_eth_dev *dev, > > > int err; > > > struct vf_cmd_info args; > > > > > > - if (i40e_validate_mac_addr(addr->addr_bytes) !=3D I40E_SUCCESS) { > > > + if (is_zero_ether_addr(addr) !=3D I40E_SUCCESS) { > > > > Thanks for the patch, there's some mistake with my last comment. >=20 > Actually, I think the logic above works but I do agree it is confusing bu= t I > wanted to use your suggestion to speed up the process. :) >=20 > > * @return > > * True (1) if the given ethernet address is filled with zeros; > > * false (0) otherwise. > > */ > > According to the comment of is_zero_ether_addr function, return value > > should be 0 or 1. > > So you should use if (!is_zero_ether_addr(addr)) here. >=20 > I don't think so. I think the logic that should be used is if > (is_zero_ether_addr(addr)) { because we want to report an error if the ad= dr > is all 0's. >=20 Yes, correct:) > Please let me know if you agree and I'll post this patch instead. >=20 > Thanks, > Dave >=20 > > > > > PMD_DRV_LOG(ERR, "Invalid mac:%x:%x:%x:%x:%x:%x", > > > addr->addr_bytes[0], addr->addr_bytes[1], > > > addr->addr_bytes[2], addr->addr_bytes[3], > > > -- > > > 2.10.3.dirty