From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4FE9F397D for ; Fri, 29 Sep 2017 15:24:49 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Sep 2017 06:24:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,452,1500966000"; d="scan'208";a="905104970" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 29 Sep 2017 06:24:48 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 29 Sep 2017 06:24:48 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.159]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Fri, 29 Sep 2017 21:24:46 +0800 From: "Xing, Beilei" To: "Wu, Jingjing" CC: "Chilikin, Andrey" , "dev@dpdk.org" Thread-Topic: [PATCH v6 2/8] net/i40e: update ptype and pctype info Thread-Index: AQHTOSYO9vph96mkN06BfVQ0SMpSb6LL2iYw Date: Fri, 29 Sep 2017 13:24:46 +0000 Message-ID: <94479800C636CB44BD422CB454846E013203901C@SHSMSX101.ccr.corp.intel.com> References: <1506565054-67690-1-git-send-email-beilei.xing@intel.com> <1506662342-18966-1-git-send-email-beilei.xing@intel.com> <1506662342-18966-3-git-send-email-beilei.xing@intel.com> <9BB6961774997848B5B42BEC655768F810E83DD8@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810E83DD8@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGRlZjE5OTktMGNiMi00ZjE4LWE4YzYtMGZmMTI5YmU3NzU5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkVRWnFkZm93YXA2Wm5ZaUFwXC93UVkxTkFZaVBCbWlEU2lQcFFqOEtaWnhrPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 2/8] net/i40e: update ptype and pctype info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Sep 2017 13:24:50 -0000 > -----Original Message----- > From: Wu, Jingjing > Sent: Friday, September 29, 2017 9:23 PM > To: Xing, Beilei > Cc: Chilikin, Andrey ; dev@dpdk.org > Subject: RE: [PATCH v6 2/8] net/i40e: update ptype and pctype info >=20 >=20 >=20 > > -----Original Message----- > > From: Xing, Beilei > > Sent: Friday, September 29, 2017 1:19 PM > > To: Wu, Jingjing > > Cc: Chilikin, Andrey ; dev@dpdk.org > > Subject: [PATCH v6 2/8] net/i40e: update ptype and pctype info > > > > Update new packet type and new pctype info when downloading profile. > > > > Signed-off-by: Beilei Xing >=20 > [......] >=20 >=20 > > + ret =3D rte_pmd_i40e_ptype_mapping_update(port_id, ptype_mapping, > > + ptype_num, 0); > > + if (ret) { > > + PMD_DRV_LOG(ERR, "Failed to update mapping table."); > > + rte_free(ptype_mapping); > > + rte_free(ptype); > > + return -1; > > + } > > + > > + rte_free(ptype_mapping); > > + rte_free(ptype); > > + return 0; >=20 > Minor comments, how about: > if (ret) > PMD_DRV_LOG(ERR, "Failed to update mapping table."); >=20 > rte_free(ptype_mapping); > rte_free(ptype); > return ret; >=20 Will update in next version. >=20 > Reviewed-by: Jingjing Wu