From: "Xing, Beilei" <beilei.xing@intel.com>
To: Igor Ryzhov <iryzhov@nfware.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] i40e: fix flag sent to mac_address_write
Date: Thu, 11 Jan 2018 08:12:02 +0000 [thread overview]
Message-ID: <94479800C636CB44BD422CB454846E013208AD12@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1515624018-12555-1-git-send-email-iryzhov@nfware.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Igor Ryzhov
> Sent: Thursday, January 11, 2018 6:40 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] i40e: fix flag sent to mac_address_write
Prefix with net/i40e:
>
> Use the same value as in Linux driver.
Fixes line is needed.
Thanks for the patch.
>
> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 285d92b..93b9dd0 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -10795,8 +10795,7 @@ static void i40e_set_default_mac_addr(struct
> rte_eth_dev *dev,
> return;
> }
>
> - /* Flags: 0x3 updates port address */
> - i40e_aq_mac_address_write(hw, 0x3, mac_addr->addr_bytes,
> NULL);
> + i40e_aq_mac_address_write(hw, I40E_AQC_WRITE_TYPE_LAA_WOL,
> +mac_addr->addr_bytes, NULL);
> }
>
> static int
> --
> 2.6.4
next prev parent reply other threads:[~2018-01-11 8:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 22:40 Igor Ryzhov
2018-01-11 8:12 ` Xing, Beilei [this message]
2018-01-11 10:07 ` [dpdk-dev] [PATCH v2] net/i40e: " Igor Ryzhov
2018-01-12 2:22 ` Xing, Beilei
2018-01-15 8:32 ` Igor Ryzhov
2018-01-15 8:32 ` [dpdk-dev] [PATCH v3] " Igor Ryzhov
2018-01-15 10:18 ` Xing, Beilei
2018-01-15 16:03 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94479800C636CB44BD422CB454846E013208AD12@SHSMSX101.ccr.corp.intel.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=iryzhov@nfware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).