From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id C83C83250; Mon, 15 Jan 2018 08:26:54 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2018 23:26:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,362,1511856000"; d="scan'208";a="195385623" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 14 Jan 2018 23:26:53 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 14 Jan 2018 23:26:53 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.159]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Mon, 15 Jan 2018 15:26:51 +0800 From: "Xing, Beilei" To: "Zhang, Qi Z" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/i40e: fix packet type parser issue Thread-Index: AQHTjOxyGo486E0/2ECMvLRDUQvsqqN0ilxQ Date: Mon, 15 Jan 2018 07:26:50 +0000 Message-ID: <94479800C636CB44BD422CB454846E013208C830@SHSMSX101.ccr.corp.intel.com> References: <1515665027-105293-1-git-send-email-beilei.xing@intel.com> <1515746494-86927-1-git-send-email-beilei.xing@intel.com> <039ED4275CED7440929022BC67E706115312D4B4@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E706115312D4B4@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix packet type parser issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 07:26:55 -0000 > -----Original Message----- > From: Zhang, Qi Z > Sent: Sunday, January 14, 2018 12:02 PM > To: Xing, Beilei > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH v2] net/i40e: fix packet type parser issue >=20 >=20 >=20 > > -----Original Message----- > > From: Xing, Beilei > > Sent: Friday, January 12, 2018 4:42 PM > > To: Zhang, Qi Z > > Cc: dev@dpdk.org; stable@dpdk.org > > Subject: [PATCH v2] net/i40e: fix packet type parser issue > > > > Ptype mapping table will fail to update when loading PPP profile, fix > > the issue via modifying metadata and adding check. > > This patch also adds parser for IPV4FRAG and IPV6FRAG. > > > > Fixes: ab2e350c4f4b ("net/i40e: improve packet type parser") > > Cc: stable@dpdk.org > > > > Signed-off-by: Beilei Xing > > --- > > > > v2 changes: > > - Add parser for IPV4FRAG and IPV6FRAG. > > > > drivers/net/i40e/i40e_ethdev.c | 44 > > ++++++++++++++++++++++++++--------------- > > drivers/net/i40e/rte_pmd_i40e.c | 6 ++++-- > > 2 files changed, 32 insertions(+), 18 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > b/drivers/net/i40e/i40e_ethdev.c index d80671a..69704e3 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -11283,43 +11283,55 @@ i40e_update_customized_ptype(struct > > rte_eth_dev *dev, uint8_t *pkg, > > continue; > > memset(name, 0, sizeof(name)); > > strcpy(name, proto[n].name); > > - if (!strncmp(name, "PPPOE", 5)) > > + if (!strncmp(name, "PPPoE", 5)) > > ptype_mapping[i].sw_ptype |=3D > > > RTE_PTYPE_L2_ETHER_PPPOE; > > - else if (!strncmp(name, "OIPV4", 5)) { > > + else if (!strncmp(name, "IPV4FRAG", 8) && > > + !in_tunnel) { > > ptype_mapping[i].sw_ptype |=3D > > > RTE_PTYPE_L3_IPV4_EXT_UNKNOWN; > > - in_tunnel =3D true; > > - } else if (!strncmp(name, "IPV4", 4) && > > - !in_tunnel) > > ptype_mapping[i].sw_ptype |=3D > > - > RTE_PTYPE_L3_IPV4_EXT_UNKNOWN; > > - else if (!strncmp(name, "IPV4FRAG", 8) && > > - in_tunnel) { > > + RTE_PTYPE_L4_FRAG; > > + } else if (!strncmp(name, "IPV4FRAG", 8) && > > + in_tunnel) { > > ptype_mapping[i].sw_ptype |=3D > > > RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN; > > ptype_mapping[i].sw_ptype |=3D > > RTE_PTYPE_INNER_L4_FRAG; > > } else if (!strncmp(name, "IPV4", 4) && > > + !in_tunnel) > > + ptype_mapping[i].sw_ptype |=3D > > + > RTE_PTYPE_L3_IPV4_EXT_UNKNOWN; > > + else if (!strncmp(name, "OIPV4", 5)) { > > + ptype_mapping[i].sw_ptype |=3D > > + > RTE_PTYPE_L3_IPV4_EXT_UNKNOWN; > > + in_tunnel =3D true; > > + } else if (!strncmp(name, "IPV4", 4) && > > in_tunnel) > Since you are doing some reordering here, it's better to move IPV4 && > in_tunnel case above OIPV4, to match IPV4 && !in_tunnel case. OK, will update in next version, thanks.