From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 576261B2C7 for ; Fri, 26 Jan 2018 05:57:37 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jan 2018 20:57:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,415,1511856000"; d="scan'208";a="198779417" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 25 Jan 2018 20:57:36 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 25 Jan 2018 20:57:36 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.192]) by shsmsx102.ccr.corp.intel.com ([169.254.2.124]) with mapi id 14.03.0319.002; Fri, 26 Jan 2018 12:57:34 +0800 From: "Xing, Beilei" To: Yong Wang CC: "dev@dpdk.org" Thread-Topic: [PATCH v4] net/i40e: add null point check and fix mem leak Thread-Index: AQHTlb5gIutnDft60kORJDZmdomBaaOFmJIQ Date: Fri, 26 Jan 2018 04:57:34 +0000 Message-ID: <94479800C636CB44BD422CB454846E01320A0356@SHSMSX101.ccr.corp.intel.com> References: <1516870864-12005-1-git-send-email-wang.yong19@zte.com.cn> In-Reply-To: <1516870864-12005-1-git-send-email-wang.yong19@zte.com.cn> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWYyYjIwNjYtODc1ZS00OTc1LWExOGYtZjJkZDQ3OWE3ZDdhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImRodnNmZ21BQWdJNGFQRG14NGZFQWk4Q3VJaHJiMVk3WWYzS0hcL1V3ejRzPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] net/i40e: add null point check and fix mem leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 04:57:37 -0000 > -----Original Message----- > From: Yong Wang [mailto:wang.yong19@zte.com.cn] > Sent: Thursday, January 25, 2018 5:01 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Yong Wang > Subject: [PATCH v4] net/i40e: add null point check and fix mem leak >=20 > There are several func calls to rte_zmalloc() which don't do null point c= heck > on the return value. And before return, the memory is not freed. Fix it b= y > adding null point check and rte_free(). >=20 > Fixes: 078259773da9 ("net/i40e: store ethertype filter") > Fixes: 425c3325f0b0 ("net/i40e: store tunnel filter") > Fixes: c50474f31efe ("net/i40e: support tunnel filter to VF") > Fixes: 5c53c82c8174 ("net/i40e: store flow director filter") >=20 > Signed-off-by: Yong Wang Acked-by: Beilei Xing