From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 5EC8E1DA4 for ; Tue, 22 May 2018 04:50:37 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2018 19:50:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,428,1520924400"; d="scan'208";a="43149832" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga008.jf.intel.com with ESMTP; 21 May 2018 19:50:35 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 21 May 2018 19:50:34 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 21 May 2018 19:50:34 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.40]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.210]) with mapi id 14.03.0319.002; Tue, 22 May 2018 10:50:33 +0800 From: "Xing, Beilei" To: "Zhang, Qi Z" , "Yigit, Ferruh" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/i40e: remove dependency on old rxmode flags Thread-Index: AQHT8WhfiM62NT8POESm7L/APcVf0KQ7DBXg Date: Tue, 22 May 2018 02:50:31 +0000 Message-ID: <94479800C636CB44BD422CB454846E0132160E54@SHSMSX101.ccr.corp.intel.com> References: <20180522010120.5187-1-qi.z.zhang@intel.com> In-Reply-To: <20180522010120.5187-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: remove dependency on old rxmode flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 02:50:38 -0000 > -----Original Message----- > From: Zhang, Qi Z > Sent: Tuesday, May 22, 2018 9:01 AM > To: Yigit, Ferruh > Cc: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > > Subject: [PATCH] net/i40e: remove dependency on old rxmode flags >=20 > Cleanup remain dependency on old rxmode flags since we move to new > offload APIs. >=20 > Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API") > Fixes: e0cb96204b71 ("net/i40e: add support for representor ports") >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++-- > drivers/net/i40e/i40e_vf_representor.c | 6 ++++-- > 2 files changed, 6 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h > b/drivers/net/i40e/i40e_rxtx_vec_common.h > index 3ffedcb9e..63cb17742 100644 > --- a/drivers/net/i40e/i40e_rxtx_vec_common.h > +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h > @@ -202,11 +202,11 @@ > i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev) > /* - no csum error report support > * - no header split support > */ > - if (rxmode->header_split =3D=3D 1) > + if (rxmode->offloads & DEV_RX_OFFLOAD_HEADER_SPLIT) > return -1; >=20 > /* no QinQ support */ > - if (rxmode->hw_vlan_extend =3D=3D 1) > + if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_EXTEND) > return -1; >=20 > return 0; > diff --git a/drivers/net/i40e/i40e_vf_representor.c > b/drivers/net/i40e/i40e_vf_representor.c > index 8dc94b479..f9f131611 100644 > --- a/drivers/net/i40e/i40e_vf_representor.c > +++ b/drivers/net/i40e/i40e_vf_representor.c > @@ -378,7 +378,8 @@ i40e_vf_representor_vlan_offload_set(struct > rte_eth_dev *ethdev, int mask) >=20 > if (mask & ETH_VLAN_FILTER_MASK) { > /* Enable or disable VLAN filtering offload */ > - if (ethdev->data->dev_conf.rxmode.hw_vlan_filter) > + if (ethdev->data->dev_conf.rxmode.offloads & > + DEV_RX_OFFLOAD_VLAN_FILTER) > return i40e_vsi_config_vlan_filter(vsi, TRUE); > else > return i40e_vsi_config_vlan_filter(vsi, FALSE); @@ - > 386,7 +387,8 @@ i40e_vf_representor_vlan_offload_set(struct rte_eth_dev > *ethdev, int mask) >=20 > if (mask & ETH_VLAN_STRIP_MASK) { > /* Enable or disable VLAN stripping offload */ > - if (ethdev->data->dev_conf.rxmode.hw_vlan_strip) > + if (ethdev->data->dev_conf.rxmode.offloads & > + DEV_RX_OFFLOAD_VLAN_STRIP) > return i40e_vsi_config_vlan_stripping(vsi, TRUE); > else > return i40e_vsi_config_vlan_stripping(vsi, FALSE); > -- > 2.13.6 Acked-by: Beilei Xing