From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E303AA49 for ; Thu, 28 Jun 2018 04:49:56 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2018 19:49:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,281,1526367600"; d="scan'208";a="62063112" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 27 Jun 2018 19:49:54 -0700 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Jun 2018 19:49:54 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 27 Jun 2018 19:49:54 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.82]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0319.002; Thu, 28 Jun 2018 10:49:52 +0800 From: "Xing, Beilei" To: David Harton , "Zhang, Qi Z" CC: "dev@dpdk.org" , "Zhang, Helin" Thread-Topic: [PATCH] net/i40e: remove memset in i40evf_dev_info_get Thread-Index: AQHUDn2QhBY9WHyp2ES3QXo+TayoOKR095vA Date: Thu, 28 Jun 2018 02:49:52 +0000 Message-ID: <94479800C636CB44BD422CB454846E01321D0531@SHSMSX101.ccr.corp.intel.com> References: <20180628011538.2974-1-dharton@cisco.com> In-Reply-To: <20180628011538.2974-1-dharton@cisco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: remove memset in i40evf_dev_info_get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jun 2018 02:49:57 -0000 Hi, Thanks for the patch, but there's another patch which has been accepted for= the issue. https://patches.dpdk.org/patch/40682/ Best Regards, Beilei > -----Original Message----- > From: David Harton [mailto:dharton@cisco.com] > Sent: Thursday, June 28, 2018 9:16 AM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; David Harton ; Zhang, Helin > > Subject: [PATCH] net/i40e: remove memset in i40evf_dev_info_get >=20 > i40evf_dev_info_get clears dev_info when data has already been set by the > calling function. Remove the call to > memset() to fix the problem. >=20 > Fixes: 4861cde46116 ("i40e: new poll mode driver") > Cc: helin.zhang@intel.com >=20 > Signed-off-by: David Harton > --- > drivers/net/i40e/i40e_ethdev_vf.c | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index 804e445..86b38d2 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -2182,7 +2182,6 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, > struct rte_eth_dev_info *dev_info) { > struct i40e_vf *vf =3D I40EVF_DEV_PRIVATE_TO_VF(dev->data- > >dev_private); >=20 > - memset(dev_info, 0, sizeof(*dev_info)); > dev_info->max_rx_queues =3D vf->vsi_res->num_queue_pairs; > dev_info->max_tx_queues =3D vf->vsi_res->num_queue_pairs; > dev_info->min_rx_bufsize =3D I40E_BUF_SIZE_MIN; > -- > 2.10.3.dirty