From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 65F0325D9 for ; Fri, 10 Aug 2018 04:31:35 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Aug 2018 19:31:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,217,1531810800"; d="scan'208";a="223458001" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga004.jf.intel.com with ESMTP; 09 Aug 2018 19:31:33 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 9 Aug 2018 19:31:33 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 9 Aug 2018 19:31:33 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.205]) by shsmsx102.ccr.corp.intel.com ([169.254.2.226]) with mapi id 14.03.0319.002; Fri, 10 Aug 2018 10:31:31 +0800 From: "Xing, Beilei" To: Thomas Monjalon CC: "dev@dpdk.org" , "Lu, Wenzhuo" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and FDIR Thread-Index: AQHULUkF21YKgo8dWkGzdBpD39YeMKSx75IAgAZXlIA= Date: Fri, 10 Aug 2018 02:31:30 +0000 Message-ID: <94479800C636CB44BD422CB454846E013220D55E@SHSMSX101.ccr.corp.intel.com> References: <1533534335-119817-1-git-send-email-beilei.xing@intel.com> <2252677.DSoj0ZM9iK@xps> In-Reply-To: <2252677.DSoj0ZM9iK@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and FDIR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 02:31:36 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, August 6, 2018 5:31 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Lu, Wenzhuo ; Wu, Jingjing > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and > FDIR >=20 > 06/08/2018 07:45, Beilei Xing: > > This patch adds bitmask support for RSS, FDIR and FDIR flexible > > payload. > > > > Signed-off-by: Beilei Xing >=20 > Flow director API is deprecated for almost 2 years: > http://git.dpdk.org/dpdk/commit/?id=3D7fdcde6 > We asked several times to stop using it in i40e. > It has not been listened. > We have even accepted a workaround in flow_filtering example for i40e: > http://git.dpdk.org/dpdk/commit/?id=3D9a93446 > We need to stop and move all to a common rte_flow API. >=20 > As a consequence, I will be against this patch. >=20 It's not for deprecated flow director API, it's mainly for i40e private API= rte_pmd_i40e_inset_set. This patch is an extend of: https://patches.dpdk.org/patch/33031/ Thanks, Beilei