From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 4375AC52C for ; Thu, 23 Jun 2016 15:39:22 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 23 Jun 2016 06:39:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,516,1459839600"; d="scan'208";a="981865209" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 23 Jun 2016 06:37:44 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 23 Jun 2016 06:37:44 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 23 Jun 2016 06:37:43 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.8]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.107]) with mapi id 14.03.0248.002; Thu, 23 Jun 2016 21:37:42 +0800 From: "Xing, Beilei" To: "Richardson, Bruce" , "Wu, Jingjing" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4] i40e: configure MTU Thread-Index: AQHRsqq8lFsCQxe6xEG+Z9QQkkR/kZ/FOtUAgBuOxoCAFbq+gIAAu0wA Date: Thu, 23 Jun 2016 13:37:42 +0000 Message-ID: <94479800C636CB44BD422CB454846E013A8264@SHSMSX101.ccr.corp.intel.com> References: <1463127333-10007-1-git-send-email-beilei.xing@intel.com> <1463757424-2010-1-git-send-email-beilei.xing@intel.com> <9BB6961774997848B5B42BEC655768F80E134394@SHSMSX103.ccr.corp.intel.com> <20160609142343.GC12520@bricha3-MOBL3> <20160623101333.GA5024@bricha3-MOBL3> In-Reply-To: <20160623101333.GA5024@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTYzMmFkODktNWRkYi00NWY4LTkzNTAtNDE4MjMxN2I3N2QwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiJacDhaR1h5bXNRb1o4a2Z0bm5KdWtDWEhYeGd1RU9rdUVibEQrckRiUnhFPSJ9 x-ctpclassification: CTP_PUBLIC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] i40e: configure MTU X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2016 13:39:22 -0000 Hi Bruce, > -----Original Message----- > From: Richardson, Bruce > Sent: Thursday, June 23, 2016 6:14 PM > To: Wu, Jingjing > Cc: Xing, Beilei ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] i40e: configure MTU >=20 > On Thu, Jun 09, 2016 at 03:23:43PM +0100, Bruce Richardson wrote: > > On Mon, May 23, 2016 at 01:33:42AM +0000, Wu, Jingjing wrote: > > > > > > > > > > -----Original Message----- > > > > From: Xing, Beilei > > > > Sent: Friday, May 20, 2016 11:17 PM > > > > To: Wu, Jingjing > > > > Cc: dev@dpdk.org; Xing, Beilei > > > > Subject: [PATCH v4] i40e: configure MTU > > > > > > > > This patch enables configuring MTU for i40e. > > > > Since changing MTU needs to reconfigure queue, stop port first > > > > before configuring MTU. > > > > > > > > Signed-off-by: Beilei Xing > > > > > > Acked-by: Jingjing Wu > > > > > Applied to dpdk-next-net/rel_16_07 > > > > /Bruce >=20 > It has been brought to my attention that there were still outstanding com= ments > and issues with v3 of the patch that were never resolved, therefore this = patch > may need to be reverted, as I should not have applied it >=20 > Maintainers, please do not ack patches for your components if there are s= till > unresolved discussion on them! Once the component maintainer acks a patch= I > should not have to go back through the whole patch history to determine i= f it can > be applied or not. >=20 Sorry for inconvenience. But here's one correction, this v4 patch is acked = and applied on May 23, but v3 comments are added June 17, I think Jingjing = always is a responsible maintainer :) > Regards, > /Bruce