From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6B0CD1B122; Tue, 23 Oct 2018 09:09:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2018 00:09:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,415,1534834800"; d="scan'208";a="274777660" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 23 Oct 2018 00:09:41 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 23 Oct 2018 00:09:41 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.46]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.21]) with mapi id 14.03.0319.002; Tue, 23 Oct 2018 15:09:38 +0800 From: "Xing, Beilei" To: "Ye, Xiaolong" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/i40e: cancel alarm handler at the end of device closure Thread-Index: AQHUamr2BiZ/5pJG60WacQ7MofCXTaUsab/w Date: Tue, 23 Oct 2018 07:09:37 +0000 Message-ID: <94479800C636CB44BD422CB454846E013CCF7AA4@SHSMSX101.ccr.corp.intel.com> References: <20181023005428.44547-1-xiaolong.ye@intel.com> In-Reply-To: <20181023005428.44547-1-xiaolong.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: cancel alarm handler at the end of device closure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 07:09:43 -0000 > -----Original Message----- > From: Ye, Xiaolong > Sent: Tuesday, October 23, 2018 8:54 AM > To: Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; Ye, Xiaolong ; stable@dpdk.org > Subject: [PATCH] net/i40e: cancel alarm handler at the end of device clos= ure >=20 > Some operations in i40evf_dev_close like i40evf_dev_promiscuous_disable > still need alarm handler to clear the pending cmd, if alarm handler is > canceled in early stage of i40evf_dev_close, i40evf_dev_promiscuous_disab= le > will result in failure. >=20 > Fixes: 864a800d706d ("net/i40e: remove VF interrupt handler") >=20 > Cc: stable@dpdk.org > Signed-off-by: Xiaolong Ye > --- > drivers/net/i40e/i40e_ethdev_vf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index baa6cc58f..52ae578d6 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -2249,7 +2249,6 @@ i40evf_dev_close(struct rte_eth_dev *dev) { > struct i40e_hw *hw =3D I40E_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); >=20 > - rte_eal_alarm_cancel(i40evf_dev_alarm_handler, dev); > i40evf_dev_stop(dev); > i40e_dev_free_queues(dev); > /* > @@ -2263,6 +2262,7 @@ i40evf_dev_close(struct rte_eth_dev *dev) > i40evf_reset_vf(hw); > i40e_shutdown_adminq(hw); > i40evf_disable_irq0(hw); > + rte_eal_alarm_cancel(i40evf_dev_alarm_handler, dev); > } >=20 > /* > -- > 2.17.1 Acked-by: Beilei Xing