From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8DB7A0471 for ; Mon, 15 Jul 2019 05:19:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 61977326C; Mon, 15 Jul 2019 05:19:46 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B75B92BBE; Mon, 15 Jul 2019 05:19:43 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jul 2019 20:19:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,492,1557212400"; d="scan'208";a="160966134" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga008.jf.intel.com with ESMTP; 14 Jul 2019 20:19:42 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 14 Jul 2019 20:19:42 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 14 Jul 2019 20:19:42 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.134]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.232]) with mapi id 14.03.0439.000; Mon, 15 Jul 2019 11:19:41 +0800 From: "Xing, Beilei" To: "Yang, Qiming" , "dev@dpdk.org" CC: "Yang, Qiming" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] net/ice: fix flow validation fail Thread-Index: AQHVOrTUjUIh8rA/ekeDj9sKv1f+SKbLArqQ Date: Mon, 15 Jul 2019 03:19:40 +0000 Message-ID: <94479800C636CB44BD422CB454846E013CE051D6@SHSMSX101.ccr.corp.intel.com> References: <20190709040812.4191-1-qiming.yang@intel.com> <20190715022356.73350-1-qiming.yang@intel.com> In-Reply-To: <20190715022356.73350-1-qiming.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/ice: fix flow validation fail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang > Sent: Monday, July 15, 2019 10:24 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v3] net/ice: fix flow validation fail >=20 > ice_flow_valid_attr will return zero on success and a negative value on e= rror. > Current return value check logical is opposite to the expected behavior. = This > patch fixed this issue. >=20 > Fixes: d76116a4678f ("net/ice: add generic flow API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qiming Yang > --- > drivers/net/ice/ice_generic_flow.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_generic_flow.c > b/drivers/net/ice/ice_generic_flow.c > index d5ff278..e6a2c4b 100644 > --- a/drivers/net/ice/ice_generic_flow.c > +++ b/drivers/net/ice/ice_generic_flow.c > @@ -549,7 +549,7 @@ static int ice_flow_valid_action(struct rte_eth_dev > *dev, > rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, > actions, "Invalid queue ID for" > - " ethertype_filter."); > + " switch filter."); > return -rte_errno; > } > break; > @@ -596,7 +596,7 @@ ice_flow_validate(struct rte_eth_dev *dev, > } >=20 > ret =3D ice_flow_valid_attr(attr, error); > - if (!ret) > + if (ret) > return ret; >=20 > inset =3D ice_flow_valid_pattern(pattern, error); > -- > 2.7.4 Acked-by: Beilei Xing