From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F025BA0613 for ; Wed, 25 Sep 2019 07:20:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E5542BD5; Wed, 25 Sep 2019 07:20:49 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 77DC12BCE for ; Wed, 25 Sep 2019 07:20:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2019 22:20:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,546,1559545200"; d="scan'208";a="213929201" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 24 Sep 2019 22:20:46 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Sep 2019 22:20:46 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 24 Sep 2019 22:20:46 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.92]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.195]) with mapi id 14.03.0439.000; Wed, 25 Sep 2019 13:20:44 +0800 From: "Xing, Beilei" To: "Gavin Hu (Arm Technology China)" , "Cao, Yahui" , "Yang, Qiming" , "Lu, Wenzhuo" CC: "dev@dpdk.org" , "Zhang, Qi Z" , "Ye, Xiaolong" , nd Thread-Topic: [dpdk-dev] [PATCH v3 1/8] net/ice: enable flow director engine Thread-Index: AQHVcuGMrF5C9SNBZUWb73snPEfwKKc7NFSAgACnpJA= Date: Wed, 25 Sep 2019 05:20:44 +0000 Message-ID: <94479800C636CB44BD422CB454846E013CE48464@SHSMSX101.ccr.corp.intel.com> References: <20190924215243.81474-1-yahui.cao@intel.com> <20190924215243.81474-2-yahui.cao@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDI1YjczZDUtNDliMy00M2JjLThhODItZDg1Yjk2YTY2YzFiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRlJydHRmcW8wd0NIeGRRdHBKTGtwVTlvck5iblwvZTZSMWIwTXU5eG13TGVzcWhZVDhDYjVkclMyRVBnajNlUjgifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/ice: enable flow director engine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Gavin Hu (Arm Technology China) [mailto:Gavin.Hu@arm.com] > Sent: Wednesday, September 25, 2019 11:20 AM > To: Cao, Yahui ; Yang, Qiming > ; Lu, Wenzhuo > Cc: dev@dpdk.org; Zhang, Qi Z ; Ye, Xiaolong > ; Xing, Beilei ; nd > > Subject: RE: [dpdk-dev] [PATCH v3 1/8] net/ice: enable flow director engi= ne >=20 > Hi Yahui, >=20 > two general comments: > 1.Please make old versions of patches Superseded to facilitate review. > 2. the two occurrences of rte_wmb can be removed, a similar patch has > been reviewed by Qi. http://patches.dpdk.org/patch/59278/ Thanks for the comments, will be updated in v4. Beilei >=20 > /Gavin >=20 > > -----Original Message----- > > From: dev On Behalf Of Yahui Cao > > Sent: Wednesday, September 25, 2019 5:53 AM > > To: Qiming Yang ; Wenzhuo Lu > > > > Cc: dev@dpdk.org; Qi Zhang ; Xiaolong Ye > > ; Beilei Xing ; Yahui > > Cao > > Subject: [dpdk-dev] [PATCH v3 1/8] net/ice: enable flow director > > engine > > > > From: Beilei Xing > > > > Enable flow director engine, including initialization and teardown. > > - Control VSI create and release. > > - Queue pair allocated, set up and release. > > - Programming packet create and release. > > - FDIR profile create and release. > > > > Signed-off-by: Beilei Xing > > ---