From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id DAE7F2C7A for ; Fri, 5 Dec 2014 15:53:01 +0100 (CET) Received: by mail-wg0-f52.google.com with SMTP id a1so1087743wgh.25 for ; Fri, 05 Dec 2014 06:53:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=GnQBdS7qq+g2pyqPKQxkeKQK2VpIx+biyUeSTTGKZ6s=; b=Dt2m+767S9PwnxOCuEOZ0LgcXxmW4hyCfEHGRpoK6oPxDkQ2prQNiQ3MDXesHJ7BZX gTtal79TaqbVExFrWdmGzXvTTNTjV1By6rA8S0UKNxzR4NhjRYBm+ldvF+FA2VBYcGfv 2pYiveNE1D1xqh3lKTQDHfNYf7uylbAtNu0fhIcwSl4nE4wHpfPafxMjF2o56FSKZEA5 TuzZkveS+AZ18soSNQ3mYUp+I9vheDXsWGsx6IzSz6+msriG4XNBBQZhakp32aDnw/Ce Kh4js7lXWn15kZuLrCGzOMiwAIf03LWoW08zY4ZOhDItDus+V5NIpQ7VxvjJih1+xAxc XapA== X-Gm-Message-State: ALoCoQkod8ZKsue8uxIDdo9bzWxI0bteJGVmTT3wGOSlneDA6uyCF1cg5oDroh45RK7AznGsjwXW X-Received: by 10.180.8.202 with SMTP id t10mr4802825wia.15.1417791181345; Fri, 05 Dec 2014 06:53:01 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id j2sm45200375wjs.28.2014.12.05.06.53.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Dec 2014 06:53:00 -0800 (PST) From: Thomas Monjalon To: Neil Horman Date: Fri, 05 Dec 2014 15:52:36 +0100 Message-ID: <94521173.H6dyulnjbO@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <20141205144200.GC29245@hmsreliant.think-freely.org> References: <1417688048-23076-1-git-send-email-chaozhu@linux.vnet.ibm.com> <1585880.VN9dgqiZzk@xps13> <20141205144200.GC29245@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Fix KNI compiling issue on IBM Power X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Dec 2014 14:53:02 -0000 2014-12-05 09:42, Neil Horman: > On Fri, Dec 05, 2014 at 02:10:27PM +0100, Thomas Monjalon wrote: > > 2014-12-04 15:05, Neil Horman: > > > On Thu, Dec 04, 2014 at 04:59:59PM +0100, Thomas Monjalon wrote: > > > > I'm convinced we need to work on the build system but it's anot= her discussion > > > > for next weeks. Speaking about that, the AF_PACKET PMD cannot b= e enabled because > > > > dependencies are not checked before building it. > > > >=20 > > > I'm fine with that. If we're going to make the build system cont= ain a depedency > > > checking mechanism, we'll start dynamically enabling them when su= pport is > > > detected. Until then I'm fine with it being an opt in operation,= as you know at > > > build time what you're minimum kernel support levels are. > > >=20 > > > Speaking of enabling however, be careful of a double standard her= e. I know that > > > igb_uio won't build on some kernels either (linvlle posted in the= > > > irc channel about it earlier), because we don't detect the presen= ce of needed > > > defines. Yet IGB_UIO is still universally enabled... > >=20 > > I'm really surprised. Please post an email to report the problem. > > To my knowledge, igb_uio build on every supported Linux distributio= ns > > (kernel >=3D 2.6.32). > >=20 >=20 > From the IRC session: >=20 > linville CC [M] > /home/linville/git/dpdk/build/build/lib/librte_eal/linuxapp/igb_uio/i= gb_uio.o > linville > /home/linville/git/dpdk/build/build/lib/librte_eal/linuxapp/igb_uio/i= gb_uio.c: > In function =E2=80=98store_max_vfs=E2=80=99: > linville > /home/linville/git/dpdk/build/build/lib/librte_eal/linuxapp/igb_uio/i= gb_uio.c:86:2: > error: implicit declaration of function =E2=80=98strict_strtoul=E2=80= =99 > [-Werror=3Dimplicit-function-declaration] > linville if (0 !=3D strict_strtoul(buf, 0, &max_vfs)) > linville ^ Yes, this issue is being fixed. Jincheng Miao should send a v3: =09http://dpdk.org/ml/archives/dev/2014-December/009182.html > linville > /home/linville/git/dpdk/build/build/lib/librte_eal/linuxapp/igb_uio/i= gb_uio.c: > In function =E2=80=98igbuio_dom0_mmap_phys=E2=80=99: > linville > /home/linville/git/dpdk/build/build/lib/librte_eal/linuxapp/igb_uio/i= gb_uio.c:290:30: > error: =E2=80=98_PAGE_IOMAP=E2=80=99 undeclared (first use in this fu= nction) > linville vma->vm_page_prot.pgprot |=3D _PAGE_IOMAP; > linville ^ Xen is disabled by default. So this issue hasn't been raised yet. Fixes are welcome. > linville > /home/linville/git/dpdk/build/build/lib/librte_eal/linuxapp/igb_uio/i= gb_uio.c:290:30: > note: each undeclared identifier is reported only once for each funct= ion it > appears in > linville cc1: all warnings being treated as errors > linville does igb_uio only work with certain old kernels? > linville I'm running 3.18-rc7 There are some bugs. Thanks for reporting (it would more visible in another thread). --=20 Thomas