Re: [dpdk-dev] [PATCH v2 0/6] Remove RTE_ETH_DEV_DETACHABLE

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 10/24/2017 3:35 AM, Gaetan Rivet wrote:
> This flag was deprecated in the previous release, and this is its removal.

This change was in wait list, but it would be much more better if not received
just before rc2, but in early stages in the release, at worst before rc1.

Although patch looks good to me, getting ethdev layer update in rc2 is creating
some stress.

> We are going from an explicit support of device detach, to an implicit one,
> with specific checks in place for PMDs not supporting the feature.

Removing this flag implies all ethdev devices are detachable, right.
That is why you need to update error value handling in pci hotplug code, and
return error in nfp remove path, since there is no way to say not detachable.

> 
> Attempting to Cc all relevant maintainers:
> 
> Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Cc: Alejandro Lucero <alejandro.lucero@netronome.com>
> Cc: Beilei Xing <beilei.xing@intel.com>
> Cc: Bruce Richardson <bruce.richardson@intel.com>
> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> Cc: Declan Doherty <declan.doherty@intel.com>
> Cc: Ferruh Yigit <ferruh.yigit@intel.com>
> Cc: Jing Chen <jing.d.chen@intel.com>
> Cc: John Miller <john.miller@atomicrules.com>
> Cc: John W. Linville <linville@tuxdriver.com>
> Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Cc: Matt Peters <matt.peters@windriver.com>
> Cc: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> Cc: Pascal Mazon <pascal.mazon@6wind.com>
> Cc: Shrikrishna Khare <skhare@vmware.com>
> Cc: Srisivasubramanian Srinivasan <ssrinivasan@cavium.com>
> Cc: Tetsuya Mukawa <mtetsuyah@gmail.com>
> Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Cc: Yongseok Koh <yskoh@mellanox.com>
> 
> Sorry for any undue ML traffic going your way if you are not interested
> in this series.
> 
> I'd like to highlight Alejandro Lucero for the NFP PMD, as the patch is
> somewhat more involved for this PMD and I don't have the hardware available
> to validate the change.

Let's give one more day to Alejandro to comment on NFP update.

And others to comment on overall, if there is no objection include this into rc2.

> 
> v2:
> 
>   + Split ether patch:
>     First remove the use of the flag, then remove the flag
> 
>   + Restore RTE_ETH_DEV_BONDED_SLAVE check,
>     previously hastily removed along the DETACHABLE one.
> 
>   + Added release note, removed deprecation notice
> 
> Gaetan Rivet (6):
>   ethdev: do not rely on detachable flag in detach
>   ethdev: remove detachable device flag
>   pci: propagate PMD removal error value for unplug
>   doc: follow detachable flag disappearance
>   doc: update detachable flag deprecation notice
>   doc: note ether API change for detachable flag

<...>