From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 7190A2BA8 for ; Fri, 18 Mar 2016 09:10:35 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id p65so25683459wmp.0 for ; Fri, 18 Mar 2016 01:10:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=K9L0kfh+hBD/0NdQLS7eHD+JoZRNUpVa3sf3mc70r9U=; b=Y8TZynilY799LczkJ5hb+1mitov6wmCvNn7rBHHtFTKX4P8tHYpBakbwS7EJZSbJBI ub/nHJHaA2Nc6bwCsghmPAkmBF8YpYWH8ZogDe+E/MdDLpl3oIClz6V6jjnAKUq10IRy dS3ltvVINGrsMaDOHNTzRr56vvpvC26zEneHXgh1WL7vYSTspwFAOYdBjRWzEFh7VhPF /gPXca2a2qC4x5Ywi6rJi51iM5OR4ahSGIayhVypEg6AMaXQ1fnmmtVjtJZqKFKA3Gk7 v/9P2y2AuwEkI4rjMvf4KVM/XqhEcVDapcaDXpms9WufmfJu+/ueJb4bQ+W8jDu2HHB1 uQrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=K9L0kfh+hBD/0NdQLS7eHD+JoZRNUpVa3sf3mc70r9U=; b=OHmagMZwKnHsQJxlroCk6xjh6hY5q7onxDXX5192EDqjUo0csWwIoQby3rRzdhqYKT o/X+QkrriPsjFulLlyEPol07wOsOECYQXfgU2NIiPlIXRR7wLWSYnF6+Lfw15ccniTp/ XETLVy9gkx9rCW+1iuCklQZx1UlPG88Qpuj41CzNof/gRvEgeuLcc0ycdb20YLQfrP02 KAWk8SsBunIptIDnykEp4GdUTilUkCV3WcIn61s9Sp/itZJr4GagMUfcGL248lTUgQwI TtixihgM2moiq7eZMJsR9eC8m8V6dQcxQbPs2KqzdYq/5x/GGrXgX80KSToohiXJLdVD cqWw== X-Gm-Message-State: AD7BkJJpZQtSV+eB28tYohk61GmwtBWqhDIPmPSnGiXH9TWb7Sqw5ual3tgVWffgNUB5YhcN X-Received: by 10.28.238.210 with SMTP id j79mr15763918wmi.23.1458288635340; Fri, 18 Mar 2016 01:10:35 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id hq2sm11123631wjb.3.2016.03.18.01.10.34 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 18 Mar 2016 01:10:34 -0700 (PDT) From: Thomas Monjalon To: Yuanhan Liu Cc: Ilya Maximets , Huawei Xie , bruce.richardson@intel.com, dev@dpdk.org, Dyasly Sergey , Jerin Jacob , Jianbo Liu , Tetsuya Mukawa Date: Fri, 18 Mar 2016 09:09:04 +0100 Message-ID: <9470086.ZYvecjaNVJ@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160318080035.GS979@yliu-dev.sh.intel.com> References: <1456314438-4021-1-git-send-email-i.maximets@samsung.com> <10269895.UfVQWhbqLk@xps13> <20160318080035.GS979@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH RFC v3 0/3] Thread safe rte_vhost_enqueue_burst(). X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2016 08:10:35 -0000 2016-03-18 16:00, Yuanhan Liu: > On Thu, Mar 17, 2016 at 04:29:32PM +0100, Thomas Monjalon wrote: > > 2016-02-24 14:47, Ilya Maximets: > > > Implementation of rte_vhost_enqueue_burst() based on lockless ring-buffer > > > algorithm and contains almost all to be thread-safe, but it's not. > > > > > > This set adds required changes. > > > > > > First patch in set is a standalone patch that fixes many times discussed > > > issue with barriers on different architectures. > > > > > > Second and third adds fixes to make rte_vhost_enqueue_burst thread safe. > > > > My understanding is that we do not want to pollute Rx/Tx with locks. > > > > Huawei, Yuanhan, Bruce, do you confirm? > > Huawei would like to do that, and I'm behind that. Let's do it. I'm not sure to understand. What do you want to do exactly? > The question is can we do that in this release? As I replied in another > thread, I'm wondering we might need do an announce first and do it > in next release? > > Both are Okay to me; I just want to know which one is more proper. > > Thoughts?