From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 85CDEA0A0E;
Mon, 10 May 2021 16:13:43 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id F094440140;
Mon, 10 May 2021 16:13:42 +0200 (CEST)
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
[64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 64C884003E
for <dev@dpdk.org>; Mon, 10 May 2021 16:13:41 +0200 (CEST)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
by mailout.west.internal (Postfix) with ESMTP id B8657F92;
Mon, 10 May 2021 10:13:39 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute4.internal (MEProxy); Mon, 10 May 2021 10:13:40 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm1; bh=
40B3bSYL5HX9TWA4ORQ78P6BHwEi7V+Y4+M2OCfmgS8=; b=fSKoETJ2OJkxlE7H
6qwdUhVi2QE8DuSJB5IS1iGe+lxHOn7jpiEN4rMWz7RIPNH90YUc6rKYsfuuMmnL
LPSECGGP9yirKSHv39GIDvlAbB/e1Zk2IcR8uCJkFmTosDugdul/ZpMhsjtUaWWG
aalMP50iSMOuBGTqzeeYGig7W5Vy+z/jlRCfXVJRpGEvuvzKTOFTpGTUdnHUos+B
2KIAhhjkdGuvkxLbOXrodpppDOSXou3VtErcwqa3BNZNNpHLEsKQhJBXZpSPTy/B
KCQAqqCkGrcCleFZKdWt5La415czhH0C/K0EncrE9L+gsV8OSVW6ZbLh92wqUfIT
hYlXTw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=40B3bSYL5HX9TWA4ORQ78P6BHwEi7V+Y4+M2OCfmg
S8=; b=UC6Xex95C7R/Tlk26DrIqzXac966O/a5GGp6Rk9NFbtPfo6dqGZaE95y+
hyunTrpoBhY32OD0R7hRyhXy9A+6pDz3BSK4QekOjtiOmGGLCBFOYjkDiHamL8Z1
ff6+hz0A+JNFpj3tlYUte1dkmPNAAGKXlvnCAuWz/L0WnRqrCGLeN2vLPRCZgzaJ
45ICf0g7T6WHWuXdz9YfD+4mMuDvqqE3CkRzpf+b5sf72QqD82UkCgNxFo2jTWLk
FaeJPJwttU6yIqhznENavM//PCDSp/cnhyYPVViKhQ+hnbkeg333EJ/xcBxgYdsR
iFXi3uOACanYvdVBBf8BwqYRb6pCA==
X-ME-Sender: <xms:kj-ZYBjWs5ZfywBHOUCNmAdsC39PnRmBnWYONx5chf_ZNMl0843mFw>
<xme:kj-ZYGDUATMWBOMiG0YsRxges0Y_eQI0BbEF6ju4OjCKpbQpTlbAMENOTKuonFAnn
adqF5B4cD8962-b6A>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdegkedgjeegucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
ohhnrdhnvght
X-ME-Proxy: <xmx:kj-ZYBEFdlw2Xdv-gxH3jme1r16mGjSOCNU0I9p0RONkWxMios2NHQ>
<xmx:kj-ZYGTaXBWrxf5lJ4nqX8SXNjfa0j_KAxJnM-iB1pEVn5gKSi8I7w>
<xmx:kj-ZYOyYMs0RTttk03EerLYvTTAjT-ZYSozAr42P3AmBDaZBQdJuow>
<xmx:kz-ZYJ9XZ0ssD4vJjO5Oqc4rXAvYGN6qQaaN03uW2pvFEdFljVNOdA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA;
Mon, 10 May 2021 10:13:37 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, erik.g.carrillo@intel.com,
rsanford@akamai.com
Date: Mon, 10 May 2021 16:13:35 +0200
Message-ID: <9479806.yrmItbF8Ka@thomas>
In-Reply-To: <1620090469-30484-1-git-send-email-humin29@huawei.com>
References: <1619083120-57343-1-git-send-email-humin29@huawei.com>
<1620090469-30484-1-git-send-email-humin29@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] test/timer: fix memzone reserve failure
check
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
04/05/2021 03:07, Min Hu (Connor):
> Segmentation fault may occur without checking if memzone
> reserves succeed or not.
The sentence is confusing. Please try to make it more logical.
Something like "It was potentially dereferencing a null pointer.
It is fixed by checking the pointer before dereferencing."
>
> This patch fixed it.
>
> Fixes: 50247fe03fe0 ("test/timer: exercise new APIs in secondary process")
> Cc: stable@dpdk.org
>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
[...]
> - test_info = mz->addr;
> - TEST_ASSERT_NOT_NULL(test_info, "Couldn't allocate memory for "
> + TEST_ASSERT_NOT_NULL(mz, "Couldn't allocate memory for "
> "test data");
Error messages should not be split. I makes search difficult.
Please fix it in this patch while touching this line.