From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59682A0518; Fri, 24 Jul 2020 05:57:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D9BEA1D5F5; Fri, 24 Jul 2020 05:57:57 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 8D8D61D451; Fri, 24 Jul 2020 05:57:55 +0200 (CEST) IronPort-SDR: lTW6YKg6Q3+614ydFH3CGbSHfWWnAK1TAhsYtPtQiVybGN+LDVGw4yNy5U4Vq2svCV2MWuRKLT wHwS6kmklIWQ== X-IronPort-AV: E=McAfee;i="6000,8403,9691"; a="168787021" X-IronPort-AV: E=Sophos;i="5.75,389,1589266800"; d="scan'208";a="168787021" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2020 20:57:54 -0700 IronPort-SDR: f4uMpoRSROpnCxlpudln49y3+EyXktTTUcd9KAawYl1+oFAXDh33JYAMDTOwDZfOwQqoPzgXdY UWWXH0fcs9PQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,389,1589266800"; d="scan'208";a="302541241" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.150]) ([10.67.68.150]) by orsmga002.jf.intel.com with ESMTP; 23 Jul 2020 20:57:53 -0700 To: Shougang Wang , dev@dpdk.org Cc: beilei.xing@intel.com, stable@dpdk.org References: <20200715063515.9262-1-shougangx.wang@intel.com> <20200724024712.10727-1-shougangx.wang@intel.com> From: Jeff Guo Message-ID: <9481f69e-d83f-64cf-cfa0-4f740b64f0e8@intel.com> Date: Fri, 24 Jul 2020 11:57:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200724024712.10727-1-shougangx.wang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v4] net/i40e: fix incorrect hash look up table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" hi, shougang On 7/24/2020 10:47 AM, Shougang Wang wrote: > The hash look up table (LUT) is managed by global register but it is not > initialized when RSS is disabled. Once user wants to enable RSS during > runtime, the LUT will not be initialized. > This patch fixes the issue by initializing the LUT whether RSS enabled > or not. "whatever" but not "whether"? > > Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS flow") > Cc: stable@dpdk.org > > Signed-off-by: Shougang Wang > --- > v4: > -Updated code. > --- > drivers/net/i40e/i40e_ethdev.c | 15 ++++----------- > 1 file changed, 4 insertions(+), 11 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index 05d5f2861..0a3f5e3c1 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -8985,6 +8985,7 @@ static int > i40e_pf_config_rss(struct i40e_pf *pf) > { > struct i40e_hw *hw = I40E_PF_TO_HW(pf); > + enum rte_eth_rx_mq_mode mq_mode = pf->dev_data->dev_conf.rxmode.mq_mode; > struct rte_eth_rss_conf rss_conf; > uint32_t i, lut = 0; > uint16_t j, num; > @@ -9022,7 +9023,8 @@ i40e_pf_config_rss(struct i40e_pf *pf) > } > > rss_conf = pf->dev_data->dev_conf.rx_adv_conf.rss_conf; > - if ((rss_conf.rss_hf & pf->adapter->flow_types_mask) == 0) { > + if ((rss_conf.rss_hf & pf->adapter->flow_types_mask) == 0 || > + !(mq_mode & ETH_MQ_RX_RSS_FLAG)) { > i40e_pf_disable_rss(pf); > return 0; > } > @@ -9198,16 +9200,7 @@ i40e_tunnel_filter_handle(struct rte_eth_dev *dev, > static int > i40e_pf_config_mq_rx(struct i40e_pf *pf) This function is still need or could it be replace by i40e_pf_config_rss? > { > - int ret = 0; > - enum rte_eth_rx_mq_mode mq_mode = pf->dev_data->dev_conf.rxmode.mq_mode; > - > - /* RSS setup */ > - if (mq_mode & ETH_MQ_RX_RSS_FLAG) > - ret = i40e_pf_config_rss(pf); > - else > - i40e_pf_disable_rss(pf); > - > - return ret; > + return i40e_pf_config_rss(pf); > } > > /* Get the symmetric hash enable configurations per port */