From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 8FBBD1B1EC for ; Wed, 20 Mar 2019 17:01:28 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EF4BA22BCB; Wed, 20 Mar 2019 12:01:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 20 Mar 2019 12:01:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=eYPIP3wtkcff/4asJ5geDrbtjKJLrmvDJEqfI9D3hV8=; b=qKV8R7/4+N2X V0cn3+irIO7UNG3JxepZoPbLOkEhVwiR6px8T+etqb8BE98srm2l8oT/Rqbo2hSG lNhXq8oDhZdViLRIV02MqENxG8jkS0sgvZU4xfWqWeHARfJ6lzw4RT3fNe8TT0Cd X6v8ZWAyammWcAt2p/NzHO31qvb7gRM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=eYPIP3wtkcff/4asJ5geDrbtjKJLrmvDJEqfI9D3h V8=; b=VJVyugfqSwCZwaljtJBa7y34r6mTD1xSKl2Rz6VM1N1n2TdTUR7fT1+8s MBaDMuAZOZzTh5I3GOUBMk2d/g76/2Ed3YXPz/SroZD7GuxCoxxvMBp0+tKAJvDr PecV8GO/Erzayvf/6gExrGJtqXbgKnrOYnCM6cVaVLAQ2iWbqbUIL774HV0kssJ6 LQ0M4XcCbeGFVrM0HgC6N3PcR5MyTx/mh9ZbvRRRBlxqL6kLjKv2H+hinDQ4P3lP /eAo0yd9AMNVDOzi579+Tkie4YJSMoFQmlbUV9M+4DI6KtkUAQ5WBIG6y8wE9Ols J1p2WUOfbHQrCBz87QgYxfLswTGwA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrieeigdekfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepshgrnhhtrghnrgdrtghipddvuddrtghinecukfhppeejjedrudefgedrvddt fedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlh honhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F00F3E4980; Wed, 20 Mar 2019 12:01:25 -0400 (EDT) From: Thomas Monjalon To: Michael Santana , Aaron Conole Cc: dev@dpdk.org, Bruce Richardson , Honnappa Nagarahalli Date: Wed, 20 Mar 2019 17:01:24 +0100 Message-ID: <9486436.3HrUK5duha@xps> In-Reply-To: <20190304161232.5670-2-msantana@redhat.com> References: <20190207220114.8020-1-msantana@redhat.com> <20190304161232.5670-1-msantana@redhat.com> <20190304161232.5670-2-msantana@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 1/1] ci: Introduce travis builds for github repositories X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Mar 2019 16:01:28 -0000 Hi, 04/03/2019 17:12, Michael Santana: > .ci/linux-build.sh | 21 +++++++++ > .ci/linux-setup.sh | 3 ++ > .travis.yml | 73 +++++++++++++++++++++++++++++ Please, could you explain somewhere what is the relationship between these files? What is specific to Travis? What is specific to GitHub? May we add "travis-" as filename prefix of the scripts? Or rename .ci to .travis? > +++ b/.ci/linux-build.sh > @@ -0,0 +1,21 @@ > +#!/bin/bash -xe If possible, I would prefer a simple /bin/sh. > +function on_error() { > + FILES_TO_PRINT=( "build/meson-logs/testlog.txt" "build/.ninja_log" "build/meson-logs/meson-log.txt") > + > + for pr_file in "${FILES_TO_PRINT[@]}"; do You can make FILES_TO_PRINT as a simple word list, and so avoid bashism. [...] > +if [ "${AARCH64}" == "1" ]; then Please explain in the comment where this variable comes from. I suggest renaming it to ARMV8 as this is what it is translated to: > + # convert the arch specifier > + OPTS="${OPTS} -DRTE_ARCH_64=1 --cross-file config/arm/arm64_armv8_linuxapp_gcc" I think -DRTE_ARCH_64=1 is useless. > +fi > + > +OPTS="$OPTS --default-library=$DEF_LIB" > +meson build --werror -Dexamples=all ${OPTS} > +ninja -C build [...] > --- /dev/null > +++ b/.travis.yml > @@ -0,0 +1,73 @@ > +language: c > +compiler: > + - gcc > + - clang > + > +dist: xenial Are we going to update the distribution frequently? Why not adding more distros? > +os: > + - linux Is it possible to run on FreeBSD? > +addons: > + apt: > + update: true > + packages: > + - [libnuma-dev, linux-headers-$(uname -r), python3-setuptools, python3-wheel, python3-pip, ninja-build] > + > +before_install: ./.ci/${TRAVIS_OS_NAME}-setup.sh > + > +sudo: false > + > +env: > + - DEF_LIB="static" > + - DEF_LIB="shared" > + - DEF_LIB="static" OPTS="-Denable_kmods=false" > + - DEF_LIB="shared" OPTS="-Denable_kmods=false" How is it different of the matrix below? Why testing disabling kmods? > + > +matrix: > + include: > + - env: DEF_LIB="static" OPTS="-Denable_kmods=false" AARCH64=1 > + compiler: gcc > + addons: > + apt: > + packages: > + - [libnuma-dev, linux-headers-$(uname -r), python3-setuptools, python3-wheel, python3-pip, ninja-build] > + - [gcc-aarch64-linux-gnu, libc6-dev-arm64-cross] Why packages are repeated here again? (sorry, I don't know Travis and I want to understand) > + - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" AARCH64=1 > + compiler: gcc > + addons: > + apt: > + packages: > + - [libnuma-dev, linux-headers-$(uname -r), python3-setuptools, python3-wheel, python3-pip, ninja-build] > + - [gcc-aarch64-linux-gnu, libc6-dev-arm64-cross] > + - env: DEF_LIB="static" > + compiler: gcc > + addons: > + apt: > + packages: > + - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4] > + - [libnuma-dev, linux-headers-$(uname -r), python3-setuptools, python3-wheel, python3-pip, ninja-build] > + - env: DEF_LIB="shared" > + compiler: gcc > + addons: > + apt: > + packages: > + - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4] > + - [libnuma-dev, linux-headers-$(uname -r), python3-setuptools, python3-wheel, python3-pip, ninja-build] > + - env: DEF_LIB="static" OPTS="-Denable_kmods=false" > + compiler: gcc > + addons: > + apt: > + packages: > + - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4] > + - [libnuma-dev, linux-headers-$(uname -r), python3-setuptools, python3-wheel, python3-pip, ninja-build] > + - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" > + compiler: gcc > + addons: > + apt: > + packages: > + - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4] > + - [libnuma-dev, linux-headers-$(uname -r), python3-setuptools, python3-wheel, python3-pip, ninja-build] It seems clang is not in the matrix. Why? Thanks for this v6. I will be available to follow more closely in next days, so we can merge this feature soon this week. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B9320A00E6 for ; Wed, 20 Mar 2019 17:01:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BEC731B1EE; Wed, 20 Mar 2019 17:01:29 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 8FBBD1B1EC for ; Wed, 20 Mar 2019 17:01:28 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EF4BA22BCB; Wed, 20 Mar 2019 12:01:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 20 Mar 2019 12:01:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=eYPIP3wtkcff/4asJ5geDrbtjKJLrmvDJEqfI9D3hV8=; b=qKV8R7/4+N2X V0cn3+irIO7UNG3JxepZoPbLOkEhVwiR6px8T+etqb8BE98srm2l8oT/Rqbo2hSG lNhXq8oDhZdViLRIV02MqENxG8jkS0sgvZU4xfWqWeHARfJ6lzw4RT3fNe8TT0Cd X6v8ZWAyammWcAt2p/NzHO31qvb7gRM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=eYPIP3wtkcff/4asJ5geDrbtjKJLrmvDJEqfI9D3h V8=; b=VJVyugfqSwCZwaljtJBa7y34r6mTD1xSKl2Rz6VM1N1n2TdTUR7fT1+8s MBaDMuAZOZzTh5I3GOUBMk2d/g76/2Ed3YXPz/SroZD7GuxCoxxvMBp0+tKAJvDr PecV8GO/Erzayvf/6gExrGJtqXbgKnrOYnCM6cVaVLAQ2iWbqbUIL774HV0kssJ6 LQ0M4XcCbeGFVrM0HgC6N3PcR5MyTx/mh9ZbvRRRBlxqL6kLjKv2H+hinDQ4P3lP /eAo0yd9AMNVDOzi579+Tkie4YJSMoFQmlbUV9M+4DI6KtkUAQ5WBIG6y8wE9Ols J1p2WUOfbHQrCBz87QgYxfLswTGwA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrieeigdekfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepshgrnhhtrghnrgdrtghipddvuddrtghinecukfhppeejjedrudefgedrvddt fedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlh honhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F00F3E4980; Wed, 20 Mar 2019 12:01:25 -0400 (EDT) From: Thomas Monjalon To: Michael Santana , Aaron Conole Cc: dev@dpdk.org, Bruce Richardson , Honnappa Nagarahalli Date: Wed, 20 Mar 2019 17:01:24 +0100 Message-ID: <9486436.3HrUK5duha@xps> In-Reply-To: <20190304161232.5670-2-msantana@redhat.com> References: <20190207220114.8020-1-msantana@redhat.com> <20190304161232.5670-1-msantana@redhat.com> <20190304161232.5670-2-msantana@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6 1/1] ci: Introduce travis builds for github repositories X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190320160124.LUSBuuxB6920J5QJD1SJ8vbszlP-r0N98NaYYYNKrks@z> Hi, 04/03/2019 17:12, Michael Santana: > .ci/linux-build.sh | 21 +++++++++ > .ci/linux-setup.sh | 3 ++ > .travis.yml | 73 +++++++++++++++++++++++++++++ Please, could you explain somewhere what is the relationship between these files? What is specific to Travis? What is specific to GitHub? May we add "travis-" as filename prefix of the scripts? Or rename .ci to .travis? > +++ b/.ci/linux-build.sh > @@ -0,0 +1,21 @@ > +#!/bin/bash -xe If possible, I would prefer a simple /bin/sh. > +function on_error() { > + FILES_TO_PRINT=( "build/meson-logs/testlog.txt" "build/.ninja_log" "build/meson-logs/meson-log.txt") > + > + for pr_file in "${FILES_TO_PRINT[@]}"; do You can make FILES_TO_PRINT as a simple word list, and so avoid bashism. [...] > +if [ "${AARCH64}" == "1" ]; then Please explain in the comment where this variable comes from. I suggest renaming it to ARMV8 as this is what it is translated to: > + # convert the arch specifier > + OPTS="${OPTS} -DRTE_ARCH_64=1 --cross-file config/arm/arm64_armv8_linuxapp_gcc" I think -DRTE_ARCH_64=1 is useless. > +fi > + > +OPTS="$OPTS --default-library=$DEF_LIB" > +meson build --werror -Dexamples=all ${OPTS} > +ninja -C build [...] > --- /dev/null > +++ b/.travis.yml > @@ -0,0 +1,73 @@ > +language: c > +compiler: > + - gcc > + - clang > + > +dist: xenial Are we going to update the distribution frequently? Why not adding more distros? > +os: > + - linux Is it possible to run on FreeBSD? > +addons: > + apt: > + update: true > + packages: > + - [libnuma-dev, linux-headers-$(uname -r), python3-setuptools, python3-wheel, python3-pip, ninja-build] > + > +before_install: ./.ci/${TRAVIS_OS_NAME}-setup.sh > + > +sudo: false > + > +env: > + - DEF_LIB="static" > + - DEF_LIB="shared" > + - DEF_LIB="static" OPTS="-Denable_kmods=false" > + - DEF_LIB="shared" OPTS="-Denable_kmods=false" How is it different of the matrix below? Why testing disabling kmods? > + > +matrix: > + include: > + - env: DEF_LIB="static" OPTS="-Denable_kmods=false" AARCH64=1 > + compiler: gcc > + addons: > + apt: > + packages: > + - [libnuma-dev, linux-headers-$(uname -r), python3-setuptools, python3-wheel, python3-pip, ninja-build] > + - [gcc-aarch64-linux-gnu, libc6-dev-arm64-cross] Why packages are repeated here again? (sorry, I don't know Travis and I want to understand) > + - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" AARCH64=1 > + compiler: gcc > + addons: > + apt: > + packages: > + - [libnuma-dev, linux-headers-$(uname -r), python3-setuptools, python3-wheel, python3-pip, ninja-build] > + - [gcc-aarch64-linux-gnu, libc6-dev-arm64-cross] > + - env: DEF_LIB="static" > + compiler: gcc > + addons: > + apt: > + packages: > + - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4] > + - [libnuma-dev, linux-headers-$(uname -r), python3-setuptools, python3-wheel, python3-pip, ninja-build] > + - env: DEF_LIB="shared" > + compiler: gcc > + addons: > + apt: > + packages: > + - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4] > + - [libnuma-dev, linux-headers-$(uname -r), python3-setuptools, python3-wheel, python3-pip, ninja-build] > + - env: DEF_LIB="static" OPTS="-Denable_kmods=false" > + compiler: gcc > + addons: > + apt: > + packages: > + - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4] > + - [libnuma-dev, linux-headers-$(uname -r), python3-setuptools, python3-wheel, python3-pip, ninja-build] > + - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" > + compiler: gcc > + addons: > + apt: > + packages: > + - [libbsd-dev, libpcap-dev, libcrypto++-dev, libjansson4] > + - [libnuma-dev, linux-headers-$(uname -r), python3-setuptools, python3-wheel, python3-pip, ninja-build] It seems clang is not in the matrix. Why? Thanks for this v6. I will be available to follow more closely in next days, so we can merge this feature soon this week.