From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id EC72F239; Thu, 8 Nov 2018 12:16:18 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Nov 2018 03:16:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,478,1534834800"; d="scan'208";a="94630789" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.143]) ([10.237.220.143]) by FMSMGA003.fm.intel.com with ESMTP; 08 Nov 2018 03:16:15 -0800 To: Ilya Maximets , dev@dpdk.org, Qi Zhang Cc: Wenzhuo Lu , Konstantin Ananyev , Laurent Hardy , Ferruh Yigit , stable@dpdk.org References: <20181108102401.23599-1-i.maximets@samsung.com> From: "Burakov, Anatoly" Message-ID: <949e348c-9612-6a4f-ac2c-532af9ee9dd1@intel.com> Date: Thu, 8 Nov 2018 11:16:14 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181108102401.23599-1-i.maximets@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: stop link setup alarm handler before device start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2018 11:16:19 -0000 On 08-Nov-18 10:24 AM, Ilya Maximets wrote: > We should stop alarm handler before resetting the HW to > avoid concurrent device reconfiguration. > > Fixes: 0408f47ba4d6 ("net/ixgbe: fix busy polling while fiber link update") > CC: stable@dpdk.org > > Signed-off-by: Ilya Maximets > --- Tested-by: Anatoly Burakov I can confirm that this fixes issue with pktgen where init was failing if the link wasn't up. -- Thanks, Anatoly