DPDK patches and discussions
 help / color / mirror / Atom feed
From: Nissim Nisimov <NissimN@Radware.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal:Map rte cfg and uio at the end of hugepage	mem
Date: Thu, 15 Oct 2015 12:46:53 +0000	[thread overview]
Message-ID: <94AA676E9B9A384A844E7692F3CAD906C54F8B6B@ILMB2.corp.radware.com> (raw)
In-Reply-To: <C6ECDF3AB251BE4894318F4E4512369780D52ED7@IRSMSX109.ger.corp.intel.com>

Hi Anatoly,


Actually the use of --base-virtaddr will be valuable only when user know in advance the virtual addresses he wishes for huge pages in his application.

We found out that in some of the cases we don't know it in advance and propose a more generic solution which will solve the below issue without user interfering.

If user --base-virtaddr is not null (i.e user know the addresses he wants for the hugepages) our changes will be disabled and the code will act exactly as today without the patch.

Pls let me know if u have any more doubts.

Thx
Nissim

-----Original Message-----
From: Burakov, Anatoly [mailto:anatoly.burakov@intel.com] 
Sent: Thursday, October 15, 2015 3:33 PM
To: Nissim Nisimov; dev@dpdk.org
Subject: RE: [dpdk-dev] [PATCH] eal:Map rte cfg and uio at the end of hugepage mem

Hi

> Problem:
> In DPDK Primary/Secondary module we assume mapping same regions of 
> virtual memory addresses for Primary process and Secondary.
> An issue may occur when the Primary and secondary processes are not 
> symmetric in such way that the code is not the same (for example, 
> Primary process is a traffic distributer and secondary is a worker). 
> The result may be that specific virtual address region in the first 
> process won't be available in the second process.
> 
> Changes done at eal init:
> map all related rte configuration and uio sections close to the end of 
> huge pages memory (that mean rte_eal_memory_init() should be called 
> before
> rte_config_init() in primary process)
> According to our observations there will be more probability to 
> success when allocating rte_config and uio memzones after huge pages 
> sections (actually uio is already allocated after the huge pages area)

Not sure I understand the purpose of the patch. Doesn't --base-virtaddr flag solve your issues?

Thanks,
Anatoly

      reply	other threads:[~2015-10-15 12:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-15 12:16 Nissim Nisimov
2015-10-15 12:32 ` Burakov, Anatoly
2015-10-15 12:46   ` Nissim Nisimov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94AA676E9B9A384A844E7692F3CAD906C54F8B6B@ILMB2.corp.radware.com \
    --to=nissimn@radware.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).